From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E57C169C4 for ; Tue, 29 Jan 2019 10:22:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9C682148E for ; Tue, 29 Jan 2019 10:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548757333; bh=glqJMskbjYGGoyYPlpicm+oJxGTxat9oQLAaO8n56Ec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=z7WsyZ3mVOLd6QPxMYpOaupBTK9FNYG42o7cXw/17B3akXnJBqfYnr9XTt62N7QwT VCdR9d71waIPzzYLPdBb5VcoaRPBmEfYxnofaN7uqYGm8zBpuCo74Golp9TYcUvlEr oTztQ/3VTc/Nlwv/rT6bksOJI09HpljIB0HvRLYo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725811AbfA2KWN (ORCPT ); Tue, 29 Jan 2019 05:22:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:52480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbfA2KWM (ORCPT ); Tue, 29 Jan 2019 05:22:12 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D1E221473; Tue, 29 Jan 2019 10:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548757332; bh=glqJMskbjYGGoyYPlpicm+oJxGTxat9oQLAaO8n56Ec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f9P++08hm/UD443Jbgm8HW2p6Xpo8ML0SrQuOJzkRdKO+WIattywbq0HKnsqGeDkM VCGoqg7y+tUyMBq0wkScHRG2bnk5NFGKa8M7YvCEk6+gte+LDqkjVdoGJHfoNV1PQS NoNddFmhgK9vBbLnlYtTdGrh1nNzjzIz3x1rLoUc= Date: Tue, 29 Jan 2019 11:22:10 +0100 From: Greg KH To: Evan Green Cc: "He, Bo" , Felipe Balbi , "stable@vger.kernel.org" , Alan Stern , Sam Protsenko , Doug Anderson , Stephen Boyd , Matthias Kaehlcke Subject: Re: Backporting dwc3 gadget fixes Message-ID: <20190129102210.GA12232@kroah.com> References: <8736pjkhp6.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 23, 2019 at 10:46:52AM -0800, Evan Green wrote: > Hi Felipe, > Well, I've only tried on the one device that has a dwc3 controller. > Given that the bug was "scheduling while atomic", the stack trace > always had dwc3_gadget_ep_dequeue doing the sleeping, and it only > happened when I had a gadget plugged in, I felt pretty solid that this > was the same bug. > > Also, Matthias pointed out I was looking at an older series when I was > figuring out which patches went together. Check my work, but the > series seems to be here: > https://patchwork.kernel.org/project/linux-usb/list/?series=42875 > > The first 3 patches are already backported. Then there were a couple > extra I had missed before. So the complete set would look like: > > d53701067f04 usb: dwc3: gadget: check if dep->frame_number is still valid > 3451f6affaef usb: dwc3: gadget: remove unnecessary dev_info() > 1517265228b4 usb: dwc3: trace: log ep commands in hex > 25abad6a0584 usb: dwc3: gadget: return errors from __dwc3_gadget_start_isoc() > fec9095bdef4e usb: dwc3: gadget: remove wait_end_transfer > d4f1afe5e896c usb: dwc3: gadget: move requests to cancelled_list > d5443bbf5fc8f usb: dwc3: gadget: introduce cancelled_list > 7746a8dfb3f9c usb: dwc3: gadget: extract dwc3_gadget_ep_skip_trbs() > c3acd59014148 usb: dwc3: gadget: use num_trbs when skipping TRBs on ->dequeue() > 09fe1f8d7e2f4 usb: dwc3: gadget: track number of TRBs per request > 1a22ec6435806 usb: dwc3: gadget: combine unaligned and zero flags > > Though perhaps only the stuff up through "move requests to > cancelled_list" is the important stuff... Felipe might be able to say > better. Can someone send me a correct list of exactly what patches to commit, to what kernel tree(s), and in what order? Ideally you would have also tested them yourself... As it is, this "random list of commits" doesn't make me feel good about backporting. thanks, greg k-h