From: Varun Prakash <varun@chelsio.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] scsi: csiostor: Remove set but not used variable 'pln'
Date: Tue, 29 Jan 2019 15:41:38 +0000 [thread overview]
Message-ID: <20190129152936.GA1660@chelsio.com> (raw)
In-Reply-To: <1548381439-97080-1-git-send-email-yuehaibing@huawei.com>
On Fri, Jan 25, 2019 at 01:57:19AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/csiostor/csio_attr.c: In function 'csio_fcoe_free_vnp':
> drivers/scsi/csiostor/csio_attr.c:500:21: warning:
> variable 'pln' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/csiostor/csio_attr.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/csiostor/csio_attr.c b/drivers/scsi/csiostor/csio_attr.c
> index 9bd2bd8..200e500 100644
> --- a/drivers/scsi/csiostor/csio_attr.c
> +++ b/drivers/scsi/csiostor/csio_attr.c
> @@ -497,7 +497,6 @@
> static int
> csio_fcoe_free_vnp(struct csio_hw *hw, struct csio_lnode *ln)
> {
> - struct csio_lnode *pln;
> struct csio_mb *mbp;
> struct fw_fcoe_vnp_cmd *rsp;
> int ret = 0;
> @@ -514,8 +513,6 @@
> goto out;
> }
>
> - pln = ln->pln;
> -
> csio_fcoe_vnp_free_init_mb(ln, mbp, CSIO_MB_DEFAULT_TMO,
> ln->fcf_flowid, ln->vnp_flowid,
> NULL);
>
>
Acked-by: Varun Prakash <varun@chelsio.com>
next prev parent reply other threads:[~2019-01-29 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 1:57 [PATCH -next] scsi: csiostor: Remove set but not used variable 'pln' YueHaibing
2019-01-29 15:41 ` Varun Prakash [this message]
2019-02-01 23:20 ` Martin K. Petersen
2019-10-29 6:15 ` [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln' YueHaibing
2019-10-29 6:15 ` YueHaibing
2019-11-13 2:29 ` Martin K. Petersen
2019-11-13 2:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129152936.GA1660@chelsio.com \
--to=varun@chelsio.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.