From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id C482F7D04D for ; Tue, 29 Jan 2019 16:28:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbfA2Q2X (ORCPT ); Tue, 29 Jan 2019 11:28:23 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:56243 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbfA2Q2X (ORCPT ); Tue, 29 Jan 2019 11:28:23 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 88C35803A1; Tue, 29 Jan 2019 17:28:20 +0100 (CET) Date: Tue, 29 Jan 2019 17:28:19 +0100 From: Sam Ravnborg To: Sean Paul Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, Maxime Ripard , David Airlie , Sean Paul Subject: Re: [PATCH] drm/TODO: Add vrefresh replacement to the todo Message-ID: <20190129162819.GA30803@ravnborg.org> References: <20190129161611.241599-1-sean@poorly.run> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129161611.241599-1-sean@poorly.run> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=cm27Pg_UAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=jPffMzPaPsipmjaQQJAA:9 a=yLM0eJMvxk8QBGgi:21 a=rDyO8_-3u5PkMvxz:21 a=CjuIK1q_8ugA:10 a=Ctdz5JVgVzkA:10 a=xmb-EsYY8bH0VWELuYED:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Jan 29, 2019 at 11:15:51AM -0500, Sean Paul wrote: > From: Sean Paul > > Suggested-by: Daniel Vetter > Signed-off-by: Sean Paul Reviewed-by: Sam Ravnborg > --- > Documentation/gpu/todo.rst | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 38360ede12215..7fc30380eaf6c 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -262,6 +262,21 @@ As a reference, take a look at the conversions already completed in drm core. > > Contact: Sean Paul, respective driver maintainers > > +Convert direct mode.vrefresh accesses to use drm_mode_vrefresh() > +---------------------------------------------------------------- > + > +drm_display_mode.vrefresh isn't guaranteed to be populated. As such, using it > +is risky and has been known to cause div-by-zero bugs. Fortunately, drm core > +has helper which will use mode.vrefresh if it's !0 and will calculate it from > +the timings when it's 0. > + > +Use simple search/replace, or (more fun) cocci to replace instances of direct > +vrefresh access with a call to the helper. Check out > +https://lists.freedesktop.org/archives/dri-devel/2019-January/205186.html for > +inspiration. Bonus points for the link! Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] drm/TODO: Add vrefresh replacement to the todo Date: Tue, 29 Jan 2019 17:28:19 +0100 Message-ID: <20190129162819.GA30803@ravnborg.org> References: <20190129161611.241599-1-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id F050789CC1 for ; Tue, 29 Jan 2019 16:28:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190129161611.241599-1-sean@poorly.run> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Maxime Ripard , David Airlie , Sean Paul , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMjksIDIwMTkgYXQgMTE6MTU6NTFBTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IFN1Z2dlc3Rl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IFNl YW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgoKUmV2aWV3ZWQtYnk6IFNhbSBSYXZuYm9y ZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiAtLS0KPiAgRG9jdW1lbnRhdGlvbi9ncHUvdG9kby5yc3Qg fCAxNSArKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKykK PiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9ncHUvdG9kby5yc3QgYi9Eb2N1bWVudGF0 aW9uL2dwdS90b2RvLnJzdAo+IGluZGV4IDM4MzYwZWRlMTIyMTUuLjdmYzMwMzgwZWFmNmMgMTAw NjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9ncHUvdG9kby5yc3QKPiArKysgYi9Eb2N1bWVudGF0 aW9uL2dwdS90b2RvLnJzdAo+IEBAIC0yNjIsNiArMjYyLDIxIEBAIEFzIGEgcmVmZXJlbmNlLCB0 YWtlIGEgbG9vayBhdCB0aGUgY29udmVyc2lvbnMgYWxyZWFkeSBjb21wbGV0ZWQgaW4gZHJtIGNv cmUuCj4gIAo+ICBDb250YWN0OiBTZWFuIFBhdWwsIHJlc3BlY3RpdmUgZHJpdmVyIG1haW50YWlu ZXJzCj4gIAo+ICtDb252ZXJ0IGRpcmVjdCBtb2RlLnZyZWZyZXNoIGFjY2Vzc2VzIHRvIHVzZSBk cm1fbW9kZV92cmVmcmVzaCgpCj4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiArCj4gK2RybV9kaXNwbGF5X21vZGUudnJl ZnJlc2ggaXNuJ3QgZ3VhcmFudGVlZCB0byBiZSBwb3B1bGF0ZWQuIEFzIHN1Y2gsIHVzaW5nIGl0 Cj4gK2lzIHJpc2t5IGFuZCBoYXMgYmVlbiBrbm93biB0byBjYXVzZSBkaXYtYnktemVybyBidWdz LiBGb3J0dW5hdGVseSwgZHJtIGNvcmUKPiAraGFzIGhlbHBlciB3aGljaCB3aWxsIHVzZSBtb2Rl LnZyZWZyZXNoIGlmIGl0J3MgITAgYW5kIHdpbGwgY2FsY3VsYXRlIGl0IGZyb20KPiArdGhlIHRp bWluZ3Mgd2hlbiBpdCdzIDAuCj4gKwo+ICtVc2Ugc2ltcGxlIHNlYXJjaC9yZXBsYWNlLCBvciAo bW9yZSBmdW4pIGNvY2NpIHRvIHJlcGxhY2UgaW5zdGFuY2VzIG9mIGRpcmVjdAo+ICt2cmVmcmVz aCBhY2Nlc3Mgd2l0aCBhIGNhbGwgdG8gdGhlIGhlbHBlci4gQ2hlY2sgb3V0Cj4gK2h0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE5LUphbnVhcnkvMjA1 MTg2Lmh0bWwgZm9yCj4gK2luc3BpcmF0aW9uLgpCb251cyBwb2ludHMgZm9yIHRoZSBsaW5rIQoK CVNhbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK