From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id C4A547D04D for ; Tue, 29 Jan 2019 16:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727848AbfA2Qfs (ORCPT ); Tue, 29 Jan 2019 11:35:48 -0500 Received: from mga04.intel.com ([192.55.52.120]:49572 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbfA2Qfs (ORCPT ); Tue, 29 Jan 2019 11:35:48 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 08:35:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,537,1539673200"; d="scan'208";a="142414817" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga001.fm.intel.com with SMTP; 29 Jan 2019 08:35:45 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 29 Jan 2019 18:35:44 +0200 Date: Tue, 29 Jan 2019 18:35:44 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sean Paul Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, Maxime Ripard , David Airlie , Sean Paul Subject: Re: [PATCH] drm/TODO: Add vrefresh replacement to the todo Message-ID: <20190129163544.GE20097@intel.com> References: <20190129161611.241599-1-sean@poorly.run> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190129161611.241599-1-sean@poorly.run> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Jan 29, 2019 at 11:15:51AM -0500, Sean Paul wrote: > From: Sean Paul > > Suggested-by: Daniel Vetter > Signed-off-by: Sean Paul > --- > Documentation/gpu/todo.rst | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 38360ede12215..7fc30380eaf6c 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -262,6 +262,21 @@ As a reference, take a look at the conversions already completed in drm core. > > Contact: Sean Paul, respective driver maintainers > > +Convert direct mode.vrefresh accesses to use drm_mode_vrefresh() > +---------------------------------------------------------------- > + > +drm_display_mode.vrefresh isn't guaranteed to be populated. As such, using it > +is risky and has been known to cause div-by-zero bugs. Fortunately, drm core > +has helper which will use mode.vrefresh if it's !0 and will calculate it from > +the timings when it's 0. > + > +Use simple search/replace, or (more fun) cocci to replace instances of direct > +vrefresh access with a call to the helper. Check out > +https://lists.freedesktop.org/archives/dri-devel/2019-January/205186.html for > +inspiration. I would suggest just nuking mode.vrefresh entirely because we don't want to risk drm_mode_vrefresh() returning some stale value. > + > +Contact: Sean Paul > + > Core refactorings > ================= > > -- > Sean Paul, Software Engineer, Google / Chromium OS > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/TODO: Add vrefresh replacement to the todo Date: Tue, 29 Jan 2019 18:35:44 +0200 Message-ID: <20190129163544.GE20097@intel.com> References: <20190129161611.241599-1-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 10D4C6E332 for ; Tue, 29 Jan 2019 16:35:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190129161611.241599-1-sean@poorly.run> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Maxime Ripard , David Airlie , Sean Paul , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMjksIDIwMTkgYXQgMTE6MTU6NTFBTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IFN1Z2dlc3Rl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IFNl YW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL2dw dS90b2RvLnJzdCB8IDE1ICsrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5z ZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2dwdS90b2RvLnJzdCBi L0RvY3VtZW50YXRpb24vZ3B1L3RvZG8ucnN0Cj4gaW5kZXggMzgzNjBlZGUxMjIxNS4uN2ZjMzAz ODBlYWY2YyAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2dwdS90b2RvLnJzdAo+ICsrKyBi L0RvY3VtZW50YXRpb24vZ3B1L3RvZG8ucnN0Cj4gQEAgLTI2Miw2ICsyNjIsMjEgQEAgQXMgYSBy ZWZlcmVuY2UsIHRha2UgYSBsb29rIGF0IHRoZSBjb252ZXJzaW9ucyBhbHJlYWR5IGNvbXBsZXRl ZCBpbiBkcm0gY29yZS4KPiAgCj4gIENvbnRhY3Q6IFNlYW4gUGF1bCwgcmVzcGVjdGl2ZSBkcml2 ZXIgbWFpbnRhaW5lcnMKPiAgCj4gK0NvbnZlcnQgZGlyZWN0IG1vZGUudnJlZnJlc2ggYWNjZXNz ZXMgdG8gdXNlIGRybV9tb2RlX3ZyZWZyZXNoKCkKPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICsKPiArZHJtX2Rpc3Bs YXlfbW9kZS52cmVmcmVzaCBpc24ndCBndWFyYW50ZWVkIHRvIGJlIHBvcHVsYXRlZC4gQXMgc3Vj aCwgdXNpbmcgaXQKPiAraXMgcmlza3kgYW5kIGhhcyBiZWVuIGtub3duIHRvIGNhdXNlIGRpdi1i eS16ZXJvIGJ1Z3MuIEZvcnR1bmF0ZWx5LCBkcm0gY29yZQo+ICtoYXMgaGVscGVyIHdoaWNoIHdp bGwgdXNlIG1vZGUudnJlZnJlc2ggaWYgaXQncyAhMCBhbmQgd2lsbCBjYWxjdWxhdGUgaXQgZnJv bQo+ICt0aGUgdGltaW5ncyB3aGVuIGl0J3MgMC4KPiArCj4gK1VzZSBzaW1wbGUgc2VhcmNoL3Jl cGxhY2UsIG9yIChtb3JlIGZ1bikgY29jY2kgdG8gcmVwbGFjZSBpbnN0YW5jZXMgb2YgZGlyZWN0 Cj4gK3ZyZWZyZXNoIGFjY2VzcyB3aXRoIGEgY2FsbCB0byB0aGUgaGVscGVyLiBDaGVjayBvdXQK PiAraHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTkt SmFudWFyeS8yMDUxODYuaHRtbCBmb3IKPiAraW5zcGlyYXRpb24uCgpJIHdvdWxkIHN1Z2dlc3Qg anVzdCBudWtpbmcgbW9kZS52cmVmcmVzaCBlbnRpcmVseSBiZWNhdXNlIHdlCmRvbid0IHdhbnQg dG8gcmlzayBkcm1fbW9kZV92cmVmcmVzaCgpIHJldHVybmluZyBzb21lIHN0YWxlCnZhbHVlLgoK PiArCj4gK0NvbnRhY3Q6IFNlYW4gUGF1bAo+ICsKPiAgQ29yZSByZWZhY3RvcmluZ3MKPiAgPT09 PT09PT09PT09PT09PT0KPiAgCj4gLS0gCj4gU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwg R29vZ2xlIC8gQ2hyb21pdW0gT1MKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==