From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/ustat: convert to new lib, use direct syscall
Date: Tue, 29 Jan 2019 19:06:17 +0100 [thread overview]
Message-ID: <20190129180617.GD14252@dell5510> (raw)
In-Reply-To: <20190129023714.191820-1-smuckle@google.com>
Hi Steve, Cyril,
> +++ b/include/lapi/ustat.h
> @@ -0,0 +1,8 @@
> +#include <sys/types.h>
I'd put here at least
//SPDX-License-Identifier: GPL-2.0-or-later
> +
> +struct ustat {
> + daddr_t f_tfree;
> + ino_t f_tinode;
> + char f_fname[6];
> + char f_fpack[6];
> +};
Thinking about it twice, wouldn't be better to include <sys/ustat.h> and detect
with autotools whether struct ustat is defined and use this only if it's not
defined? The same approach we use for struct statx?
> +++ b/testcases/kernel/syscalls/ustat/ustat01.c
> @@ -1,21 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0
@Cyril: can we use GPL-2.0-or-later? Original was GPL only.
> /*
> * Copyright (c) Wipro Technologies Ltd, 2003. All Rights Reserved.
> *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it would be useful, but
> - * WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> - *
> - * You should have received a copy of the GNU General Public License along
> - * with this program; if not, write the Free Software Foundation, Inc.,
> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> - *
> - */
Kind regards,
Petr
next prev parent reply other threads:[~2019-01-29 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 2:37 [LTP] [PATCH] syscalls/ustat: convert to new lib, use direct syscall Steve Muckle
2019-01-29 17:55 ` Petr Vorel
2019-01-29 18:06 ` Petr Vorel [this message]
2019-01-30 10:40 ` Cyril Hrubis
2019-02-02 0:19 ` Steve Muckle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129180617.GD14252@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.