From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: [RFC PATCH 1/5] pci/p2p: add a function to test peer to peer capability Date: Tue, 29 Jan 2019 16:00:08 -0500 Message-ID: <20190129210007.GO3176@redhat.com> References: <20190129174728.6430-1-jglisse@redhat.com> <20190129174728.6430-2-jglisse@redhat.com> <20190129194426.GB32069@kroah.com> <8b4e0157-4eaf-c79a-28d0-7a266abe2207@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <8b4e0157-4eaf-c79a-28d0-7a266abe2207@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Logan Gunthorpe Cc: Joerg Roedel , "Rafael J . Wysocki" , Greg Kroah-Hartman , Felix Kuehling , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christoph Hellwig , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Jason Gunthorpe , linux-pci@vger.kernel.org, Bjorn Helgaas , Robin Murphy , Christian Koenig , Marek Szyprowski List-Id: iommu@lists.linux-foundation.org T24gVHVlLCBKYW4gMjksIDIwMTkgYXQgMDE6NDQ6MDlQTSAtMDcwMCwgTG9nYW4gR3VudGhvcnBl IHdyb3RlOgo+IAo+IAo+IE9uIDIwMTktMDEtMjkgMTI6NDQgcC5tLiwgR3JlZyBLcm9haC1IYXJ0 bWFuIHdyb3RlOgo+ID4gT24gVHVlLCBKYW4gMjksIDIwMTkgYXQgMTE6MjQ6MDlBTSAtMDcwMCwg TG9nYW4gR3VudGhvcnBlIHdyb3RlOgo+ID4+Cj4gPj4KPiA+PiBPbiAyMDE5LTAxLTI5IDEwOjQ3 IGEubS4sIGpnbGlzc2VAcmVkaGF0LmNvbSB3cm90ZToKPiA+Pj4gK2Jvb2wgcGNpX3Rlc3RfcDJw KHN0cnVjdCBkZXZpY2UgKmRldkEsIHN0cnVjdCBkZXZpY2UgKmRldkIpCj4gPj4+ICt7Cj4gPj4+ ICsJc3RydWN0IHBjaV9kZXYgKnBjaUEsICpwY2lCOwo+ID4+PiArCWJvb2wgcmV0Owo+ID4+PiAr CWludCB0bXA7Cj4gPj4+ICsKPiA+Pj4gKwkvKgo+ID4+PiArCSAqIEZvciBub3cgd2Ugb25seSBz dXBwb3J0IFBDSUUgcGVlciB0byBwZWVyIGJ1dCBvdGhlciBpbnRlci1jb25uZWN0Cj4gPj4+ICsJ ICogY2FuIGJlIGFkZGVkLgo+ID4+PiArCSAqLwo+ID4+PiArCXBjaUEgPSBmaW5kX3BhcmVudF9w Y2lfZGV2KGRldkEpOwo+ID4+PiArCXBjaUIgPSBmaW5kX3BhcmVudF9wY2lfZGV2KGRldkIpOwo+ ID4+PiArCWlmIChwY2lBID09IE5VTEwgfHwgcGNpQiA9PSBOVUxMKSB7Cj4gPj4+ICsJCXJldCA9 IGZhbHNlOwo+ID4+PiArCQlnb3RvIG91dDsKPiA+Pj4gKwl9Cj4gPj4+ICsKPiA+Pj4gKwl0bXAg PSB1cHN0cmVhbV9icmlkZ2VfZGlzdGFuY2UocGNpQSwgcGNpQiwgTlVMTCk7Cj4gPj4+ICsJcmV0 ID0gdG1wIDwgMCA/IGZhbHNlIDogdHJ1ZTsKPiA+Pj4gKwo+ID4+PiArb3V0Ogo+ID4+PiArCXBj aV9kZXZfcHV0KHBjaUIpOwo+ID4+PiArCXBjaV9kZXZfcHV0KHBjaUEpOwo+ID4+PiArCXJldHVy biBmYWxzZTsKPiA+Pj4gK30KPiA+Pj4gK0VYUE9SVF9TWU1CT0xfR1BMKHBjaV90ZXN0X3AycCk7 Cj4gPj4KPiA+PiBUaGlzIGZ1bmN0aW9uIG9ubHkgZXZlciByZXR1cm5zIGZhbHNlLi4uLgo+ID4g Cj4gPiBJIGd1ZXNzIGl0IHdhcyBuZXZyIGFjdHVhbGx5IHRlc3RlZCA6KAo+ID4gCj4gPiBJIGZl ZWwgcmVhbGx5IHdvcnJpZWQgYWJvdXQgcGFzc2luZyByYW5kb20gJ3N0cnVjdCBkZXZpY2UnIHBv aW50ZXJzIGludG8KPiA+IHRoZSBQQ0kgbGF5ZXIuICBBcmUgd2UgX3N1cmVfIGl0IGNhbiBoYW5k bGUgdGhpcyBwcm9wZXJseT8KPiAKPiBZZXMsIHRoZXJlIGFyZSBhIGNvdXBsZSBvZiBwY2lfcDJw ZG1hIGZ1bmN0aW9ucyB0aGF0IHRha2Ugc3RydWN0IGRldmljZXMKPiBkaXJlY3RseSBzaW1wbHkg YmVjYXVzZSBpdCdzIHdheSBtb3JlIGNvbnZlbmllbnQgZm9yIHRoZSBjYWxsZXIuIFRoYXQncwo+ IHdoYXQgZmluZF9wYXJlbnRfcGNpX2RldigpIHRha2VzIGNhcmUgb2YgKGl0IHJldHVybnMgZmFs c2UgaWYgdGhlIGRldmljZQo+IGlzIG5vdCBhIFBDSSBkZXZpY2UpLiBXaGV0aGVyIHRoYXQncyBh cHByb3ByaWF0ZSBoZXJlIGlzIGhhcmQgdG8gc2F5Cj4gc2VlaW5nIHdlIGhhdmVuJ3Qgc2VlbiBh bnkgY2FsbGVyIGNvZGUuCgpDYWxsZXIgY29kZSBhcyBhIHJlZmVyZW5jZSAoaSBhbHJlYWR5IGdp dmVuIHRoYXQgbGluayBpbiBvdGhlciBwYXJ0IG9mCnRocmVhZCBidXQganVzdCBzbyB0aGF0IHBl b3BsZSBkb24ndCBoYXZlIHRvIGZvbGxvdyBhbGwgYnJhbmNoZXMpLgoKaHR0cHM6Ly9jZ2l0LmZy ZWVkZXNrdG9wLm9yZy9+Z2xpc3NlL2xpbnV4L2NvbW1pdC8/aD1obW0tcDJwJmlkPTQwMWE1Njc2 OTZlYWZiMWQ0ZmFmNzA1NGFiMGQ3YzNhMTZhNWVmMDYKCkNoZWVycywKSsOpcsO0bWUKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1468FC169C4 for ; Tue, 29 Jan 2019 21:00:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E010120882 for ; Tue, 29 Jan 2019 21:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727686AbfA2VAO (ORCPT ); Tue, 29 Jan 2019 16:00:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38812 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727570AbfA2VAN (ORCPT ); Tue, 29 Jan 2019 16:00:13 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6751D58E22; Tue, 29 Jan 2019 21:00:13 +0000 (UTC) Received: from redhat.com (ovpn-122-2.rdu2.redhat.com [10.10.122.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3147460C6E; Tue, 29 Jan 2019 21:00:10 +0000 (UTC) Date: Tue, 29 Jan 2019 16:00:08 -0500 From: Jerome Glisse To: Logan Gunthorpe Cc: Greg Kroah-Hartman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Bjorn Helgaas , Christian Koenig , Felix Kuehling , Jason Gunthorpe , linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org, Christoph Hellwig , Marek Szyprowski , Robin Murphy , Joerg Roedel , iommu@lists.linux-foundation.org Subject: Re: [RFC PATCH 1/5] pci/p2p: add a function to test peer to peer capability Message-ID: <20190129210007.GO3176@redhat.com> References: <20190129174728.6430-1-jglisse@redhat.com> <20190129174728.6430-2-jglisse@redhat.com> <20190129194426.GB32069@kroah.com> <8b4e0157-4eaf-c79a-28d0-7a266abe2207@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8b4e0157-4eaf-c79a-28d0-7a266abe2207@deltatee.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 29 Jan 2019 21:00:13 +0000 (UTC) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jan 29, 2019 at 01:44:09PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-29 12:44 p.m., Greg Kroah-Hartman wrote: > > On Tue, Jan 29, 2019 at 11:24:09AM -0700, Logan Gunthorpe wrote: > >> > >> > >> On 2019-01-29 10:47 a.m., jglisse@redhat.com wrote: > >>> +bool pci_test_p2p(struct device *devA, struct device *devB) > >>> +{ > >>> + struct pci_dev *pciA, *pciB; > >>> + bool ret; > >>> + int tmp; > >>> + > >>> + /* > >>> + * For now we only support PCIE peer to peer but other inter-connect > >>> + * can be added. > >>> + */ > >>> + pciA = find_parent_pci_dev(devA); > >>> + pciB = find_parent_pci_dev(devB); > >>> + if (pciA == NULL || pciB == NULL) { > >>> + ret = false; > >>> + goto out; > >>> + } > >>> + > >>> + tmp = upstream_bridge_distance(pciA, pciB, NULL); > >>> + ret = tmp < 0 ? false : true; > >>> + > >>> +out: > >>> + pci_dev_put(pciB); > >>> + pci_dev_put(pciA); > >>> + return false; > >>> +} > >>> +EXPORT_SYMBOL_GPL(pci_test_p2p); > >> > >> This function only ever returns false.... > > > > I guess it was nevr actually tested :( > > > > I feel really worried about passing random 'struct device' pointers into > > the PCI layer. Are we _sure_ it can handle this properly? > > Yes, there are a couple of pci_p2pdma functions that take struct devices > directly simply because it's way more convenient for the caller. That's > what find_parent_pci_dev() takes care of (it returns false if the device > is not a PCI device). Whether that's appropriate here is hard to say > seeing we haven't seen any caller code. Caller code as a reference (i already given that link in other part of thread but just so that people don't have to follow all branches). https://cgit.freedesktop.org/~glisse/linux/commit/?h=hmm-p2p&id=401a567696eafb1d4faf7054ab0d7c3a16a5ef06 Cheers, Jérôme