From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1goddR-0001Jb-C6 for mharc-qemu-trivial@gnu.org; Tue, 29 Jan 2019 19:21:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goddO-0001Gz-Uh for qemu-trivial@nongnu.org; Tue, 29 Jan 2019 19:21:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goddM-00045K-UF for qemu-trivial@nongnu.org; Tue, 29 Jan 2019 19:21:42 -0500 Received: from mga01.intel.com ([192.55.52.88]:3447) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1goddD-0003yS-JV; Tue, 29 Jan 2019 19:21:34 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 16:07:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,538,1539673200"; d="scan'208";a="142536326" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.37]) by fmsmga001.fm.intel.com with ESMTP; 29 Jan 2019 16:07:30 -0800 From: Wei Yang To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Cc: mst@redhat.com, laurent@vivier.eu, imammedo@redhat.com, philmd@redhat.com, Wei Yang Date: Wed, 30 Jan 2019 08:06:53 +0800 Message-Id: <20190130000653.16267-4-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190130000653.16267-1-richardw.yang@linux.intel.com> References: <20190130000653.16267-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 Subject: [Qemu-trivial] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 00:21:43 -0000 acpi_table_builtin is now always false, it is not necessary to check it again. This patch just removes it. Signed-off-by: Wei Yang Reviewed-by: Philippe Mathieu-Daud茅 Tested-by: Philippe Mathieu-Daud茅 --- hw/acpi/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index e9b1a85e54..f9c96535d1 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -303,8 +303,6 @@ out: error_propagate(errp, err); } -static bool acpi_table_builtin = false; - unsigned acpi_table_len(void *current) { struct acpi_table_header *hdr = current - sizeof(hdr->_length); @@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h) uint8_t *acpi_table_first(void) { - if (acpi_table_builtin || !acpi_tables) { + if (!acpi_tables) { return NULL; } return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE); -- 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:53043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goddT-0001Ly-Ep for qemu-devel@nongnu.org; Tue, 29 Jan 2019 19:21:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goddR-000470-12 for qemu-devel@nongnu.org; Tue, 29 Jan 2019 19:21:47 -0500 From: Wei Yang Date: Wed, 30 Jan 2019 08:06:53 +0800 Message-Id: <20190130000653.16267-4-richardw.yang@linux.intel.com> In-Reply-To: <20190130000653.16267-1-richardw.yang@linux.intel.com> References: <20190130000653.16267-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Cc: mst@redhat.com, laurent@vivier.eu, imammedo@redhat.com, philmd@redhat.com, Wei Yang acpi_table_builtin is now always false, it is not necessary to check it again. This patch just removes it. Signed-off-by: Wei Yang Reviewed-by: Philippe Mathieu-Daud茅 Tested-by: Philippe Mathieu-Daud茅 --- hw/acpi/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index e9b1a85e54..f9c96535d1 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -303,8 +303,6 @@ out: error_propagate(errp, err); } -static bool acpi_table_builtin = false; - unsigned acpi_table_len(void *current) { struct acpi_table_header *hdr = current - sizeof(hdr->_length); @@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h) uint8_t *acpi_table_first(void) { - if (acpi_table_builtin || !acpi_tables) { + if (!acpi_tables) { return NULL; } return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE); -- 2.19.1