All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ajay Gupta <ajaykuee@gmail.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
	Ajay Gupta <ajayg@nvidia.com>
Subject: [v2,6/6] usb: typec: ucsi: add firmware flashing support
Date: Wed, 30 Jan 2019 08:49:35 +0100	[thread overview]
Message-ID: <20190130074935.GD21468@kroah.com> (raw)

On Mon, Jan 28, 2019 at 12:37:31PM -0800, Ajay Gupta wrote:
> +	/*****************************************************************
> +	 * CCG firmware image (.cyacd) file line format
> +	 *
> +	 * :00rrrrllll[dd....]cc/r/n
> +	 *
> +	 * :00   header
> +	 * rrrr is row number to flash				(4 char)
> +	 * llll is data len to flash				(4 char)
> +	 * dd   is a data field represents one byte of data	(512 char)
> +	 * cc   is checksum					(2 char)
> +	 * \r\n newline
> +	 *
> +	 * Total length: 3 + 4 + 4 + 512 + 2 + 2 = 527
> +	 *
> +	 *****************************************************************/

Any reason you can't just use ihex for this so that you don't have to
parse it all and you can just use the in-kernel functions for it?
Why make a custom firmware image type?

thanks,

greg k-h

             reply	other threads:[~2019-01-30  7:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  7:49 Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-31  0:48 [v2,6/6] usb: typec: ucsi: add firmware flashing support Ajay Gupta
2019-01-31  0:47 Ajay Gupta
2019-01-30  7:47 Greg Kroah-Hartman
2019-01-28 20:37 Ajay Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130074935.GD21468@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ajayg@nvidia.com \
    --cc=ajaykuee@gmail.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.