From: Johan Hovold <johan@kernel.org>
To: Myungho Jung <mhjungk@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Add NULL check for tiocmget() and tiocmset()
Date: Wed, 30 Jan 2019 10:59:38 +0100 [thread overview]
Message-ID: <20190130095938.GP3691@localhost> (raw)
In-Reply-To: <20190128065910.GA14959@myunghoj-Precision-5530>
On Sun, Jan 27, 2019 at 10:59:13PM -0800, Myungho Jung wrote:
> tiocmget() and tiocmset() operations are optional and some tty drivers
> like pty miss the operations. We need NULL check before referencing
> them.
Good catch. I suggest splitting these fixes in two separate patches
(after addressing Marcel's comments).
Don't forget to CC stable and add a Fixes-tag for each, as we we want to
have this backported to stable.
> Reported-by: syzbot+a950165cbb86bdd023a4@syzkaller.appspotmail.com
Actually, these two bugs were never reported by sysbot AFAIKT so no need
to give credit to anyone else here.
> Signed-off-by: Myungho Jung <mhjungk@gmail.com>
> ---
> drivers/bluetooth/hci_ath.c | 13 ++++++++-----
> drivers/bluetooth/hci_ldisc.c | 5 +++++
> 2 files changed, 13 insertions(+), 5 deletions(-)
Johan
next prev parent reply other threads:[~2019-01-30 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 6:59 [PATCH] Bluetooth: Add NULL check for tiocmget() and tiocmset() Myungho Jung
2019-01-28 12:16 ` Marcel Holtmann
2019-01-30 9:59 ` Johan Hovold [this message]
2019-01-31 5:08 ` Myungho Jung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130095938.GP3691@localhost \
--to=johan@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mhjungk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.