From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Ren=C3=A9=20van=20Dorst?= Subject: [PATCHv2] gpio: MT7621: use a per instance irq_chip structure Date: Wed, 30 Jan 2019 17:10:49 +0100 Message-ID: <20190130161048.9852-1-opensource@vdorst.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Linus Walleij , Bartosz Golaszewski , Matthias Brugger Cc: =?UTF-8?q?Ren=C3=A9=20van=20Dorst?= , gerg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-gpio@vger.kernel.org VGhpcyBmaXhlcyB0aGUga2VybmVsIGNvbXBsYWluczoKZ3BpbyBncGlvY2hpcDE6ICgxZTAwMDYw MC5ncGlvLWJhbmsxKTogZGV0ZWN0ZWQgaXJxY2hpcCB0aGF0IGlzIHNoYXJlZAoJICAgIHdpdGgg bXVsdGlwbGUgZ3Bpb2NoaXBzOiBwbGVhc2UgZml4IHRoZSBkcml2ZXIuCmdwaW8gZ3Bpb2NoaXAy OiAoMWUwMDA2MDAuZ3Bpby1iYW5rMik6IGRldGVjdGVkIGlycWNoaXAgdGhhdCBpcyBzaGFyZWQK CSAgICB3aXRoIG11bHRpcGxlIGdwaW9jaGlwczogcGxlYXNlIGZpeCB0aGUgZHJpdmVyLgoKRml4 ZXM6IDRiYTljM2FmZGE0MSAoImdwaW86IG10NzYyMTogQWRkIGEgZHJpdmVyIGZvciBNVDc2MjEi KQpTaWduZWQtb2ZmLWJ5OiBSZW7DqSB2YW4gRG9yc3QgPG9wZW5zb3VyY2VAdmRvcnN0LmNvbT4K Q2M6IGxpbnV4LWdwaW9Admdlci5rZXJuZWwub3JnCkNjOiBsaW51eC1tZWRpYXRla0BsaXN0cy5p bmZyYWRlYWQub3JnCkNjOiBnZXJnQGtlcm5lbC5vcmcKQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5v cmcKLS0tCiBkcml2ZXJzL2dwaW8vZ3Bpby1tdDc2MjEuYyB8IDIwICsrKysrKysrKystLS0tLS0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgp2 MjogUmVtb3ZlIGFuIGVtcHR5IGxpbmUKICAgIEFkZCBDYyBzdGFibGUKCmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwaW8vZ3Bpby1tdDc2MjEuYyBiL2RyaXZlcnMvZ3Bpby9ncGlvLW10NzYyMS5jCmlu ZGV4IDAwZTk1NGYyMmJjOS4uNzQ0MDFlMGFkYjI5IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwaW8v Z3Bpby1tdDc2MjEuYworKysgYi9kcml2ZXJzL2dwaW8vZ3Bpby1tdDc2MjEuYwpAQCAtMzAsNiAr MzAsNyBAQAogI2RlZmluZSBHUElPX1JFR19FREdFCQkweEEwCiAKIHN0cnVjdCBtdGtfZ2Mgewor CXN0cnVjdCBpcnFfY2hpcCBpcnFfY2hpcDsKIAlzdHJ1Y3QgZ3Bpb19jaGlwIGNoaXA7CiAJc3Bp bmxvY2tfdCBsb2NrOwogCWludCBiYW5rOwpAQCAtMTg5LDEzICsxOTAsNiBAQCBtZWRpYXRla19n cGlvX2lycV90eXBlKHN0cnVjdCBpcnFfZGF0YSAqZCwgdW5zaWduZWQgaW50IHR5cGUpCiAJcmV0 dXJuIDA7CiB9CiAKLXN0YXRpYyBzdHJ1Y3QgaXJxX2NoaXAgbWVkaWF0ZWtfZ3Bpb19pcnFfY2hp cCA9IHsKLQkuaXJxX3VubWFzawkJPSBtZWRpYXRla19ncGlvX2lycV91bm1hc2ssCi0JLmlycV9t YXNrCQk9IG1lZGlhdGVrX2dwaW9faXJxX21hc2ssCi0JLmlycV9tYXNrX2FjawkJPSBtZWRpYXRl a19ncGlvX2lycV9tYXNrLAotCS5pcnFfc2V0X3R5cGUJCT0gbWVkaWF0ZWtfZ3Bpb19pcnFfdHlw ZSwKLX07Ci0KIHN0YXRpYyBpbnQKIG1lZGlhdGVrX2dwaW9feGxhdGUoc3RydWN0IGdwaW9fY2hp cCAqY2hpcCwKIAkJICAgIGNvbnN0IHN0cnVjdCBvZl9waGFuZGxlX2FyZ3MgKnNwZWMsIHUzMiAq ZmxhZ3MpCkBAIC0yNTQsNiArMjQ4LDEzIEBAIG1lZGlhdGVrX2dwaW9fYmFua19wcm9iZShzdHJ1 Y3QgZGV2aWNlICpkZXYsCiAJCXJldHVybiByZXQ7CiAJfQogCisJcmctPmlycV9jaGlwLm5hbWUg PSBkZXZfbmFtZShkZXYpOworCXJnLT5pcnFfY2hpcC5wYXJlbnRfZGV2aWNlID0gZGV2OworCXJn LT5pcnFfY2hpcC5pcnFfdW5tYXNrID0gbWVkaWF0ZWtfZ3Bpb19pcnFfdW5tYXNrOworCXJnLT5p cnFfY2hpcC5pcnFfbWFzayA9IG1lZGlhdGVrX2dwaW9faXJxX21hc2s7CisJcmctPmlycV9jaGlw LmlycV9tYXNrX2FjayA9IG1lZGlhdGVrX2dwaW9faXJxX21hc2s7CisJcmctPmlycV9jaGlwLmly cV9zZXRfdHlwZSA9IG1lZGlhdGVrX2dwaW9faXJxX3R5cGU7CisKIAlpZiAobXRrLT5ncGlvX2ly cSkgewogCQkvKgogCQkgKiBNYW51YWxseSByZXF1ZXN0IHRoZSBpcnEgaGVyZSBpbnN0ZWFkIG9m IHBhc3NpbmcKQEAgLTI3MCwxNCArMjcxLDE0IEBAIG1lZGlhdGVrX2dwaW9fYmFua19wcm9iZShz dHJ1Y3QgZGV2aWNlICpkZXYsCiAJCQlyZXR1cm4gcmV0OwogCQl9CiAKLQkJcmV0ID0gZ3Bpb2No aXBfaXJxY2hpcF9hZGQoJnJnLT5jaGlwLCAmbWVkaWF0ZWtfZ3Bpb19pcnFfY2hpcCwKKwkJcmV0 ID0gZ3Bpb2NoaXBfaXJxY2hpcF9hZGQoJnJnLT5jaGlwLCAmcmctPmlycV9jaGlwLAogCQkJCQkg ICAwLCBoYW5kbGVfc2ltcGxlX2lycSwgSVJRX1RZUEVfTk9ORSk7CiAJCWlmIChyZXQpIHsKIAkJ CWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGFkZCBncGlvY2hpcF9pcnFjaGlwXG4iKTsKIAkJCXJl dHVybiByZXQ7CiAJCX0KIAotCQlncGlvY2hpcF9zZXRfY2hhaW5lZF9pcnFjaGlwKCZyZy0+Y2hp cCwgJm1lZGlhdGVrX2dwaW9faXJxX2NoaXAsCisJCWdwaW9jaGlwX3NldF9jaGFpbmVkX2lycWNo aXAoJnJnLT5jaGlwLCAmcmctPmlycV9jaGlwLAogCQkJCQkgICAgIG10ay0+Z3Bpb19pcnEsIE5V TEwpOwogCX0KIApAQCAtMzEwLDcgKzMxMSw2IEBAIG1lZGlhdGVrX2dwaW9fcHJvYmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAltdGstPmdwaW9faXJxID0gaXJxX29mX3BhcnNlX2Fu ZF9tYXAobnAsIDApOwogCW10ay0+ZGV2ID0gZGV2OwogCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBk ZXYsIG10ayk7Ci0JbWVkaWF0ZWtfZ3Bpb19pcnFfY2hpcC5uYW1lID0gZGV2X25hbWUoZGV2KTsK IAogCWZvciAoaSA9IDA7IGkgPCBNVEtfQkFOS19DTlQ7IGkrKykgewogCQlyZXQgPSBtZWRpYXRl a19ncGlvX2JhbmtfcHJvYmUoZGV2LCBucCwgaSk7Ci0tIAoyLjE5LjEKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRlayBtYWlsaW5n IGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4609C282D7 for ; Wed, 30 Jan 2019 16:30:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 753D12087F for ; Wed, 30 Jan 2019 16:30:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=vdorst.com header.i=@vdorst.com header.b="Q9XXtAbB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731968AbfA3QaW (ORCPT ); Wed, 30 Jan 2019 11:30:22 -0500 Received: from mail.0dd.nl ([5.2.79.48]:50318 "EHLO mail.0dd.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731837AbfA3QaV (ORCPT ); Wed, 30 Jan 2019 11:30:21 -0500 X-Greylist: delayed 548 seconds by postgrey-1.27 at vger.kernel.org; Wed, 30 Jan 2019 11:30:19 EST Received: from mail.vdorst.com (mail.vdorst.com [IPv6:fd01::250]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.0dd.nl (Postfix) with ESMTPS id 1359D5FBBA; Wed, 30 Jan 2019 17:21:10 +0100 (CET) Received: from pc-rene.vdorst.com (unknown [IPv6:2a02:a453:deab:1:da50:e6ff:fed1:4a04]) by mail.vdorst.com (Postfix) with ESMTPA id BB08B144E22E; Wed, 30 Jan 2019 17:21:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.vdorst.com BB08B144E22E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vdorst.com; s=default; t=1548865269; bh=2xP4S+Wm3gHYdSo0LmOa8YFuGyOM5h7SS9B1JEhJuPs=; h=From:To:Cc:Subject:Date:From; b=Q9XXtAbB/GuH/mcXgHlkFZkQYfAC/kV8AwdVFW1wlCPcfZp2ACZGsEIE31W9l4G1V HLnGxN5D+CdyhVexSzX1tnc1+p500vdUSAS0CobKYIma6VXSq4ZkDzXlEmyKa5eopu 5JhUQIbqbqQUFQmqUmXhWWkom6okQ4ZnBkL0lMg7mQubhHLzHozBGBUdlNkzrMIB8R d5wH5Kmbl2VAPsh609VF7cVJpnQNbWGjtD4c9gCyLVqrsWHYSd+ue9/lkapUEfCWu3 6IXezV/pyanCUG+9mSoX+JjHlVhjFn/YF6Psw2ZrPnXDKI8NMpkumYxExeF0krlsch StI4UsEf55mpA== From: =?UTF-8?q?Ren=C3=A9=20van=20Dorst?= To: Linus Walleij , Bartosz Golaszewski , Matthias Brugger Cc: =?UTF-8?q?Ren=C3=A9=20van=20Dorst?= , linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, gerg@kernel.org, stable@vger.kernel.org Subject: [PATCHv2] gpio: MT7621: use a per instance irq_chip structure Date: Wed, 30 Jan 2019 17:10:49 +0100 Message-Id: <20190130161048.9852-1-opensource@vdorst.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This fixes the kernel complains: gpio gpiochip1: (1e000600.gpio-bank1): detected irqchip that is shared with multiple gpiochips: please fix the driver. gpio gpiochip2: (1e000600.gpio-bank2): detected irqchip that is shared with multiple gpiochips: please fix the driver. Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") Signed-off-by: René van Dorst Cc: linux-gpio@vger.kernel.org Cc: linux-mediatek@lists.infradead.org Cc: gerg@kernel.org Cc: stable@vger.kernel.org --- drivers/gpio/gpio-mt7621.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) v2: Remove an empty line Add Cc stable diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c index 00e954f22bc9..74401e0adb29 100644 --- a/drivers/gpio/gpio-mt7621.c +++ b/drivers/gpio/gpio-mt7621.c @@ -30,6 +30,7 @@ #define GPIO_REG_EDGE 0xA0 struct mtk_gc { + struct irq_chip irq_chip; struct gpio_chip chip; spinlock_t lock; int bank; @@ -189,13 +190,6 @@ mediatek_gpio_irq_type(struct irq_data *d, unsigned int type) return 0; } -static struct irq_chip mediatek_gpio_irq_chip = { - .irq_unmask = mediatek_gpio_irq_unmask, - .irq_mask = mediatek_gpio_irq_mask, - .irq_mask_ack = mediatek_gpio_irq_mask, - .irq_set_type = mediatek_gpio_irq_type, -}; - static int mediatek_gpio_xlate(struct gpio_chip *chip, const struct of_phandle_args *spec, u32 *flags) @@ -254,6 +248,13 @@ mediatek_gpio_bank_probe(struct device *dev, return ret; } + rg->irq_chip.name = dev_name(dev); + rg->irq_chip.parent_device = dev; + rg->irq_chip.irq_unmask = mediatek_gpio_irq_unmask; + rg->irq_chip.irq_mask = mediatek_gpio_irq_mask; + rg->irq_chip.irq_mask_ack = mediatek_gpio_irq_mask; + rg->irq_chip.irq_set_type = mediatek_gpio_irq_type; + if (mtk->gpio_irq) { /* * Manually request the irq here instead of passing @@ -270,14 +271,14 @@ mediatek_gpio_bank_probe(struct device *dev, return ret; } - ret = gpiochip_irqchip_add(&rg->chip, &mediatek_gpio_irq_chip, + ret = gpiochip_irqchip_add(&rg->chip, &rg->irq_chip, 0, handle_simple_irq, IRQ_TYPE_NONE); if (ret) { dev_err(dev, "failed to add gpiochip_irqchip\n"); return ret; } - gpiochip_set_chained_irqchip(&rg->chip, &mediatek_gpio_irq_chip, + gpiochip_set_chained_irqchip(&rg->chip, &rg->irq_chip, mtk->gpio_irq, NULL); } @@ -310,7 +311,6 @@ mediatek_gpio_probe(struct platform_device *pdev) mtk->gpio_irq = irq_of_parse_and_map(np, 0); mtk->dev = dev; platform_set_drvdata(pdev, mtk); - mediatek_gpio_irq_chip.name = dev_name(dev); for (i = 0; i < MTK_BANK_CNT; i++) { ret = mediatek_gpio_bank_probe(dev, np, i); -- 2.19.1