From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH-for-5.1] nvme: Use discard for quirked write zeroes devices
Date: Wed, 30 Jan 2019 18:44:37 +0100 [thread overview]
Message-ID: <20190130174436.GA7069@lst.de> (raw)
In-Reply-To: <20190130173822.19457-1-keith.busch@intel.com>
On Wed, Jan 30, 2019@10:38:22AM -0700, Keith Busch wrote:
> The current devices that set NVME_QUIRK_DEALLOCATE_ZEROES don't support
> the Write Zeroes NVMe command, but the driver still sets the queue limit
> that enables REQ_OP_WRITE_ZEROES. Continue using Data Set Management for
> such quirked controllers instead of the preferred Write Zeroes command.
>
> Cc: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
This looks sensible to me. We should probably fold this into
the original patch to avoid bisection issues.
next prev parent reply other threads:[~2019-01-30 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 17:38 [PATCH-for-5.1] nvme: Use discard for quirked write zeroes devices Keith Busch
2019-01-30 17:44 ` Christoph Hellwig [this message]
2019-01-31 20:44 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130174436.GA7069@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.