From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B86C282D7 for ; Wed, 30 Jan 2019 18:21:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC4972087F for ; Wed, 30 Jan 2019 18:21:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pp7Tw58G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC4972087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O0HGfbeiSVjDiUX/jALdIHqzJ6Rn2htD9eD4iHgAjjE=; b=pp7Tw58GheUWst GbgNca7FlJSyv4oTirX6BeO3bYMbPupKSqNeY6u/jAHGz9HvJC5NZMSUAbvUp3xi66C7J1/FZZAQY gvK/7y0g6k7Xx1FjyEw7M2Sx3XG6EKmhv3tTQ81DXWAjXXXlPfF47R40LBvnY7MGwMgD+FJCb+bAy RGGHUt2JIRVMpyrDhhm0nlutrpLuUAYVNB/hjyLSaEeCXjBNmUQCDHvc90a3TixW4WIEmKMNUaXcs OTl8l54DuoCo3NKNmIRDSaRIMGgIqrR5iRx2uRJ+DGGVQeoHKwBQVFCGtyNJ7FWjQzDCezGl2OzGk 962o/dpjsoVa+O1rNuSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gouU2-0000tM-FR; Wed, 30 Jan 2019 18:21:10 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gouTz-0000su-3q for linux-arm-kernel@lists.infradead.org; Wed, 30 Jan 2019 18:21:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D634580D; Wed, 30 Jan 2019 10:21:06 -0800 (PST) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5CCF63F557; Wed, 30 Jan 2019 10:21:05 -0800 (PST) Date: Wed, 30 Jan 2019 18:21:02 +0000 From: Will Deacon To: Greg Kroah-Hartman Subject: Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions Message-ID: <20190130182102.GK18558@fuggles.cambridge.arm.com> References: <20190122144114.9816-1-gregkh@linuxfoundation.org> <20190122144114.9816-2-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190122144114.9816-2-gregkh@linuxfoundation.org> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190130_102107_162469_E3D611E7 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , Marc Zyngier , Catalin Marinas , Russell King , Peng Donglin , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Greg, On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Peng Donglin > Cc: > Signed-off-by: Greg Kroah-Hartman > --- > arch/arm64/include/asm/ptdump.h | 9 +++------ > arch/arm64/mm/dump.c | 4 ++-- > arch/arm64/mm/ptdump_debugfs.c | 7 ++----- > 3 files changed, 7 insertions(+), 13 deletions(-) Are you taking this via your tree, or would you like us to queue it in arm64? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52736C282D7 for ; Wed, 30 Jan 2019 18:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2777F2087F for ; Wed, 30 Jan 2019 18:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732992AbfA3SVH (ORCPT ); Wed, 30 Jan 2019 13:21:07 -0500 Received: from foss.arm.com ([217.140.101.70]:59612 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732949AbfA3SVH (ORCPT ); Wed, 30 Jan 2019 13:21:07 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D634580D; Wed, 30 Jan 2019 10:21:06 -0800 (PST) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5CCF63F557; Wed, 30 Jan 2019 10:21:05 -0800 (PST) Date: Wed, 30 Jan 2019 18:21:02 +0000 From: Will Deacon To: Greg Kroah-Hartman Cc: Catalin Marinas , Kevin Hilman , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Peng Donglin Subject: Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions Message-ID: <20190130182102.GK18558@fuggles.cambridge.arm.com> References: <20190122144114.9816-1-gregkh@linuxfoundation.org> <20190122144114.9816-2-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190122144114.9816-2-gregkh@linuxfoundation.org> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Peng Donglin > Cc: > Signed-off-by: Greg Kroah-Hartman > --- > arch/arm64/include/asm/ptdump.h | 9 +++------ > arch/arm64/mm/dump.c | 4 ++-- > arch/arm64/mm/ptdump_debugfs.c | 7 ++----- > 3 files changed, 7 insertions(+), 13 deletions(-) Are you taking this via your tree, or would you like us to queue it in arm64? Will