From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Fix skl srckey mask bits Date: Wed, 30 Jan 2019 21:20:20 +0200 Message-ID: <20190130192020.GP20097@intel.com> References: <20190125183846.28755-1-ville.syrjala@linux.intel.com> <20190125215447.GZ4563@mdroper-desk.amr.corp.intel.com> <20190129143315.GZ20097@intel.com> <20190129144919.GA20097@intel.com> <20190130182522.GM8802@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC7096EBAA for ; Wed, 30 Jan 2019 19:20:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190130182522.GM8802@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMzAsIDIwMTkgYXQgMTA6MjU6MjJBTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBUdWUsIEphbiAyOSwgMjAxOSBhdCAwNDo0OToxOVBNICswMjAwLCBWaWxsZSBTeXJq w6Rsw6Qgd3JvdGU6Cj4gPiBPbiBUdWUsIEphbiAyOSwgMjAxOSBhdCAwNDozMzoxNVBNICswMjAw LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIEZyaSwgSmFuIDI1LCAyMDE5IGF0IDAx OjU0OjQ3UE0gLTA4MDAsIE1hdHQgUm9wZXIgd3JvdGU6Cj4gPiA+ID4gT24gRnJpLCBKYW4gMjUs IDIwMTkgYXQgMDg6Mzg6NDZQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3cm90ZToKPiA+ID4gPiA+ IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g PiA+ID4gPiAKPiA+ID4gPiA+IFdlJ3JlIGluY29ycmVjdGx5IG1hc2tpbmcgb2ZmIHRoZSBSL1Yg Y2hhbm5lbCBlbmFibGUgYml0IGZyb20KPiA+ID4gPiA+IEtFWU1TSy4gRml4IGl0IHVwLgo+ID4g PiA+ID4gCj4gPiA+ID4gPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4KPiA+ID4gPiA+IENjOiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9w ZXJAaW50ZWwuY29tPgo+ID4gPiA+ID4gRml4ZXM6IGIyMDgxNTI1NTY5MyAoImRybS9pOTE1OiBB ZGQgcGxhbmUgYWxwaGEgYmxlbmRpbmcgc3VwcG9ydCwgdjIuIikKPiA+ID4gPiA+IFNpZ25lZC1v ZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g PiA+ID4gCj4gPiA+ID4gVGhlICJzcmNrZXkiIHRlcm1pbm9sb2d5IGluIHRoZSBoZWFkbGluZSBp cyBhIGJpdCBjb25mdXNpbmcgc2luY2UgdGhlCj4gPiA+ID4gY2hhbm5lbCBtYXNrIGFwcGxpZXMg dG8gYm90aCAiZGVzdGluYXRpb24gY29sb3JrZXkiIGFuZCAic291cmNlCj4gPiA+ID4gY29sb3Jr ZXkiIGJlaGF2aW9yLgo+ID4gPiAKPiA+ID4gRG9lcyBpdD8gSUlSQyBpdCB1c2VkIHRvIGJlIG9u bHkgZm9yIHNvdXJjZSBrZXlpbmcuIEkgZ3Vlc3MgSSdsbCBoYXZlIHRvCj4gPiA+IHRyeSBpdCBm b3IgcmVhbHMuCj4gPiAKPiA+IFN0aWxsIHNlZW1zIHRvIGFmZmVjdCBvbmx5IHRoZSBzb3VyY2Ug a2V5Lgo+IAo+IEhtbSwgc3RyYW5nZS4gIEkgZG9uJ3Qgc2VlIGFueSBtZW50aW9uIG9mIHRoaXMg b25seSBhcHBseWluZyB0byBzb3VyY2UKPiBjb2xvciBrZXkgaW4gdGhlIGJzcGVjIChuZWl0aGVy IFBMQU5FX0tFWVZBTCBvciBQTEFORV9LRVlNU0sKPiBkZXNjcmlwdGlvbnMgbWVudGlvbiBpdCku ICBJIGFsc28gbm90aWNlIHRoYXQgU05BIGV4cGxpY2l0bHkgc2V0cyB0aGUKPiBjaGFubmVsIG1h c2sgKGluY2x1ZGluZyB0aGUgMHg3IDw8IDI0IGJpdHMpLCBldmVuIHRob3VnaCBpdCBvbmx5IHVz ZXMKPiBkZXN0aW5hdGlvbiBjb2xvciBrZXlpbmcuCj4gCj4gSXMgdGhpcyBkb2N1bWVudGVkIHNv bWV3aGVyZSB0aGF0IHdlJ3JlIG92ZXJsb29raW5nLCBvciBzaG91bGQgd2UgZmlsZSBhCj4gYnNw ZWMgZGVmZWN0IHRvIGdldCBpdCBhZGRlZD8KCkl0IHVzZWQgdG8gYmUgZG9jdW1lbnRlZC4gRWcu IGc0eCBkb2NzIHNheToKCiIyNiBWL1IgQ2hhbm5lbCBTb3VyY2UgS2V5IEVuYWJsZTogU3BlY2lm aWVzIHRoZSBzb3VyY2UgY29sb3Iga2V5IGVuYWJsZSBmb3IgdGhlIFYvUmVkIGNoYW5uZWwuCiAy NSBZL0cgQ2hhbm5lbCBTb3VyY2UgS2V5IEVuYWJsZTogU3BlY2lmaWVzIHRoZSBzb3VyY2UgY29s b3Iga2V5IGVuYWJsZSBmb3IgdGhlIFkvR3JlZW4gY2hhbm5lbC4KIDI0IFUvQiBDaGFubmVsIFNv dXJjZSBLZXkgRW5hYmxlOiBTcGVjaWZpZXMgdGhlIHNvdXJjZSBjb2xvciBrZXkgZW5hYmxlIGZv ciB0aGUgVS9CbHVlIGNoYW5uZWwKIDIzOjE2IFIgbWFzayBEZXN0IEtleSBWYWx1ZTogU3BlY2lm aWVzIHRoZSBkZXN0aW5hdGlvbiBjb2xvciBrZXkgbWFzayBmb3IgdGhlIHNwcml0ZSBSIGNoYW5u ZWwuCiAxNTo4IEcgbWFzayBEZXN0IEtleSBWYWx1ZTogU3BlY2lmaWVzIHRoZSBkZXN0aW5hdGlv biBjb2xvciBrZXkgbWFzayBmb3IgdGhlIHNwcml0ZSBHIGNoYW5uZWwuCiA3OjAgQiBtYXNrIERl c3QgS2V5IFZhbHVlOiBTcGVjaWZpZXMgdGhlIGRlc3RpbmF0aW9uIGNvbG9yIGtleSBtYXNrIGZv ciB0aGUgc3ByaXRlIEIgY2hhbm5lbC4iCgpDdXJpb3VzbHkgaXQgYWxzbyBzYXlzOgoiTm90ZSB0 aGF0IHNvdXJjZSBrZXkgYW5kIGRlc3RpbmF0aW9uIGtleSBhcmUgbXV0dWFsbHkgZXhjbHVzaXZl IG1vZGVzIG9mCiBvcGVyYXRpb24sIHRoZXkgY2FuIG5vdCBiZSB1c2VkIHNpbXVsdGFuZW91c2x5 LiBGb3IgdGhlIGZ1bmN0aW9uIHRoYXQgaXMKIG5vdCBlbmFibGVkLCB0aGUgYXNzb2NpYXRlZCBi aXRzIGluIHRoaXMgcmVnaXN0ZXIgc2hvdWxkIGJlIHByb2dyYW1tZWQgdG8KIHplcm9lcy4iCndo aWNoIHdlIGFyZSBjbGVhcmx5IG5vdCBmb2xsb3dpbmcuIEJ1dCBJIGRvbid0IGtub3cgb2YgYW55 IGlzc3VlIHRoYXQKaGFzIGNhdXNlZC4KClByaW9yIHRvIGc0eCBrZXlpbmcgd2FzIHdheSBtb3Jl IGNvbmZ1c2luZyBhcyB0aGVyZSB3ZXJlIGEgbG90IG1vcmUgd2F5cwp0aGUgcGxhbmVzIGNvdWxk IGludGVyYWN0LiBJIHRoaW5rIHNrbCBzb3J0IG9mIHdlbnQgYmFjayB0byB0aGUgcHJlLWc0eApz dHlsZSBieSBtb3ZpbmcgdGhlIGRlc3RpbmF0aW9uIGtleWluZyBmcm9tIHRoZSAic3ByaXRlIiB0 byB0aGUKInByaW1hcnkiIGFuZCBzbyBpdCdzIG1vcmUgbGlrZSB0aGUgInNyYyBrZXkgd2luZG93 IiBtb2RlIG9mIG9sZC4KQ3VyaW91c2x5IHNrbCBhbHNvIGhhcyB0aGF0IG1vZGUsIG5vdCBxdWl0 ZSBzdXJlIHdoYXQgdGhlIGRpZmZlcmVuY2UgaXMKYmV0d2VlbiB0aGUgdHdvIHRiaC4gQWxzbyB2 bHYvY2h2IGFyZSB0b3RhbGx5IGluIHRoZSBwcmUtZzR4IGNhbXAsIGFuZAp0aHVzIGltcGxlbWVu dGluZyBkZXN0aW5hdGlvbiBrZXlpbmcgb24gdGhvc2UgaXMgYSBiaXQgbW9yZSBjb21wbGljYXRl ZAooaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3JnL3Nlcmllcy80MzkwMi8pLgoKPiAK PiAKPiBNYXR0Cj4gCj4gPiAKPiA+ID4gCj4gPiA+ID4gT3RoZXJ3aXNlLAo+ID4gPiA+IAo+ID4g PiA+IFJldmlld2VkLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+ ID4gPiA+IAo+ID4gPiA+IE91dCBvZiBjdXJpb3VzaXR5LCBoYXMgdGhlcmUgZXZlciBiZWVuIGEg dXNlcnNwYWNlIGNvbnN1bWVyIG9mIHNvdXJjZQo+ID4gPiA+IGNvbG9ya2V5PyAgSSBrbm93IFNO QSB1c2VzIGRlc3RpbmF0aW9uIGNvbG9ya2V5IChmb3IgWHYpLCBidXQgbm90IHNvdXJjZQo+ID4g PiA+IGNvbG9ya2V5LiAgQW5kIGFmYWlrLCBVWEEgbmV2ZXIgZGlkIGFueSBjb2xvcmtleWluZyB0 aHJvdWdoIHRoZSBzcHJpdGUKPiA+ID4gPiBpbnRlcmZhY2UgYXQgYWxsLgo+ID4gPiAKPiA+ID4g Tm8sIEkgZG9uJ3QgdGhpbmsgd2UgaGF2ZSBhbnkgdXNlcnNwYWNlIGZvciB0aGlzLgo+ID4gPiAK PiA+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiBNYXR0Cj4gPiA+ID4gCj4gPiA+ID4gPiAtLS0KPiA+ ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDIgKy0KPiA+ID4g PiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+ID4g PiA+IAo+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nw cml0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+ID4gPiA+IGlu ZGV4IGIwMmQzZDk4MDllMy4uY2Q0MmU4MWY4YTkwIDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiA+ID4gPiBAQCAtNDkzLDcgKzQ5Myw3IEBA IHNrbF9wcm9ncmFtX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gPiA+ID4gPiAg Cj4gPiA+ID4gPiAgCWtleW1heCA9IChrZXktPm1heF92YWx1ZSAmIDB4ZmZmZmZmKSB8IFBMQU5F X0tFWU1BWF9BTFBIQShhbHBoYSk7Cj4gPiA+ID4gPiAgCj4gPiA+ID4gPiAtCWtleW1zayA9IGtl eS0+Y2hhbm5lbF9tYXNrICYgMHgzZmZmZmZmOwo+ID4gPiA+ID4gKwlrZXltc2sgPSBrZXktPmNo YW5uZWxfbWFzayAmIDB4N2ZmZmZmZjsKPiA+ID4gPiA+ICAJaWYgKGFscGhhIDwgMHhmZikKPiA+ ID4gPiA+ICAJCWtleW1zayB8PSBQTEFORV9LRVlNU0tfQUxQSEFfRU5BQkxFOwo+ID4gPiA+ID4g IAo+ID4gPiA+ID4gLS0gCj4gPiA+ID4gPiAyLjE5LjIKPiA+ID4gPiA+IAo+ID4gPiA+IAo+ID4g PiA+IC0tIAo+ID4gPiA+IE1hdHQgUm9wZXIKPiA+ID4gPiBHcmFwaGljcyBTb2Z0d2FyZSBFbmdp bmVlcgo+ID4gPiA+IElvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudAo+ID4gPiA+ IEludGVsIENvcnBvcmF0aW9uCj4gPiA+ID4gKDkxNikgMzU2LTI3OTUKPiA+ID4gCj4gPiA+IC0t IAo+ID4gPiBWaWxsZSBTeXJqw6Rsw6QKPiA+ID4gSW50ZWwKPiA+IAo+ID4gLS0gCj4gPiBWaWxs ZSBTeXJqw6Rsw6QKPiA+IEludGVsCj4gCj4gLS0gCj4gTWF0dCBSb3Blcgo+IEdyYXBoaWNzIFNv ZnR3YXJlIEVuZ2luZWVyCj4gSW9URyBQbGF0Zm9ybSBFbmFibGluZyAmIERldmVsb3BtZW50Cj4g SW50ZWwgQ29ycG9yYXRpb24KPiAoOTE2KSAzNTYtMjc5NQoKLS0gClZpbGxlIFN5cmrDpGzDpApJ bnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK