From: Peter Zijlstra <peterz@infradead.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
davem@davemloft.net, daniel@iogearbox.net, edumazet@google.com,
jannh@google.com, netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH bpf-next 1/4] bpf: fix lockdep false positive in percpu_freelist
Date: Wed, 30 Jan 2019 20:53:13 +0100 [thread overview]
Message-ID: <20190130195313.GC3085@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190130192752.rvpi2ul26543oax7@ast-mbp.dhcp.thefacebook.com>
On Wed, Jan 30, 2019 at 11:27:54AM -0800, Alexei Starovoitov wrote:
> On Wed, Jan 30, 2019 at 11:21:26AM +0100, Peter Zijlstra wrote:
> > On Tue, Jan 29, 2019 at 08:04:55PM -0800, Alexei Starovoitov wrote:
> > >
> > > It has been explained that is a false positive here:
> > > https://lkml.org/lkml/2018/7/25/756
> >
> > Please, no external references like that. The best option is to fully
>
> I strongly disagree.
> We allowed all kinds of external links in bpf tree in the past and
> going to continue doing so in the future.
> I'm perfectly aware that some of them will go stale in a day or
> in a year.
What's the point of adding URLs if you know they'll not be useful later?
Anyway, your tree, so you get to make the rules, but personally I've
cursed about this exact issue a fair few times.
See for example the x86 tree policy of creating BZ entries to store
Intel documents to refer to them from commits because the Intel website
is notoriously flaky wrt persistence.
There's nothing worse than references to a document you can no longer
find while trying to make sense of this 3 year old code that suddenly
comes apart.
next prev parent reply other threads:[~2019-01-30 19:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 4:04 [PATCH bpf-next 0/4] bpf: fixes for lockdep and deadlock Alexei Starovoitov
2019-01-30 4:04 ` [PATCH bpf-next 1/4] bpf: fix lockdep false positive in percpu_freelist Alexei Starovoitov
2019-01-30 10:21 ` Peter Zijlstra
2019-01-30 19:27 ` Alexei Starovoitov
2019-01-30 19:53 ` Peter Zijlstra [this message]
2019-01-30 20:18 ` Alexei Starovoitov
2019-01-30 4:04 ` [PATCH bpf-next 2/4] bpf: fix lockdep false positive in stackmap Alexei Starovoitov
2019-01-30 10:15 ` Peter Zijlstra
2019-01-30 19:30 ` Alexei Starovoitov
2019-01-30 19:42 ` Waiman Long
2019-01-30 20:10 ` Alexei Starovoitov
2019-01-30 21:11 ` Waiman Long
2019-01-30 21:32 ` Waiman Long
2019-01-31 2:01 ` Alexei Starovoitov
2019-01-31 2:48 ` Waiman Long
2019-02-06 3:21 ` Eric Dumazet
2019-02-06 3:30 ` Alexei Starovoitov
2019-02-06 3:40 ` Eric Dumazet
2019-01-30 19:44 ` Peter Zijlstra
2019-01-30 20:05 ` Waiman Long
2019-01-30 4:04 ` [PATCH bpf-next 3/4] bpf: fix lockdep false positive in bpf_prog_register Alexei Starovoitov
2019-01-30 10:10 ` Peter Zijlstra
2019-01-30 10:37 ` Peter Zijlstra
2019-01-30 19:32 ` Alexei Starovoitov
2019-01-30 19:46 ` Peter Zijlstra
2019-01-30 4:04 ` [PATCH bpf-next 4/4] bpf: Fix syscall's stackmap lookup potential deadlock Alexei Starovoitov
2019-01-30 4:07 ` [PATCH bpf-next 0/4] bpf: fixes for lockdep and deadlock Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130195313.GC3085@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jannh@google.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.