From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Wed, 30 Jan 2019 23:00:35 +0300 Subject: patch "staging: erofs: keep corrupted fs from crashing kernel in" added to staging-linus In-Reply-To: <1e5bad91-3d65-c086-d42c-f87d642e3204@huawei.com> References: <15488587831390@kroah.com> <74cc60e3-eb87-d574-a106-305fb40ca54d@huawei.com> <1e5bad91-3d65-c086-d42c-f87d642e3204@huawei.com> Message-ID: <20190130200035.GC2010@kadam> On Wed, Jan 30, 2019@11:42:41PM +0800, Gao Xiang wrote: > > > On 2019/1/30 23:05, Gao Xiang wrote: > > > > Hi Greg, > > > > Dan raised some suggestions to me. And I want to get some review ideas from Chao... > > Current EROFS works good for the normal image, this patch is used for corrupted image only... > > > > Could you kindly drop this patch temporarily and I want to get them reviewed... > > Not soon... Thanks! > > It seems this patch is the top of staging-linus...Could you kindly drop it and > it is better to get "Reviewed-by:" tag for all EROFS bugfix patches from corresponding > people (Chao, Dan, or Al if possible) first... Thank you very much! > > sorry to trouble you... > Greg has already reverted this but for future reference there wasn't any need to panic or rush. It was just the kunmap_atomic() which only affects corrupted filesystem on linux-next so it's not a big deal. The rest was just my style grumblings and could have been addressed later or even ignored. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 128EEC282D7 for ; Wed, 30 Jan 2019 20:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D107A218A4 for ; Wed, 30 Jan 2019 20:01:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Seb9CHk5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728715AbfA3UBb (ORCPT ); Wed, 30 Jan 2019 15:01:31 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:43414 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728446AbfA3UBb (ORCPT ); Wed, 30 Jan 2019 15:01:31 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0UJx2vQ185722; Wed, 30 Jan 2019 20:01:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=yeN6sB4NGI7IWV1/sjXJNBb1PYXVQ9Nn2N0zzQwmXRI=; b=Seb9CHk5mzUe1iKZwFb1DwZx40rLcu2zMe1FangHAQL410/GvdLaW212Uyq7nowq0UBM Ij7nZ4E6KFI1eRae15+URnhISKsHe+iqwhxHFjQBJP6KCg0O0GOBEHnmbu8XVUQF6D96 KeLRpyoHJkvKgO3tuk/rnJOVkdAerjp+UfgJ2juAF6gbXr8MFIgT4X8hKUewtzwTUfPy kwtYuq7RVa880Fheftqt4LnJr6mWvf1eZihvkouj8ox3g5yFmSpBjYRV6o09SvL1gw5N YfVm+xoqpqGqZI5oyqrGHtF6YgRZGOptE6lHOpV7IeA7dBMDI1MbI4KfEafQueGIsTjQ zQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2q8eyumrc3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Jan 2019 20:01:21 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x0UK1KIa021992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Jan 2019 20:01:21 GMT Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x0UK1DtV021594; Wed, 30 Jan 2019 20:01:13 GMT Received: from kadam (/197.157.0.43) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 Jan 2019 12:01:13 -0800 Date: Wed, 30 Jan 2019 23:00:35 +0300 From: Dan Carpenter To: Gao Xiang Cc: gregkh@linuxfoundation.org, linux-staging mailing list , linux-erofs@lists.ozlabs.org, viro@ZenIV.linux.org.uk, stable@vger.kernel.org Subject: Re: patch "staging: erofs: keep corrupted fs from crashing kernel in" added to staging-linus Message-ID: <20190130200035.GC2010@kadam> References: <15488587831390@kroah.com> <74cc60e3-eb87-d574-a106-305fb40ca54d@huawei.com> <1e5bad91-3d65-c086-d42c-f87d642e3204@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1e5bad91-3d65-c086-d42c-f87d642e3204@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9152 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901300149 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 30, 2019 at 11:42:41PM +0800, Gao Xiang wrote: > > > On 2019/1/30 23:05, Gao Xiang wrote: > > > > Hi Greg, > > > > Dan raised some suggestions to me. And I want to get some review ideas from Chao... > > Current EROFS works good for the normal image, this patch is used for corrupted image only... > > > > Could you kindly drop this patch temporarily and I want to get them reviewed... > > Not soon... Thanks! > > It seems this patch is the top of staging-linus...Could you kindly drop it and > it is better to get "Reviewed-by:" tag for all EROFS bugfix patches from corresponding > people (Chao, Dan, or Al if possible) first... Thank you very much! > > sorry to trouble you... > Greg has already reverted this but for future reference there wasn't any need to panic or rush. It was just the kunmap_atomic() which only affects corrupted filesystem on linux-next so it's not a big deal. The rest was just my style grumblings and could have been addressed later or even ignored. regards, dan carpenter