From: "John W. Linville" <linville@tuxdriver.com>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: "Maciej Żenczykowski" <maze@google.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "ethtool: change to new sane powerpc64 kernel headers"
Date: Wed, 30 Jan 2019 15:41:17 -0500 [thread overview]
Message-ID: <20190130204117.GC19981@tuxdriver.com> (raw)
In-Reply-To: <20190130024849.24997-1-zenczykowski@gmail.com>
Cool, thanks -- queued for next release.
John
On Tue, Jan 29, 2019 at 06:48:49PM -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> This reverts commit 4df55c81996dfb1dbe98c93ee62d8067ed5073a9.
>
> It turns out this is not needed due to:
> commit c0a2c04b3cbf6d399a2551654401957ddb529a50
> internal.h: change to new sane kernel headers on 64-bit archs
> which I apparently entirely forgot about while trying
> to synchronize internal and upstream git repositories.
>
> Change-Id: I56d90a3c1e9b66c30526824fb7bc41aab01d85d1
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> ethtool-copy.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/ethtool-copy.h b/ethtool-copy.h
> index 7772a4970987..6bfbb85f9402 100644
> --- a/ethtool-copy.h
> +++ b/ethtool-copy.h
> @@ -14,12 +14,6 @@
> #ifndef _LINUX_ETHTOOL_H
> #define _LINUX_ETHTOOL_H
>
> -#ifdef __powerpc64__
> -/* Powerpc needs __SANE_USERSPACE_TYPES__ before <linux/types.h> to select
> - * 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu.
> - */
> -#define __SANE_USERSPACE_TYPES__
> -#endif
> #include <linux/kernel.h>
> #include <linux/types.h>
> #include <linux/if_ether.h>
> --
> 2.20.1.495.gaa96b0ce6b-goog
>
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2019-01-30 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 20:28 ethtool - manual changes in ethtool-copy.h Michal Kubecek
2019-01-29 20:47 ` John W. Linville
2019-01-30 1:57 ` Maciej Żenczykowski
2019-01-30 2:42 ` Maciej Żenczykowski
2019-01-30 2:48 ` [PATCH] Revert "ethtool: change to new sane powerpc64 kernel headers" Maciej Żenczykowski
2019-01-30 20:41 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130204117.GC19981@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.