From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Ramon Fried <ramon.fried@gmail.com>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom_q6v5: don't auto boot remote processor
Date: Wed, 30 Jan 2019 13:07:04 -0800 [thread overview]
Message-ID: <20190130210704.GW31919@minitux> (raw)
In-Reply-To: <20180524192141.20323-1-ramon.fried@gmail.com>
On Thu 24 May 12:21 PDT 2018, Ramon Fried wrote:
> Sometimes that rmtfs userspace module is not brought
> up fast enough and the modem crashes.
> disabling automated boot in the driver and triggering
> the boot from user-space sovles the problem.
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
While I don't think we have fully settled on the mechanism yet, it's
clear that we don't want this to auto boot using the existing mechanism.
So I picked this patch, with Sibi's ack.
Thanks,
Bjorn
> ---
> drivers/remoteproc/qcom_q6v5_pil.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c
> index cbbafdcaaecb..719ee96445b3 100644
> --- a/drivers/remoteproc/qcom_q6v5_pil.c
> +++ b/drivers/remoteproc/qcom_q6v5_pil.c
> @@ -1133,6 +1133,8 @@ static int q6v5_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> + rproc->auto_boot = false;
> +
> qproc = (struct q6v5 *)rproc->priv;
> qproc->dev = &pdev->dev;
> qproc->rproc = rproc;
> --
> 2.17.0
>
prev parent reply other threads:[~2019-01-30 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 19:21 [PATCH] remoteproc: qcom_q6v5: don't auto boot remote processor Ramon Fried
2018-05-29 4:20 ` Bjorn Andersson
2018-05-29 11:31 ` Ramon Fried
2019-01-18 7:04 ` Sibi Sankar
2019-01-18 7:04 ` Sibi Sankar
2019-01-18 18:35 ` Brian Norris
2019-01-18 19:46 ` Sibi Sankar
2019-01-18 21:04 ` Brian Norris
2019-01-19 4:17 ` Sibi Sankar
2019-01-30 21:07 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130210704.GW31919@minitux \
--to=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ramon.fried@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.