From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CDBFC282D7 for ; Wed, 30 Jan 2019 23:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3143120881 for ; Wed, 30 Jan 2019 23:20:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="nFo0LMs4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729304AbfA3XU2 (ORCPT ); Wed, 30 Jan 2019 18:20:28 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:33355 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725613AbfA3XU2 (ORCPT ); Wed, 30 Jan 2019 18:20:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=F3428vGLliHHdGHX7pwDiEtCp2QPLsOH7TiaMWIFNfA=; b=nFo0LMs4eg7uajhSqFnCiDE39S BV0uhWxDDQESlZiSdzzN5fdphfOOaXD076twSvStNaapPnmTPmNfpB1FWKyT3diePQl0j1Lj3LEKA RcMcllGKGXyHW1/CLgFji2BmBFCeIcXvNfckRuM5JEpknHhmGfagOAzeE25kIF1ZffgM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1goycw-000088-JA; Wed, 30 Jan 2019 23:46:38 +0100 Date: Wed, 30 Jan 2019 23:46:38 +0100 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, vivien.didelot@gmail.com, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: Re: [PATCH net-next v2 10/12] net: dsa: Wire up multicast IGMP snooping attribute notification Message-ID: <20190130224638.GC30115@lunn.ch> References: <20190130005548.2212-1-f.fainelli@gmail.com> <20190130005548.2212-11-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130005548.2212-11-f.fainelli@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > @@ -425,6 +425,8 @@ struct dsa_switch_ops { > /* > * Multicast database > */ > + int (*port_multicast_toggle)(struct dsa_switch *ds, int port, > + bool mc_disabled); > int (*port_mdb_prepare)(struct dsa_switch *ds, int port, > const struct switchdev_obj_port_mdb *mdb); > void (*port_mdb_add)(struct dsa_switch *ds, int port, Hi Florian I took a second look at this, after you asked the question. What i see above is that port_multicast_toggle is different to port_mdb_prepare and port_mdb_add. From this context, it looks like there should not be a tab between int and (*port_multicast_toggle). However, when you look at the real file, it becomes clear that it is actually normal to have a tab between the type and the name of the function pointer, and that port_mdb_prepare and port_mdb_add are different to the rest. So you patch is O.K. Andrew