From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com,
crosthwaite.peter@gmail.com, boost.lists@gmail.com,
artem.k.pisarenko@gmail.com, quintela@redhat.com,
ciro.santilli@gmail.com, jasowang@redhat.com, mst@redhat.com,
armbru@redhat.com, mreitz@redhat.com,
maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru,
kraxel@redhat.com, pavel.dovgaluk@ispras.ru,
thomas.dullien@googlemail.com, pbonzini@redhat.com,
alex.bennee@linaro.org, dgilbert@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v11 23/25] replay: fix replay shutdown
Date: Thu, 31 Jan 2019 16:17:32 +0300 [thread overview]
Message-ID: <20190131131732.23264.62834.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20190131131520.23264.75724.stgit@pasha-VirtualBox>
This patch fixes shutdown of the replay process, which is terminated with
the assert when shutdown event is read from the log.
replay_finish_event reads new data_kind and therefore the value of data_kind
should be preserved to be valid at qemu_system_shutdown_request call.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
---
replay/replay.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/replay/replay.c b/replay/replay.c
index e578958..8f2e17c 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -49,14 +49,14 @@ bool replay_next_event_is(int event)
}
while (true) {
- if (event == replay_state.data_kind) {
+ unsigned int data_kind = replay_state.data_kind;
+ if (event == data_kind) {
res = true;
}
- switch (replay_state.data_kind) {
+ switch (data_kind) {
case EVENT_SHUTDOWN ... EVENT_SHUTDOWN_LAST:
replay_finish_event();
- qemu_system_shutdown_request(replay_state.data_kind -
- EVENT_SHUTDOWN);
+ qemu_system_shutdown_request(data_kind - EVENT_SHUTDOWN);
break;
default:
/* clock, time_t, checkpoint and other events */
next prev parent reply other threads:[~2019-01-31 13:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 13:15 [Qemu-devel] [PATCH v11 00/25] Fixing record/replay and adding reverse debugging Pavel Dovgalyuk
2019-01-31 13:15 ` [Qemu-devel] [PATCH v11 01/25] replay: add missing fix for internal function Pavel Dovgalyuk
2019-01-31 13:15 ` [Qemu-devel] [PATCH v11 02/25] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2019-01-31 13:15 ` [Qemu-devel] [PATCH v11 03/25] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2019-01-31 13:15 ` [Qemu-devel] [PATCH v11 04/25] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2019-01-31 13:15 ` [Qemu-devel] [PATCH v11 05/25] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2019-01-31 13:15 ` [Qemu-devel] [PATCH v11 06/25] replay: finish record/replay before closing the disks Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 07/25] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 08/25] migration: " Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 09/25] replay: provide an accessor for rr filename Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 10/25] qapi: introduce replay.json for record/replay-related stuff Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 11/25] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 12/25] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 13/25] replay: implement replay-seek command Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 14/25] replay: refine replay-time module Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 15/25] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 16/25] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2019-01-31 13:16 ` [Qemu-devel] [PATCH v11 17/25] gdbstub: add reverse continue " Pavel Dovgalyuk
2019-01-31 13:17 ` [Qemu-devel] [PATCH v11 18/25] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2019-01-31 13:17 ` [Qemu-devel] [PATCH v11 19/25] replay: add BH oneshot event for block layer Pavel Dovgalyuk
2019-01-31 13:17 ` [Qemu-devel] [PATCH v11 20/25] replay: init rtc after enabling the replay Pavel Dovgalyuk
2019-01-31 13:17 ` [Qemu-devel] [PATCH v11 21/25] replay: document development rules Pavel Dovgalyuk
2019-01-31 13:17 ` [Qemu-devel] [PATCH v11 22/25] util/qemu-timer: refactor deadline calculation for external timers Pavel Dovgalyuk
2019-01-31 13:17 ` Pavel Dovgalyuk [this message]
2019-01-31 13:17 ` [Qemu-devel] [PATCH v11 24/25] replay: rename step-related variables and functions Pavel Dovgalyuk
2019-01-31 13:17 ` [Qemu-devel] [PATCH v11 25/25] icount: clean up cpu_can_io before jumping to the next block Pavel Dovgalyuk
2019-01-31 17:54 ` [Qemu-devel] [PATCH v11 00/25] Fixing record/replay and adding reverse debugging no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131131732.23264.62834.stgit@pasha-VirtualBox \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=artem.k.pisarenko@gmail.com \
--cc=boost.lists@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=thomas.dullien@googlemail.com \
--cc=war2jordan@live.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.