From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,7/9] usb: typec: Find the ports by also matching against the device node From: Heikki Krogerus Message-Id: <20190131133537.GA13072@kuha.fi.intel.com> Date: Thu, 31 Jan 2019 15:35:37 +0200 To: Andy Shevchenko Cc: Greg Kroah-Hartman , Chen Yu , Jun Li , Hans de Goede , USB , Linux Kernel Mailing List List-ID: T24gV2VkLCBKYW4gMzAsIDIwMTkgYXQgMDY6NTE6NTZQTSArMDIwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IE9uIFdlZCwgSmFuIDMwLCAyMDE5IGF0IDY6MDMgUE0gSGVpa2tpIEtyb2dlcnVz Cj4gPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4KPiA+IFdoZW4g dGhlIGNvbm5lY3Rpb25zIGFyZSBkZWZpbmVkIGluIGZpcm13YXJlLCBzdHJ1Y3QKPiA+IGRldmlj ZV9jb25uZWN0aW9uIHdpbGwgaGF2ZSB0aGUgZndub2RlIG1lbWJlciBwb2ludGluZyB0bwo+ID4g dGhlIGRldmljZSBub2RlIChzdHJ1Y3QgZndub2RlX2hhbmRsZSkgb2YgdGhlIHJlcXVlc3RlZAo+ ID4gZGV2aWNlLCBhbmQgdGhlIGVuZHBvaW50IHdpbGwgbm90IGJlIHVzZWQgYXQgYWxsIGluIHRo YXQKPiA+IGNhc2UuCj4gCj4gPiArICAgICAgIC8qCj4gPiArICAgICAgICAqIEZJWE1FOiBDaGVj ayBkb2VzIHRoZSBmd25vZGUgc3VwcG9ydHMgdGhlIHJlcXVlc3RlZCBTVklELiBJZiBpdCBkb2Vz Cj4gPiArICAgICAgICAqIHdlIG5lZWQgdG8gcmV0dXJuIEVSUl9QVFIoLVBST0JFX0RFRkVSKSB3 aGVuIHRoZXJlIGlzIG5vIGRldmljZS4KPiA+ICsgICAgICAgICovCj4gPiArICAgICAgIGlmIChj b24tPmZ3bm9kZSkKPiA+ICsgICAgICAgICAgICAgICByZXR1cm4gY2xhc3NfZmluZF9kZXZpY2Uo dHlwZWNfY2xhc3MsIE5VTEwsIGNvbi0+Zndub2RlLAo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB0eXBlY19wb3J0X2Z3bm9kZV9tYXRjaCk7Cj4gPiArCj4gPiAr ICAgICAgIGRldiA9IGNsYXNzX2ZpbmRfZGV2aWNlKHR5cGVjX2NsYXNzLCBOVUxMLCBjb24tPmVu ZHBvaW50W2VwXSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHlwZWNfcG9y dF9uYW1lX21hdGNoKTsKPiA+ICsKPiA+ICsgICAgICAgcmV0dXJuIGRldiA/IGRldiA6IEVSUl9Q VFIoLUVQUk9CRV9ERUZFUik7Cj4gCj4gSnVzdCAgdG8gYmUgY2xlYXIsIHRoaXMgb25lIHRha2Vz IGEgcmVmZXJlbmNlIG9uIGRldi4gSXMgaXQgdGFrZW4gaW50byBhY2NvdW50PwoKWWVzLiBUaGF0 IGlzIHdoYXQgd2Ugd2FudCBpdCB0byBkby4KCnRoYW5rcywK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C594C169C4 for ; Thu, 31 Jan 2019 13:35:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 687EB2085B for ; Thu, 31 Jan 2019 13:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387544AbfAaNfo (ORCPT ); Thu, 31 Jan 2019 08:35:44 -0500 Received: from mga09.intel.com ([134.134.136.24]:60977 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726714AbfAaNfn (ORCPT ); Thu, 31 Jan 2019 08:35:43 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 05:35:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,544,1539673200"; d="scan'208";a="143063001" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 31 Jan 2019 05:35:38 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 31 Jan 2019 15:35:37 +0200 Date: Thu, 31 Jan 2019 15:35:37 +0200 From: Heikki Krogerus To: Andy Shevchenko Cc: Greg Kroah-Hartman , Chen Yu , Jun Li , Hans de Goede , USB , Linux Kernel Mailing List Subject: Re: [PATCH v2 7/9] usb: typec: Find the ports by also matching against the device node Message-ID: <20190131133537.GA13072@kuha.fi.intel.com> References: <20190130160259.46919-1-heikki.krogerus@linux.intel.com> <20190130160259.46919-8-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 30, 2019 at 06:51:56PM +0200, Andy Shevchenko wrote: > On Wed, Jan 30, 2019 at 6:03 PM Heikki Krogerus > wrote: > > > > When the connections are defined in firmware, struct > > device_connection will have the fwnode member pointing to > > the device node (struct fwnode_handle) of the requested > > device, and the endpoint will not be used at all in that > > case. > > > + /* > > + * FIXME: Check does the fwnode supports the requested SVID. If it does > > + * we need to return ERR_PTR(-PROBE_DEFER) when there is no device. > > + */ > > + if (con->fwnode) > > + return class_find_device(typec_class, NULL, con->fwnode, > > + typec_port_fwnode_match); > > + > > + dev = class_find_device(typec_class, NULL, con->endpoint[ep], > > + typec_port_name_match); > > + > > + return dev ? dev : ERR_PTR(-EPROBE_DEFER); > > Just to be clear, this one takes a reference on dev. Is it taken into account? Yes. That is what we want it to do. thanks, -- heikki