From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/vhangup: convert to new lib, use direct syscall
Date: Thu, 31 Jan 2019 14:47:01 +0100 [thread overview]
Message-ID: <20190131134701.GC18486@rei.lan> (raw)
In-Reply-To: <20190126015606.236588-1-smuckle@google.com>
Hi!
> + if ((pid = SAFE_FORK()) < 0) {
> + tst_brk(TBROK | TTERRNO, "fork failed");
I've removed this pid < 0 check, since the whole point of SAFE_* macros
is that the call will either succeed or exit the test.
> + } else if (pid > 0) {
> + /* parent */
> + waitpid(pid, NULL, 0);
> + } else {
> + /* child */
And also these useless /* parent */ and /* child */ comments.
And pushed, thanks!
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-01-31 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 1:56 [LTP] [PATCH] syscalls/vhangup: convert to new lib, use direct syscall Steve Muckle
2019-01-31 13:47 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131134701.GC18486@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.