From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 2/2] tpm: don't print error message in tpm_transmit_cmd when tpm still testing
Date: Thu, 31 Jan 2019 18:08:38 +0200 [thread overview]
Message-ID: <20190131160838.GE5629@linux.intel.com> (raw)
In-Reply-To: <20190130224333.20373-2-jsnitsel@redhat.com>
On Wed, Jan 30, 2019 at 03:43:33PM -0700, Jerry Snitselaar wrote:
> Currently tpm_transmit_cmd will print an error message if the tpm
> returns something other than TPM2_RC_SUCCESS. This means that if the
> tpm returns that it is testing an error message will be printed, and
> this can cause confusion for the end user. So avoid printing the error
> message if TPM2_RC_TESTING is the return code.
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
Tags in wrong order but, but don't worry about it. I'll apply this
patch and include to the next PR. Thanks.
/Jarkko
next prev parent reply other threads:[~2019-01-31 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 22:43 [PATCH 1/2] tpm: don't return bool from update_timeouts Jerry Snitselaar
2019-01-30 22:43 ` [PATCH 2/2] tpm: don't print error message in tpm_transmit_cmd when tpm still testing Jerry Snitselaar
2019-01-31 16:08 ` Jarkko Sakkinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-30 22:06 [PATCH 1/2] tpm: don't return bool from update_timeouts Jerry Snitselaar
2019-01-30 22:06 ` [PATCH 2/2] tpm: don't print error message in tpm_transmit_cmd when tpm still testing Jerry Snitselaar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131160838.GE5629@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.