From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Collin Walling <walling@linux.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file
Date: Thu, 31 Jan 2019 18:56:21 +0100 [thread overview]
Message-ID: <20190131185621.28815291.cohuck@redhat.com> (raw)
In-Reply-To: <1548956828-10210-1-git-send-email-thuth@redhat.com>
On Thu, 31 Jan 2019 18:47:08 +0100
Thomas Huth <thuth@redhat.com> wrote:
> The arguments of the stub functions to not match the real implementation
s/to/do/
> (and the prototypes in the header) anymore, so if you try to compile s390x
> without CONFIG_PCI, the build currently fails.
>
Fixes: 468a93898a97 ("s390x/pci: pass the retaddr to all PCI instructions")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/s390x/s390-pci-stub.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
This file seems to be in danger of bitrot. Do you think it'll be easier
to test rarely used configs like that after we switch to Kconfig?
next prev parent reply other threads:[~2019-01-31 17:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 17:47 [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file Thomas Huth
2019-01-31 17:56 ` Cornelia Huck [this message]
2019-01-31 18:00 ` Thomas Huth
2019-01-31 18:08 ` Paolo Bonzini
2019-02-01 6:14 ` Thomas Huth
2019-02-01 6:46 ` Thomas Huth
2019-02-01 8:23 ` Cornelia Huck
2019-02-11 10:48 ` Cornelia Huck
2019-02-11 10:54 ` Thomas Huth
2019-02-11 11:04 ` Cornelia Huck
2019-02-11 11:17 ` Thomas Huth
2019-02-11 11:20 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131185621.28815291.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.