From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Maciej Fijalkowski <maciejromanfijalkowski@gmail.com>,
daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org,
brouer@redhat.com
Subject: Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples
Date: Thu, 31 Jan 2019 21:19:41 +0100 [thread overview]
Message-ID: <20190131211941.2bfba5f2@carbon> (raw)
In-Reply-To: <20190130182653.0f3bb01e@cakuba.hsd1.ca.comcast.net>
On Wed, 30 Jan 2019 18:26:53 -0800
Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> On Wed, 30 Jan 2019 20:08:59 +0100, Jesper Dangaard Brouer wrote:
> > > I'll post a v5 with libbpf_strerror() usage when bpf_set_link_xdp_fd failed in
> > > samples but at this point it will only give us a standard "device or resource
> > > busy" error
> >
> > That is a good first iteration improvement. And if QA complains, I can
> > quickly diagnose and explain the issue, based on this generic message,
> > without digging further and wasting more time.
> >
> > > , so if we need some more meaningful message that libbpf will give
> > > us then I guess we need to define a new libbpf_errno entry (as well as entry in
> > > libbpf_strerror_table for this new errno value) and set the errno in
> > > bpf_set_link_xdp_fd in case of a failure?
> >
> > It likely require more work do provide more meaningful messages, and I
> > guess it is out-of-scope for your patchset.
>
> Perhaps we could put the error message in extack instead?
That is actually a good idea, for providing these more meaningful
messages.
--Jesper
next prev parent reply other threads:[~2019-01-31 20:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 19:16 [PATCH bpf-next v4 0/7] xdp: Avoid unloading xdp prog not attached by sample Maciej Fijalkowski
2019-01-28 19:16 ` [PATCH bpf-next v4 1/7] libbpf: Add a helper for retrieving a map fd for a given name Maciej Fijalkowski
2019-01-28 20:49 ` John Fastabend
2019-01-28 19:16 ` [PATCH bpf-next v4 2/7] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe Maciej Fijalkowski
2019-01-28 20:50 ` John Fastabend
2019-01-28 19:16 ` [PATCH bpf-next v4 3/7] samples/bpf: Convert XDP samples to libbpf usage Maciej Fijalkowski
2019-01-28 19:16 ` [PATCH bpf-next v4 4/7] samples/bpf: Extend RLIMIT_MEMLOCK for xdp_{sample_pkts, router_ipv4} Maciej Fijalkowski
2019-01-28 20:54 ` John Fastabend
2019-01-28 19:16 ` [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples Maciej Fijalkowski
2019-01-28 20:57 ` John Fastabend
2019-01-29 8:00 ` Jesper Dangaard Brouer
2019-01-29 11:34 ` Jesper Dangaard Brouer
2019-01-30 18:12 ` Maciej Fijalkowski
2019-01-30 19:08 ` Jesper Dangaard Brouer
2019-01-31 2:26 ` Jakub Kicinski
2019-01-31 20:19 ` Jesper Dangaard Brouer [this message]
2019-01-28 19:16 ` [PATCH bpf-next v4 6/7] libbpf: Add a support for getting xdp prog id on ifindex Maciej Fijalkowski
2019-01-28 21:07 ` John Fastabend
2019-01-30 17:53 ` Maciej Fijalkowski
2019-01-28 19:16 ` [PATCH bpf-next v4 7/7] samples/bpf: Check the prog id before exiting Maciej Fijalkowski
2019-01-28 21:10 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131211941.2bfba5f2@carbon \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.