All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Roman Gushchin <guro@fb.com>,
	linux-mm@kvack.org
Subject: Re: [linux-next-20190131] NULL pointer dereference at shrink_node_memcg.
Date: Thu, 31 Jan 2019 23:28:36 -0500	[thread overview]
Message-ID: <20190201042836.GA1529@chrisdown.name> (raw)
In-Reply-To: <201902010337.x113b72e028186@www262.sakura.ne.jp>

Hey Tetsuo,

Tetsuo Handa writes:
>Commit 8a907cdf0177ab40 ("mm, memcg: proportional memory.{low,min} reclaim")
>broke global reclaim by kdump kernel due to NULL pointer dereference at
>
>   protection = mem_cgroup_protection(memcg);
>
>. Please fix.

Oh yeah, memcg is null if memcg is disabled at run time but is compiled in (so 
this works with CONFIG_MEMCG and !CONFIG_MEMCG, but not CONFIG_MEMCG + 
cgroup_disable=memory).

A fix will be out shortly, thanks.


      reply	other threads:[~2019-02-01  4:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01  3:37 [linux-next-20190131] NULL pointer dereference at shrink_node_memcg Tetsuo Handa
2019-02-01  4:28 ` Chris Down [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190201042836.GA1529@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.