From: Christoph Hellwig <hch@lst.de>
To: Joerg Roedel <joro@8bytes.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Joerg Roedel <jroedel@suse.de>,
Mike Rapoport <rppt@linux.vnet.ibm.com>
Subject: Re: [PATCH] swiotlb: Return error from swiotlb_init_with_tbl()
Date: Fri, 1 Feb 2019 09:12:08 +0100 [thread overview]
Message-ID: <20190201081208.GB15512@lst.de> (raw)
In-Reply-To: <20190131162424.10477-1-joro@8bytes.org>
On Thu, Jan 31, 2019 at 05:24:24PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> The only reason why swiotlb_init_with_tbl() can fail is an
> allocation failure in the memblock_alloc() function. But
> this function just calls panic() in case it can't fulfill
> the request and never returns an error, therefore
> swiotlb_init_with_tbl() also never actually returns an
> error.
Please use up all 72 characters per line available in the commit log
format.
> - io_tlb_list = memblock_alloc(
> + io_tlb_list = memblock_alloc_nopanic(
> PAGE_ALIGN(io_tlb_nslabs * sizeof(int)),
> PAGE_SIZE);
Mike just killed the _nopanic versions and made the normal ones not
panic.
next prev parent reply other threads:[~2019-02-01 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 16:24 [PATCH] swiotlb: Return error from swiotlb_init_with_tbl() Joerg Roedel
2019-02-01 8:12 ` Christoph Hellwig [this message]
2019-02-01 16:50 ` Joerg Roedel
2019-02-01 16:56 ` Christoph Hellwig
2019-02-01 16:59 ` Joerg Roedel
2019-02-02 17:06 ` Christoph Hellwig
2019-02-02 18:09 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201081208.GB15512@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.