From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup Date: Fri, 1 Feb 2019 10:03:11 +0100 Message-ID: <20190201090311.GA4639@kroah.com> References: <20190201085712.32380-1-sr@denx.de> <20190201085712.32380-2-sr@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, Sankalp Negi , linux-spi@vger.kernel.org, Mark Brown , John Crispin , NeilBrown To: Stefan Roese Return-path: Content-Disposition: inline In-Reply-To: <20190201085712.32380-2-sr@denx.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: linux-spi.vger.kernel.org On Fri, Feb 01, 2019 at 09:57:12AM +0100, Stefan Roese wrote: > This patch cleans up some minor issues with this driver: > - Remove unnecessary header includes > - Sort header alphabetically > - Use correct comment style > - Add return code check on device_reset() > - Remove SPI_BPW_MASK definition (already available in > include/linux/spi/spi.h) > - Use macros instead of hardcoded values for SPI_MASTER register access > as suggested by Neil Brown (in mt7621_spi_reset and mt7621_spi_prepare) When you have to start listing the different things you do in a patch, that's a huge sign you need to break this up into different patches :) Please do that here, it should be a series, each one doing a single type of thing. thanks, greg k-h