From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] dma: debug: no need to check return value of debugfs_create functions Date: Fri, 1 Feb 2019 10:04:02 +0100 Message-ID: <20190201090402.GA16244@lst.de> References: <20190122152151.16139-39-gregkh@linuxfoundation.org> <2b974ef1-4336-8187-cbc5-ba2a14691837@arm.com> <20190122184847.GA32627@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190122184847.GA32627@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: Robin Murphy , linux-kernel@vger.kernel.org, Christoph Hellwig , Marek Szyprowski , iommu@lists.linux-foundation.org, Corentin Labbe List-Id: iommu@lists.linux-foundation.org On Tue, Jan 22, 2019 at 07:48:47PM +0100, Greg Kroah-Hartman wrote: > > Does this actually need to be at file scope, or could it be punted to a > > local in dma_debug_fs_init() while we're here? > > It can be moved to the function scope if you want me to, I was trying to > do the least needed here :) I've folded the scope move in when applying the patch to the dma-mapping for-next tree. Thanks!