From: Johan Hovold <johan@kernel.org>
To: Shuah Khan <shuah@kernel.org>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: Fix WARNING in tty_set_termios()
Date: Fri, 1 Feb 2019 10:36:39 +0100 [thread overview]
Message-ID: <20190201093639.GB3691@localhost> (raw)
In-Reply-To: <20190201092843.GA3691@localhost>
On Fri, Feb 01, 2019 at 10:28:43AM +0100, Johan Hovold wrote:
> On Thu, Jan 31, 2019 at 04:23:59PM -0700, Shuah Khan wrote:
> > tty_set_termios() has the following WARN_ON which can be triggered with a
> > syscall to invoke TIOCSETD __NR_ioctl.
>
> That's the only way to set the hci line discipline. And it's the
> consequent ioctl that sets the uart protocol that triggers the warning,
I meant *subsequent* ioctl, of course.
> but only if the tty is a pty master, as I mentioned before.
Johan
next prev parent reply other threads:[~2019-02-01 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 23:23 [PATCH v2] tty: Fix WARNING in tty_set_termios() Shuah Khan
2019-02-01 0:14 ` Greg KH
2019-02-01 23:21 ` shuah
2019-02-01 9:28 ` Johan Hovold
2019-02-01 9:36 ` Johan Hovold [this message]
2019-02-01 23:20 ` shuah
2019-02-01 10:00 ` Marcel Holtmann
2019-02-01 23:18 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201093639.GB3691@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.