From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 10/18] smc911x: pass struct device to DMA API functions Date: Fri, 1 Feb 2019 17:11:16 +0100 Message-ID: <20190201161116.GG6532@lst.de> References: <20190201084801.10983-1-hch@lst.de> <20190201084801.10983-11-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Robin Murphy Cc: Christoph Hellwig , John Crispin , Vinod Koul , Dmitry Tarnyagin , Nicolas Ferre , Sudip Mukherjee , Felipe Balbi , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, iommu@lists.linux-foundation.org List-Id: alsa-devel@alsa-project.org On Fri, Feb 01, 2019 at 02:14:34PM +0000, Robin Murphy wrote: > And equivalently for rxdma here. However, given that this all seems only > relevant to antique ARCH_PXA platforms which are presumably managing to > work as-is, it's probably not worth tinkering too much. I'd just stick a > note in the commit message that we're still only making these > self-consistent with the existing dma_map_single() calls rather than > necessarily correct. Sounds good. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [10/18] smc911x: pass struct device to DMA API functions From: Christoph Hellwig Message-Id: <20190201161116.GG6532@lst.de> Date: Fri, 1 Feb 2019 17:11:16 +0100 To: Robin Murphy Cc: Christoph Hellwig , John Crispin , Vinod Koul , Dmitry Tarnyagin , Nicolas Ferre , Sudip Mukherjee , Felipe Balbi , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, iommu@lists.linux-foundation.org List-ID: T24gRnJpLCBGZWIgMDEsIDIwMTkgYXQgMDI6MTQ6MzRQTSArMDAwMCwgUm9iaW4gTXVycGh5IHdy b3RlOgo+IEFuZCBlcXVpdmFsZW50bHkgZm9yIHJ4ZG1hIGhlcmUuIEhvd2V2ZXIsIGdpdmVuIHRo YXQgdGhpcyBhbGwgc2VlbXMgb25seSAKPiByZWxldmFudCB0byBhbnRpcXVlIEFSQ0hfUFhBIHBs YXRmb3JtcyB3aGljaCBhcmUgcHJlc3VtYWJseSBtYW5hZ2luZyB0byAKPiB3b3JrIGFzLWlzLCBp dCdzIHByb2JhYmx5IG5vdCB3b3J0aCB0aW5rZXJpbmcgdG9vIG11Y2guIEknZCBqdXN0IHN0aWNr IGEgCj4gbm90ZSBpbiB0aGUgY29tbWl0IG1lc3NhZ2UgdGhhdCB3ZSdyZSBzdGlsbCBvbmx5IG1h a2luZyB0aGVzZSAKPiBzZWxmLWNvbnNpc3RlbnQgd2l0aCB0aGUgZXhpc3RpbmcgZG1hX21hcF9z aW5nbGUoKSBjYWxscyByYXRoZXIgdGhhbiAKPiBuZWNlc3NhcmlseSBjb3JyZWN0LgoKU291bmRz IGdvb2QuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Fri, 01 Feb 2019 16:11:16 +0000 Subject: Re: [PATCH 10/18] smc911x: pass struct device to DMA API functions Message-Id: <20190201161116.GG6532@lst.de> List-Id: References: <20190201084801.10983-1-hch@lst.de> <20190201084801.10983-11-hch@lst.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Robin Murphy Cc: Christoph Hellwig , John Crispin , Vinod Koul , Dmitry Tarnyagin , Nicolas Ferre , Sudip Mukherjee , Felipe Balbi , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, iommu@lists.linux-foundation.org On Fri, Feb 01, 2019 at 02:14:34PM +0000, Robin Murphy wrote: > And equivalently for rxdma here. However, given that this all seems only > relevant to antique ARCH_PXA platforms which are presumably managing to > work as-is, it's probably not worth tinkering too much. I'd just stick a > note in the commit message that we're still only making these > self-consistent with the existing dma_map_single() calls rather than > necessarily correct. Sounds good.