From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH v4 0/9] mmu notifier provide context informations Date: Fri, 1 Feb 2019 22:02:30 +0100 Message-ID: <20190201210230.GA11643@quack2.suse.cz> References: <20190123222315.1122-1-jglisse@redhat.com> <20190131161006.GA16593@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190131161006.GA16593@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jerome Glisse Cc: Ralph Campbell , Jan Kara , Arnd Bergmann , kvm@vger.kernel.org, Matthew Wilcox , linux-rdma@vger.kernel.org, John Hubbard , Felix Kuehling , Radim =?utf-8?B?S3LEjW3DocWZ?= , Dan Williams , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Hocko , linux-mm@kvack.org, Jason Gunthorpe , Ross Zwisler , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: linux-rdma@vger.kernel.org T24gVGh1IDMxLTAxLTE5IDExOjEwOjA2LCBKZXJvbWUgR2xpc3NlIHdyb3RlOgo+IAo+IEFuZHJl dyB3aGF0IGlzIHlvdXIgcGxhbiBmb3IgdGhpcyA/IEkgaGFkIGEgZGlzY3Vzc2lvbiB3aXRoIFBl dGVyIFh1Cj4gYW5kIEFuZHJlYSBhYm91dCBjaGFuZ2VfcHRlKCkgYW5kIGt2bS4gVG9kYXkgdGhl IGNoYW5nZV9wdGUoKSBrdm0KPiBvcHRpbWl6YXRpb24gaXMgZWZmZWN0aXZlbHkgZGlzYWJsZWQg YmVjYXVzZSBvZiBpbnZhbGlkYXRlX3JhbmdlCj4gY2FsbHMuIFdpdGggYSBtaW5pbWFsIGNvdXBs ZSBsaW5lcyBwYXRjaCBvbiB0b3Agb2YgdGhpcyBwYXRjaHNldAo+IHdlIGNhbiBicmluZyBiYWNr IHRoZSBrdm0gY2hhbmdlX3B0ZSBvcHRpbWl6YXRpb24gYW5kIHdlIGNhbiBhbHNvCj4gb3B0aW1p emUgc29tZSBvdGhlciBjYXNlcyBsaWtlIGZvciBpbnN0YW5jZSB3aGVuIHdyaXRlIHByb3RlY3Rp bmcKPiBhZnRlciBmb3JrIChidXQgaSBhbSBub3Qgc3VyZSB0aGlzIGlzIHNvbWV0aGluZyBxZW11 IGRvZXMgb2Z0ZW4gc28KPiBpdCBtaWdodCBub3QgaGVscCBmb3IgcmVhbCBrdm0gd29ya2xvYWQp Lgo+IAo+IEkgd2lsbCBiZSBwb3N0aW5nIGEgdGhlIGV4dHJhIHBhdGNoIGFzIGFuIFJGQywgYnV0 IGluIHRoZSBtZWFudGltZQo+IGkgd2FudGVkIHRvIGtub3cgd2hhdCB3YXMgdGhlIHN0YXR1cyBm b3IgdGhpcy4KPiAKPiBKYW4sIENocmlzdGlhbiBkb2VzIHlvdXIgcHJldmlvdXMgQUNLIHN0aWxs IGhvbGRzIGZvciB0aGlzID8KClllcywgSSBzdGlsbCB0aGluayB0aGUgYXBwcm9hY2ggbWFrZXMg c2Vuc2UuIERhbidzIGNvbmNlcm4gYWJvdXQgaW4gdHJlZQp1c2VycyBpcyB2YWxpZCBidXQgaXQg c2VlbXMgeW91IGhhdmUgdGhvc2UganVzdCBub3QgbWVyZ2VkIHlldCwgcmlnaHQ/CgoJCQkJCQkJ CUhvbnphCgotLSAKSmFuIEthcmEgPGphY2tAc3VzZS5jb20+ClNVU0UgTGFicywgQ1IKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CFCDC282D8 for ; Fri, 1 Feb 2019 21:02:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6FE82084C for ; Fri, 1 Feb 2019 21:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726054AbfBAVCf (ORCPT ); Fri, 1 Feb 2019 16:02:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:51554 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725765AbfBAVCe (ORCPT ); Fri, 1 Feb 2019 16:02:34 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E61D1ADF1; Fri, 1 Feb 2019 21:02:32 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id EA6941E1574; Fri, 1 Feb 2019 22:02:30 +0100 (CET) Date: Fri, 1 Feb 2019 22:02:30 +0100 From: Jan Kara To: Jerome Glisse Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christian =?iso-8859-1?Q?K=F6nig?= , Jan Kara , Felix Kuehling , Jason Gunthorpe , Matthew Wilcox , Ross Zwisler , Dan Williams , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Michal Hocko , Ralph Campbell , John Hubbard , kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-fsdevel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v4 0/9] mmu notifier provide context informations Message-ID: <20190201210230.GA11643@quack2.suse.cz> References: <20190123222315.1122-1-jglisse@redhat.com> <20190131161006.GA16593@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131161006.GA16593@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu 31-01-19 11:10:06, Jerome Glisse wrote: > > Andrew what is your plan for this ? I had a discussion with Peter Xu > and Andrea about change_pte() and kvm. Today the change_pte() kvm > optimization is effectively disabled because of invalidate_range > calls. With a minimal couple lines patch on top of this patchset > we can bring back the kvm change_pte optimization and we can also > optimize some other cases like for instance when write protecting > after fork (but i am not sure this is something qemu does often so > it might not help for real kvm workload). > > I will be posting a the extra patch as an RFC, but in the meantime > i wanted to know what was the status for this. > > Jan, Christian does your previous ACK still holds for this ? Yes, I still think the approach makes sense. Dan's concern about in tree users is valid but it seems you have those just not merged yet, right? Honza -- Jan Kara SUSE Labs, CR