From: Andrew Lunn <andrew@lunn.ch>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Richard Cochran <richardcochran@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: dp83640: expire old TX-skb
Date: Fri, 1 Feb 2019 22:15:51 +0100 [thread overview]
Message-ID: <20190201211551.GD8274@lunn.ch> (raw)
In-Reply-To: <20190201210918.gvufqxpqzvuzfk5n@linutronix.de>
On Fri, Feb 01, 2019 at 10:09:18PM +0100, Sebastian Andrzej Siewior wrote:
> During sendmsg() a cloned skb is saved via dp83640_txtstamp() in
> ->tx_queue. After the NIC sends this packet, the PHY will reply with a
> timestamp for that TX packet. If the cable is pulled at the right time I
> don't see that packet. It might gets flushed as part of queue shutdown
> on NIC's side.
> Once the link is up again then after the next sendmsg() we enqueue
> another skb in dp83640_txtstamp() and have two on the list. Then the PHY
> will send a reply and decode_txts() attaches it to the first skb on the
> list.
> No crash occurs since refcounting works but we are one packet behind.
> linuxptp/ptp4l usually closes the socket and opens a new one (in such a
> timeout case) so those "stale" replies never get there. However it does
> not resume normal operation anymore.
>
> Purge old skbs in decode_txts().
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
Hi Sebastian
netdev does not use the Cc: stable@vger.kernel.org.
https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt
Please include a Fixes: tag, and a subject of [PATCH net] ...
Thanks
Andrew
next prev parent reply other threads:[~2019-02-01 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 21:09 [PATCH v2] net: dp83640: expire old TX-skb Sebastian Andrzej Siewior
2019-02-01 21:15 ` Andrew Lunn [this message]
2019-02-04 10:20 ` [PATCH net v3] " Sebastian Andrzej Siewior
2019-02-04 16:55 ` David Miller
2019-02-02 2:38 ` [PATCH v2] " Richard Cochran
[not found] ` <20190204061452.3339A2083B@mail.kernel.org>
2019-02-04 10:26 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201211551.GD8274@lunn.ch \
--to=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.