From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 2/2] drm/panel: Add driver for Samsung S6E63M0 panel Date: Fri, 1 Feb 2019 22:36:07 +0100 Message-ID: <20190201213607.GA27951@ravnborg.org> References: <20190201172852.4944-1-pawel.mikolaj.chmiel@gmail.com> <20190201172852.4944-2-pawel.mikolaj.chmiel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190201172852.4944-2-pawel.mikolaj.chmiel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?utf-8?B?UGF3ZcWC?= Chmiel Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, airlied@linux.ie, linux-kernel@vger.kernel.org, krzk@kernel.org, robh+dt@kernel.org, thierry.reding@gmail.com, dri-devel@lists.freedesktop.org, m.szyprowski@samsung.com List-Id: devicetree@vger.kernel.org SGkgUGF3ZcWCCgpMb29rcyBnb29kLCB0aGFua3MgZm9yIGFkZHJlc3NpbmcgYWxsIHRoZSByZXZp ZXcgZmVlZGJhY2suCgpPbiBGcmksIEZlYiAwMSwgMjAxOSBhdCAwNjoyODo1MlBNICswMTAwLCBQ YXdlxYIgQ2htaWVsIHdyb3RlOgo+IFRoaXMgcGF0Y2ggYWRkcyBTYW1zdW5nIFM2RTYzTTAgQU1P TEVEIExDRCBwYW5lbCBkcml2ZXIsIGNvbm5lY3RlZCBvdmVyCj4gc3BpLiBJdCdzIGJhc2VkIG9u IGFscmVhZHkgcmVtb3ZlZCwgbm9uIGR0IHM2ZTYzbTAgZHJpdmVyIGFuZAo+IHBhbmVsLXNhbXN1 bmctbGQ5MDQwLiBJdCBjYW4gYmUgZm91bmQgZm9yIGV4YW1wbGUgaW4gc29tZSBvZiBTYW1zdW5n Cj4gQXJpZXMgYmFzZWQgcGhvbmVzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhd2XFgiBDaG1pZWwg PHBhd2VsLm1pa29sYWouY2htaWVsQGdtYWlsLmNvbT4KSWYgeW91IGNvbnNpZGVyIChkbyBub3Qg Y2hhbmdlIHVubGVzcyB5b3UgdGhpbmsgaXQgYmV0dGVyKSB0aGUKZm9sbG93aW5nIG5pdHMgdGhh biB5b3UgY2FuIGFkZCBteToKClJldmlld2VkLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9y Zy5vcmc+CgoJU2FtCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvS2NvbmZp ZyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9LY29uZmlnCj4gaW5kZXggM2YzNTM3NzE5YmViLi5i ZTA1ZWQ1MjE4ZWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL0tjb25maWcK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvS2NvbmZpZwo+IEBAIC0xNTgsNiArMTU4LDEz IEBAIGNvbmZpZyBEUk1fUEFORUxfU0FNU1VOR19TNkU2M0owWDAzCj4gIAlkZXBlbmRzIG9uIEJB Q0tMSUdIVF9DTEFTU19ERVZJQ0UKPiAgCXNlbGVjdCBWSURFT01PREVfSEVMUEVSUwo+ICAKPiAr Y29uZmlnIERSTV9QQU5FTF9TQU1TVU5HX1M2RTYzTTAKPiArCXRyaXN0YXRlICJTYW1zdW5nIFM2 RTYzTTAgUkdCL1NQSSBwYW5lbCIKPiArCWRlcGVuZHMgb24gT0YKPiArCWRlcGVuZHMgb24gU1BJ Cj4gKwlkZXBlbmRzIG9uIEJBQ0tMSUdIVF9DTEFTU19ERVZJQ0UKPiArCXNlbGVjdCBWSURFT01P REVfSEVMUEVSUwpXaXRoIHRoZSB1c2Ugb2YgZGlzcGxheV9tb2RlIHRoZSBhYm92ZSAic2VsZWN0 IFZJREVPTU9ERV9IRUxQRVJTIgppcyBsaWtlbHkgbm8gbG9uZ2VyIHJlcXVpcmVkLiBQbGVhc2Ug Y2hlY2suCgpBIGhlbHAgdGV4dCB3b3VsZCBiZSBuaWNlLgoKPiArCj4gIGNvbmZpZyBEUk1fUEFO RUxfU0FNU1VOR19TNkU4QUEwCj4gIAl0cmlzdGF0ZSAiU2Ftc3VuZyBTNkU4QUEwIERTSSB2aWRl byBtb2RlIHBhbmVsIgo+ICAJZGVwZW5kcyBvbiBPRgoKCj4gKyNpbmNsdWRlIDx2aWRlby9vZl92 aWRlb21vZGUuaD4KPiArI2luY2x1ZGUgPHZpZGVvL3ZpZGVvbW9kZS5oPgpQbGVhc2UgY2hlY2sg aWYgdGhlc2UgdHdvIGZpbGVzIGFyZSByZXF1aXJlZC4KCj4gK3N0cnVjdCBzNmU2M20wIHsKPiAr CXN0cnVjdCBkZXZpY2UgKmRldjsKPiArCXN0cnVjdCBkcm1fcGFuZWwgcGFuZWw7Cj4gKwlzdHJ1 Y3QgYmFja2xpZ2h0X2RldmljZSAqYmxfZGV2Owo+ICsKPiArCXN0cnVjdCByZWd1bGF0b3JfYnVs a19kYXRhIHN1cHBsaWVzWzJdOwo+ICsJc3RydWN0IGdwaW9fZGVzYyAqcmVzZXRfZ3BpbzsKPiAr CXN0cnVjdCB2aWRlb21vZGUgdm07CnZtIGlzIG5vIGxvbmdlciB1c2VkIC0gZGVsZXRlIGl0LgoK PiArCj4gKwlib29sIHByZXBhcmVkOwo+ICsJYm9vbCBlbmFibGVkOwo+ICsKPiArCS8qCj4gKwkg KiBUaGlzIGZpZWxkIGlzIHRlc3RlZCBieSBmdW5jdGlvbnMgZGlyZWN0bHkgYWNjZXNzaW5nIGJ1 cyBiZWZvcmUKPiArCSAqIHRyYW5zZmVyLCB0cmFuc2ZlciBpcyBza2lwcGVkIGlmIGl0IGlzIHNl dC4gSW4gY2FzZSBvZiB0cmFuc2Zlcgo+ICsJICogZmFpbHVyZSBvciB1bmV4cGVjdGVkIHJlc3Bv bnNlIHRoZSBmaWVsZCBpcyBzZXQgdG8gZXJyb3IgdmFsdWUuCj4gKwkgKiBTdWNoIGNvbnN0cnVj dCBhbGxvd3MgdG8gZWxpbWluYXRlIG1hbnkgY2hlY2tzIGluIGhpZ2hlciBsZXZlbAo+ICsJICog ZnVuY3Rpb25zLgo+ICsJICovCj4gKwlpbnQgZXJyb3I7Cj4gK307Cj4gKwoKPiArc3RhdGljIGlu dCBzNmU2M20wX2dldF9tb2RlcyhzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCkKPiArewo+ICsJc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciA9IHBhbmVsLT5jb25uZWN0b3I7Cj4gKwlzdHJ1 Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZTsKPiArCj4gKwltb2RlID0gZHJtX21vZGVfZHVwbGlj YXRlKHBhbmVsLT5kcm0sICZkZWZhdWx0X21vZGUpOwo+ICsJaWYgKCFtb2RlKSB7Cj4gKwkJRFJN X0VSUk9SKCJmYWlsZWQgdG8gYWRkIG1vZGUgJXV4JXV4QCV1XG4iLAo+ICsJCQkgIGRlZmF1bHRf bW9kZS5oZGlzcGxheSwgZGVmYXVsdF9tb2RlLnZkaXNwbGF5LAo+ICsJCQkgIGRlZmF1bHRfbW9k ZS52cmVmcmVzaCk7CkkgcmVjYWxsIEkgaGF2ZSBzZWVuIGEgZ2VuZXJpYyB3YXkgdG8gcHJpbnQg dGhlIGFib3ZlLApidXQgSSBoYXZlIGZhaWxlZCB0byBmaW5kIGl0LgpNYXliZSBpdCBpcyBqdXN0 IG15IG1lbW9yeSB0aGF0IGZvb2xzIG1lLgoKVGhlIGFib3ZlIGlzIGZpbmUuCgo+ICsKPiArCXM2 ZTYzbTBfYmFja2xpZ2h0X3JlZ2lzdGVyKGN0eCk7CgpJcyBpdCBjb3JyZWN0IHRoYXQgd2UgY29u dGludWUgZXZlbiBpZiB3ZSBmYWlsIHRvIHJlZ2lzdGVyIGJhY2tsaWdodD8KCgo+ICsKPiArCXJl dHVybiAwOwo+ICt9Cj4gKwo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQg czZlNjNtMF9vZl9tYXRjaFtdID0gewo+ICsJeyAuY29tcGF0aWJsZSA9ICJzYW1zdW5nLHM2ZTYz bTAiIH0sCj4gKwl7IH0KCkFkZCAvKiBzZW50aW5lbCAqLyBjb21tZW50PwoKPiArfTsKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10426C282D8 for ; Fri, 1 Feb 2019 21:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D58BA20869 for ; Fri, 1 Feb 2019 21:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbfBAVgO (ORCPT ); Fri, 1 Feb 2019 16:36:14 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:38923 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbfBAVgO (ORCPT ); Fri, 1 Feb 2019 16:36:14 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id A7EA980478; Fri, 1 Feb 2019 22:36:08 +0100 (CET) Date: Fri, 1 Feb 2019 22:36:07 +0100 From: Sam Ravnborg To: =?utf-8?B?UGF3ZcWC?= Chmiel Cc: thierry.reding@gmail.com, mark.rutland@arm.com, devicetree@vger.kernel.org, airlied@linux.ie, linux-kernel@vger.kernel.org, krzk@kernel.org, robh+dt@kernel.org, dri-devel@lists.freedesktop.org, m.szyprowski@samsung.com Subject: Re: [PATCH v2 2/2] drm/panel: Add driver for Samsung S6E63M0 panel Message-ID: <20190201213607.GA27951@ravnborg.org> References: <20190201172852.4944-1-pawel.mikolaj.chmiel@gmail.com> <20190201172852.4944-2-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190201172852.4944-2-pawel.mikolaj.chmiel@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=IkcTkHD0fZMA:10 a=pGLkceISAAAA:8 a=7gkXJVJtAAAA:8 a=L5PT5Dt8MpijkRvZmKwA:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paweł Looks good, thanks for addressing all the review feedback. On Fri, Feb 01, 2019 at 06:28:52PM +0100, Paweł Chmiel wrote: > This patch adds Samsung S6E63M0 AMOLED LCD panel driver, connected over > spi. It's based on already removed, non dt s6e63m0 driver and > panel-samsung-ld9040. It can be found for example in some of Samsung > Aries based phones. > > Signed-off-by: Paweł Chmiel If you consider (do not change unless you think it better) the following nits than you can add my: Reviewed-by: Sam Ravnborg Sam > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 3f3537719beb..be05ed5218eb 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -158,6 +158,13 @@ config DRM_PANEL_SAMSUNG_S6E63J0X03 > depends on BACKLIGHT_CLASS_DEVICE > select VIDEOMODE_HELPERS > > +config DRM_PANEL_SAMSUNG_S6E63M0 > + tristate "Samsung S6E63M0 RGB/SPI panel" > + depends on OF > + depends on SPI > + depends on BACKLIGHT_CLASS_DEVICE > + select VIDEOMODE_HELPERS With the use of display_mode the above "select VIDEOMODE_HELPERS" is likely no longer required. Please check. A help text would be nice. > + > config DRM_PANEL_SAMSUNG_S6E8AA0 > tristate "Samsung S6E8AA0 DSI video mode panel" > depends on OF > +#include