From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yonghong Song <yhs@fb.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Magnus Karlsson <magnus.karlsson@intel.com>,
netdev@vger.kernel.org, Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com
Subject: Re: [PATCH bpf-next v2 1/3] tools/bpf: move libbpf pr_* debug print functions to headers
Date: Sat, 2 Feb 2019 00:10:07 +0100 [thread overview]
Message-ID: <20190201231007.GB5593@kernel.org> (raw)
In-Reply-To: <20190201174731.695515-1-yhs@fb.com>
Em Fri, Feb 01, 2019 at 09:47:31AM -0800, Yonghong Song escreveu:
> @@ -698,13 +695,13 @@ struct btf_ext *btf_ext__new(__u8 *data, __u32 size, btf_print_fn_t err_log)
> if (!btf_ext)
> return ERR_PTR(-ENOMEM);
>
> - err = btf_ext_copy_func_info(btf_ext, data, size, err_log);
> + err = btf_ext_copy_func_info(btf_ext, data, size);
> if (err) {
> btf_ext__free(btf_ext);
One thing I noticed whas that the class + __ + method is not being
consistently followed, will this be dealt with in a followup patch, i.e.
to make this consistently use the format used in the
btf_ext__free(btf_ext) case?
> return ERR_PTR(err);
> }
>
> - err = btf_ext_copy_line_info(btf_ext, data, size, err_log);
> + err = btf_ext_copy_line_info(btf_ext, data, size);
> if (err) {
> btf_ext__free(btf_ext);
> return ERR_PTR(err);
- Arnaldo
next prev parent reply other threads:[~2019-02-01 23:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 17:47 [PATCH bpf-next v2 0/3] tools/bpf: changes of libbpf debug interfaces Yonghong Song
2019-02-01 17:47 ` [PATCH bpf-next v2 1/3] tools/bpf: move libbpf pr_* debug print functions to headers Yonghong Song
2019-02-01 23:10 ` Arnaldo Carvalho de Melo [this message]
2019-02-01 23:20 ` Yonghong Song
2019-02-01 23:29 ` Arnaldo Carvalho de Melo
2019-02-01 17:47 ` [PATCH bpf-next v2 2/3] tools/bpf: print out btf log at LIBBPF_WARN level Yonghong Song
2019-02-01 17:47 ` [PATCH bpf-next v2 3/3] tools/bpf: simplify libbpf API function libbpf_set_print() Yonghong Song
2019-02-01 19:02 ` Andrii Nakryiko
2019-02-01 20:37 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201231007.GB5593@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.