Re: [PATCH] cifs: Always resolve hostname before reconnecting

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Jan 30, 2019 at 04:07:30PM -0800, Pavel Shilovsky wrote:
> Commit 28eb24ff75c5 ("cifs: Always resolve hostname before reconnecting").
> 
> In case a hostname resolves to a different IP address (e.g. long
> running mounts), make sure to resolve it every time prior to calling
> generic_ip_connect() in reconnect.
> 
> This patch needs user space changes of cifs.upcall that set a timeout
> value for the "dns_resolver" key.

Wait, you are requiring userspace to upgrade tools to support this?  And
you think that will happen to all systems running older kernels?

This really feels like a new feature being added, what bug is this
fixing that requires it to be backported to all of the stable kernel
trees?

> 
> Suggested-by: Steve French <stfrench@microsoft.com>
> Signed-off-by: Paulo Alcantara <palcantara@suse.de>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>

At the very least, I would like the CIFS maintainer to ack this type of
thing before accepting it, as it was not tagged for the stable kernels
for some reason...

thanks,

greg k-h