From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F01A6C282D7 for ; Sat, 2 Feb 2019 12:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AECC320863 for ; Sat, 2 Feb 2019 12:35:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="ppXBAhMr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbfBBMf4 (ORCPT ); Sat, 2 Feb 2019 07:35:56 -0500 Received: from mail-eopbgr50051.outbound.protection.outlook.com ([40.107.5.51]:8428 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727349AbfBBMf4 (ORCPT ); Sat, 2 Feb 2019 07:35:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nItc70mbzH8dh0IKAJ55VeoRPglrnW3WFxknYyBmmBs=; b=ppXBAhMrzJwyaMq2ejIGagWfQliwKktJW328gGzrfNCMP6upah9DRhK+BGA07D1Z1yauJxN7IkScz4qRuxYnG6u97Mpl03Lkmix87QMBXIlOai4DSy4cmvjqjI3otY3Iy4AMEtcWAUWAyvC48VZl6FhjklFMt1QIMxzCs+NcMFY= Received: from DB7PR05MB4940.eurprd05.prod.outlook.com (20.176.235.152) by DB7PR05MB5382.eurprd05.prod.outlook.com (20.177.122.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.21; Sat, 2 Feb 2019 12:35:52 +0000 Received: from DB7PR05MB4940.eurprd05.prod.outlook.com ([fe80::6161:97fd:d315:7b07]) by DB7PR05MB4940.eurprd05.prod.outlook.com ([fe80::6161:97fd:d315:7b07%6]) with mapi id 15.20.1580.019; Sat, 2 Feb 2019 12:35:51 +0000 From: Ido Schimmel To: Jakub Kicinski CC: "davem@davemloft.net" , "jiri@resnulli.us" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: Re: [PATCH net-next] net: devlink: report cell size of shared buffers Thread-Topic: [PATCH net-next] net: devlink: report cell size of shared buffers Thread-Index: AQHUupqIXrT1VKnfQkqhDm3DU/B1uaXMcnKA Date: Sat, 2 Feb 2019 12:35:51 +0000 Message-ID: <20190202123549.GA24795@splinter> References: <20190202015628.30877-1-jakub.kicinski@netronome.com> In-Reply-To: <20190202015628.30877-1-jakub.kicinski@netronome.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR0402CA0002.eurprd04.prod.outlook.com (2603:10a6:209::15) To DB7PR05MB4940.eurprd05.prod.outlook.com (2603:10a6:10:1e::24) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [109.67.26.132] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB7PR05MB5382;6:wPgqk8BBGq5U3BlxXE+nimNdCspen3C1//NXNZYhi/iJ69N/3Rt4NKXWGbrSWOvUHggKw5E1D1qfh6ArMZ4jooYTpWyieIiYLxeT53KbxG8t82XKBUxqBylQT4Mk4ultBaKkaWb5oRs47dQ+2ffQVW6SMfHN+J//FFwUYPaDgFprq9Tq3dZxsPxchwTwASVu8ViuJ8L1xNhkniF8UDRefYiIYonccIb88M3hE/yoCl7pv8bziCPwwDStFrAhE0vLjj6YQnRJktbpvKHhWcZuvvsof/32ckC4zpwFhiBl8eRRo7vz+pcbHrP70T7RDG6rAzlwGNatxLlpINgIHgm6bdslAI5rdEPZmgD59xvG596c3HwhnAuVQvSN1bG2fU1MOXLsElejmBEc60fTMp6G/5Uz8kdJqPyAyjP5RIgOHearWgpeEtwOQS/I5TLDwzA45Bzf3cgf8ldhxPM1UZeSSw==;5:ZyMSAebQ3d+w6TZkztHyClzyt8kFO9hlDRoHGppCsEUgnw+hKZNIbG6aHAKcGmFlGN6nIjzy0Su9XOlt6Ny0MqwSYSY3bC9FJnEd9C3/opzsPRKO3XdfOmFNUbhVd26KgYpNJc7fyl0lAh7aUlEvCkuwLTc295SajS6sCWilPXb1PB7xw4gW4T3xAX7mRtcQOBCosU6RF9dvnzHemeI9+g==;7:gRnur1Gphk1x1JsuEEWf2Se5+OOHRXe6A4mtaaH71KGRXAKWGtwUbOB7boagYuzerAK25V013kMDLA9MGKTW3mX29fQM668bGh8Tz5oknwwE8QfiFJAl0lxGP6hQdtEhFQqZ/RybZbj8ip3P2I0idQ== x-ms-office365-filtering-correlation-id: f16ddfae-75a9-4418-71e5-08d6890af781 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:DB7PR05MB5382; x-ms-traffictypediagnostic: DB7PR05MB5382: x-microsoft-antispam-prvs: x-forefront-prvs: 09368DB063 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(346002)(376002)(366004)(396003)(39860400002)(136003)(199004)(189003)(2906002)(81166006)(81156014)(8676002)(478600001)(186003)(86362001)(8936002)(305945005)(53936002)(9686003)(6512007)(25786009)(7736002)(6246003)(52116002)(76176011)(6506007)(386003)(26005)(6116002)(14454004)(33896004)(97736004)(102836004)(3846002)(4744005)(446003)(476003)(11346002)(106356001)(99286004)(229853002)(68736007)(105586002)(71200400001)(71190400001)(486006)(1076003)(33716001)(39060400002)(4326008)(6916009)(66066001)(256004)(33656002)(6436002)(54906003)(6486002)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR05MB5382;H:DB7PR05MB4940.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qiJ2I/XZR2wvBhfrga/MZqJw6dN1/BlnN3Vh+6vsL8idSHo2SlqyOLwA3kxe6IiFAzuft42me8RH0V/5vXfwYuT7O8LtanI+jAFXAzmDE+7gEDtzz2RZ20Cnd4fLd42Z30B6c7xhNrH9TqI7pdWeLxSRVvpjg5ylBeRZ+6GH9mb2PogjOIw6R4Io63avq5c0TmvDGq59Jy9Ca83zjuWNMxOsBHIBntnjCIm1+25pby3lWf2ijduTFF58X6BRsVqII8ur85nZYu5/zpY0jeF5NHtEImRlDsjJff9SjSd63SNGT8+8bXfzYfTzz0CX2Gx9m/SQH1GaNy8JoIrs05Iueq3r5ckerSojc225CJ+WanW807rtZmlvIenHGfgUVrvVPFjYLdlF4QCf1TUtPYbQ7KlND21faMCj2Bfb52BNg/M= Content-Type: text/plain; charset="us-ascii" Content-ID: <7DA8A9C9A2618846A7BCA3FA02DCF0F7@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f16ddfae-75a9-4418-71e5-08d6890af781 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2019 12:35:51.1945 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5382 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 01, 2019 at 05:56:28PM -0800, Jakub Kicinski wrote: > Shared buffer allocation is usually done in cell increments. > Drivers will either round up the allocation or refuse the > configuration if it's not an exact multiple of cell size. > Drivers know exactly the cell size of shared buffer, so help > out users by providing this information in dumps. >=20 > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe Reviewed-by: Ido Schimmel I assume you're going to patch iproute2. Consider explaining what is cell size in devlink-sb manpage. Thanks!