All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 09/17] package/gqrx: remove unneeded fftw dependency
Date: Sat, 2 Feb 2019 17:40:45 +0100	[thread overview]
Message-ID: <20190202164045.GB6663@scaer> (raw)
In-Reply-To: <1548078671-63318-9-git-send-email-gwenj@trabucayre.com>

Gwenhael, All,

On 2019-01-21 14:51 +0100, Gwenhael Goavec-Merou spake thusly:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> Thanks to the new fftw package organization, gnuradio already selects
> the appropriate fftw precision, and there is no need to propagate the
> "depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE" that used to be present
> in the gnuradio package.
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> Changes v3 -> v4:
>  * use select instead of depends on for GNURadio and propagates
>    dependencies.(yann)
[--SNIP--]
>  config BR2_PACKAGE_GQRX
>  	bool "gqrx"
> -	depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE # gnuradio
> -	depends on BR2_PACKAGE_GNURADIO
>  	depends on BR2_PACKAGE_QT5
> +	depends on !BR2_PACKAGE_PYTHON3
>  	depends on BR2_INSTALL_LIBSTDCPP # boost
> +	depends on !BR2_STATIC_LIBS # gnuradio
> +	depends on BR2_USE_MMU # gnuradio

We're now trying to list dependencies in a consistent order, with
architecture dependencies first, then toolchain depes, then package
deps. So, dependencies on MMU should go before first, then !static libs,
then libstdcpp, then packages:

    https://buildroot.org/downloads/manual/manual.html#_config_files

Otherwise:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

>  	depends on BR2_TOOLCHAIN_HAS_THREADS # boost
>  	depends on BR2_USE_WCHAR # boost
>  	select BR2_PACKAGE_BOOST
>  	select BR2_PACKAGE_BOOST_PROGRAM_OPTIONS
>  	select BR2_PACKAGE_BOOST_SYSTEM
> +	select BR2_PACKAGE_GNURADIO
>  	select BR2_PACKAGE_GNURADIO_ANALOG
>  	select BR2_PACKAGE_GNURADIO_AUDIO
>  	select BR2_PACKAGE_GNURADIO_BLOCKS
> -- 
> 2.19.2
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2019-02-02 16:40 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 13:50 [Buildroot] [PATCH v4 01/17] package/fftw: prepare for splitting into multiple packages Gwenhael Goavec-Merou
2019-01-21 13:50 ` [Buildroot] [PATCH v4 02/17] package/fftw: break fftw-single into a dedicated package Gwenhael Goavec-Merou
2019-01-21 13:50   ` [Buildroot] [PATCH v4 03/17] package/fftw: break fftw-long-double " Gwenhael Goavec-Merou
2019-01-21 13:50     ` [Buildroot] [PATCH v4 04/17] package/fftw: break fftw-quad " Gwenhael Goavec-Merou
2019-01-21 13:50       ` [Buildroot] [PATCH v4 05/17] package/fftw: break fftw-double " Gwenhael Goavec-Merou
2019-01-21 13:51         ` [Buildroot] [PATCH v4 06/17] package/alsa-utils: use the new fftw-single package Gwenhael Goavec-Merou
2019-01-21 13:51           ` [Buildroot] [PATCH v4 07/17] package/aubio: use the new fftw-double and fftw-single packages Gwenhael Goavec-Merou
2019-01-21 13:51             ` [Buildroot] [PATCH v4 08/17] package/gnuradio: use the new fftw-single package Gwenhael Goavec-Merou
2019-01-21 13:51               ` [Buildroot] [PATCH v4 09/17] package/gqrx: remove unneeded fftw dependency Gwenhael Goavec-Merou
2019-01-21 13:51                 ` [Buildroot] [PATCH v4 10/17] package/hackrf: use the new fftw-single package Gwenhael Goavec-Merou
2019-01-21 13:51                   ` [Buildroot] [PATCH v4 11/17] package/httping: use the new fftw-double package Gwenhael Goavec-Merou
2019-01-21 13:51                     ` [Buildroot] [PATCH v4 12/17] package/imagemagick: " Gwenhael Goavec-Merou
2019-01-21 13:51                       ` [Buildroot] [PATCH v4 13/17] package/libvips: " Gwenhael Goavec-Merou
2019-01-21 13:51                         ` [Buildroot] [PATCH v4 14/17] package/pulseaudio: use the new fftw-single package Gwenhael Goavec-Merou
2019-01-21 13:51                           ` [Buildroot] [PATCH v4 15/17] package/liquid-dsp: use the new fftw-{single, double, long-double} packages Gwenhael Goavec-Merou
2019-01-21 13:51                             ` [Buildroot] [PATCH v4 16/17] package/fftw: remove as regular package Gwenhael Goavec-Merou
2019-01-21 13:51                               ` [Buildroot] [PATCH v4 17/17] package/liquid-dsp: drop support for fftw-double and fftw-long-double Gwenhael Goavec-Merou
2019-02-05 21:09                                 ` Thomas Petazzoni
2019-02-06  5:40                                   ` Baruch Siach
2019-02-06  8:36                                     ` Thomas Petazzoni
2019-02-02 17:16                               ` [Buildroot] [PATCH v4 16/17] package/fftw: remove as regular package Yann E. MORIN
2019-02-06  9:23                                 ` Thomas Petazzoni
2019-02-02 22:08                               ` Yann E. MORIN
2019-02-02 16:54                             ` [Buildroot] [PATCH v4 15/17] package/liquid-dsp: use the new fftw-{single, double, long-double} packages Yann E. MORIN
2019-02-02 16:45                           ` [Buildroot] [PATCH v4 14/17] package/pulseaudio: use the new fftw-single package Yann E. MORIN
2019-02-02 16:44                         ` [Buildroot] [PATCH v4 13/17] package/libvips: use the new fftw-double package Yann E. MORIN
2019-02-02 16:42                       ` [Buildroot] [PATCH v4 12/17] package/imagemagick: " Yann E. MORIN
2019-02-02 16:41                     ` [Buildroot] [PATCH v4 11/17] package/httping: " Yann E. MORIN
2019-02-02 16:40                 ` Yann E. MORIN [this message]
2019-02-02 16:34               ` [Buildroot] [PATCH v4 08/17] package/gnuradio: use the new fftw-single package Yann E. MORIN
2019-02-02 14:52             ` [Buildroot] [PATCH v4 07/17] package/aubio: use the new fftw-double and fftw-single packages Yann E. MORIN
2019-02-02 14:38       ` [Buildroot] [PATCH v4 04/17] package/fftw: break fftw-quad into a dedicated package Yann E. MORIN
2019-02-06  9:16 ` [Buildroot] [PATCH v4 01/17] package/fftw: prepare for splitting into multiple packages Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190202164045.GB6663@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.