diff for duplicates of <20190203112904.GA2563@kadam> diff --git a/a/1.txt b/N1/1.txt index 02ca626..1be6161 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -23,7 +23,8 @@ On Sat, Feb 02, 2019 at 09:59:16PM +0000, Colin King wrote: > unsigned int div = dt2811_clk_dividers[_div]; > unsigned int mult = dt2811_clk_multipliers[_mult]; > - unsigned long long divider = div * mult; -> + unsigned long long divider > + (unsigned long long)div * mult; +> + unsigned long long divider = +> + (unsigned long long)div * mult; The max "div" can be is 12. The max "mult" can be is 10,000,000. So this is a false positive because there is no overflow. The code is not diff --git a/a/content_digest b/N1/content_digest index a2c1c8f..1b68c96 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020190202215916.25753-1-colin.king@canonical.com\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] staging: comedi: dt2811: fix integer overflow in multiply\0" - "Date\0Sun, 03 Feb 2019 11:29:04 +0000\0" + "Date\0Sun, 3 Feb 2019 14:29:04 +0300\0" "To\0Colin King <colin.king@canonical.com>\0" "Cc\0Ian Abbott <abbotti@mev.co.uk>" H Hartley Sweeten <hsweeten@visionengravers.com> @@ -36,7 +36,8 @@ "> \t\t\tunsigned int div = dt2811_clk_dividers[_div];\n" "> \t\t\tunsigned int mult = dt2811_clk_multipliers[_mult];\n" "> -\t\t\tunsigned long long divider = div * mult;\n" - "> +\t\t\tunsigned long long divider > +\t\t\t\t(unsigned long long)div * mult;\n" + "> +\t\t\tunsigned long long divider =\n" + "> +\t\t\t\t(unsigned long long)div * mult;\n" "\n" "The max \"div\" can be is 12. The max \"mult\" can be is 10,000,000. So\n" "this is a false positive because there is no overflow. The code is not\n" @@ -47,4 +48,4 @@ "regards,\n" dan carpenter -31cf14db756a6eace5b8054dbfc2f0d79aefc7e113c08e4a3c098ca3ea146ef4 +f5a0285edccc3acd8a2042caa3f5c3b97f21608df392dcca1b81dd4db4e24452
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.