From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 4/9] mtd: rawnand: jz4780: Add support for the JZ4740 Date: Sun, 3 Feb 2019 15:24:08 +0100 Message-ID: <20190203152408.2795de7e@bbrezillon> References: <20190202231926.2444-1-paul@crapouillou.net> <20190202231926.2444-5-paul@crapouillou.net> <20190203083151.4fc29c5b@bbrezillon> <1549202213.1950.1@crapouillou.net> <20190203150827.401ac31d@bbrezillon> <1549203050.1950.3@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1549203050.1950.3@crapouillou.net> Sender: linux-kernel-owner@vger.kernel.org To: Paul Cercueil Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland , Miquel Raynal , Harvey Hunt , Mathieu Malaterre , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Sun, 03 Feb 2019 11:10:50 -0300 Paul Cercueil wrote: > Le dim. 3 f=C3=A9vr. 2019 =C3=A0 11:08, Boris Brezillon =20 > a =C3=A9crit : > > On Sun, 03 Feb 2019 10:56:53 -0300 > > Paul Cercueil wrote: > > =20 > >> Le dim. 3 f=C3=A9vr. 2019 =C3=A0 4:31, Boris Brezillon=20 > >> > >> a =C3=A9crit : =20 > >> > On Sat, 2 Feb 2019 20:19:21 -0300 > >> > Paul Cercueil wrote: > >> > =20 > >> >> Add support for probing the jz4780-nand driver on the JZ4740 SoC > >> >> from > >> >> Ingenic. > >> >> > >> >> Signed-off-by: Paul Cercueil > >> >> --- > >> >> > >> >> Changes: > >> >> > >> >> v2: - Add support for the JZ4740 and not the JZ4725B: they =20 > >> behave =20 > >> >> the > >> >> same, and JZ4740 is fully upstream while JZ4725B is not. = =20 > >> The =20 > >> >> JZ4725B devicetree will then simply use the > >> >> "ingenic,jz4740-nand" > >> >> compatible string. > >> >> - Fix the number of bytes for the ECC when the ECC strength = =20 > >> is =20 > >> >> 4. > >> >> This is needed for the JZ4740, which uses Reed-Solomon > >> >> instead of > >> >> BCH. > >> >> > >> >> drivers/mtd/nand/raw/ingenic/jz4780_nand.c | 48 > >> >> +++++++++++++++++----- =20 > >> > > >> > If we're going to make the driver compatible with jz4740 and =20 > >> jz4725b =20 > >> > maybe we should rename the source files jz47xx_{nand,bch}.{c,h}. =20 > >>=20 > >> I don't know about that. Adding support for new hardware isn't a=20 > >> good > >> reason to > >> rename the driver, or so I've been told around here, as you then=20 > >> make > >> it harder > >> to review the git history of the driver. =20 > >=20 > > You already move files to a sub-directory so that doesn't make a huge > > difference, history will be hard to follow because of this move=20 > > anyway. =20 >=20 > Yes, but if I merge the *_bch.c files together, and eventually drop > jz4740-nand.c, does it still make sense to move to a sub-directory? >=20 Still prefer to make things explicit over preserving file names to make git log history linear. And anyway, how hard is it to figure out that the last commit in git log drivers/mtd/nand/raw/.c is moving the file (there might even be an option for that)? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE1ABC282DB for ; Sun, 3 Feb 2019 14:24:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84CDA218D8 for ; Sun, 3 Feb 2019 14:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RebXlCqE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hcoRJHeB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84CDA218D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=guESd47XbNAiZQr0CRoeg6khNk2QPlIyPvbhSwl6sUE=; b=RebXlCqEkkBDGD 3bgV86VIrcWNsN8RF6ucUUEqhyoxJIxCNm89CmWYOvzCXRuSFp6EOdLp/3bS0ZRdm1iAQxF1IAOXr gByS7D7clb4JwVZ55UlFEmaWk12zzhS/9KB7c0H78Ze4x9BsUOsiCktHMc4hhvepkobBZa4jli+Zz qZ60BcZUtS2oSKzHTH9IR05FPty5bX0+4BeXOmQkmZcNEpuXyfTj3q4IaGDsOx/Fla3R0d0nOE1eo xxbJvNUKk/EwcmLsYC5XYB83QGfYQDBHlEd6dRmCT/gxmX6fIYTNypyZ6NUBS28uFYxk1MSWSqf71 boC11H/O19z+Qi8gC22g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gqIh6-0005KT-2q; Sun, 03 Feb 2019 14:24:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gqIh2-0005Jm-SC for linux-mtd@lists.infradead.org; Sun, 03 Feb 2019 14:24:22 +0000 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93F102084A; Sun, 3 Feb 2019 14:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549203860; bh=PrXer47KHA40S2YqkSEELxve4hCip8gF445pVwtHm/A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hcoRJHeBfU6/8YFjJ+eMaI36hMnLgWme4GDaDwPLJYkv7Z2//AjQyqgy+16cuzsa7 xZAozvNWZT4Q7s0acQL6qHjJbO68085xsYrXXyomhXx1/ju+gTQxKC6xVesbCkDP/5 WggQQaxTLhHgWd8XA6qeBt7L/nnm9qyqxZFBG5So= Date: Sun, 3 Feb 2019 15:24:08 +0100 From: Boris Brezillon To: Paul Cercueil Subject: Re: [PATCH v2 4/9] mtd: rawnand: jz4780: Add support for the JZ4740 Message-ID: <20190203152408.2795de7e@bbrezillon> In-Reply-To: <1549203050.1950.3@crapouillou.net> References: <20190202231926.2444-1-paul@crapouillou.net> <20190202231926.2444-5-paul@crapouillou.net> <20190203083151.4fc29c5b@bbrezillon> <1549202213.1950.1@crapouillou.net> <20190203150827.401ac31d@bbrezillon> <1549203050.1950.3@crapouillou.net> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190203_062420_950489_5E9C666B X-CRM114-Status: GOOD ( 26.22 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Mathieu Malaterre , Richard Weinberger , linux-kernel@vger.kernel.org, Marek Vasut , Rob Herring , linux-mtd@lists.infradead.org, Harvey Hunt , Miquel Raynal , Brian Norris , David Woodhouse Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gU3VuLCAwMyBGZWIgMjAxOSAxMToxMDo1MCAtMDMwMApQYXVsIENlcmN1ZWlsIDxwYXVsQGNy YXBvdWlsbG91Lm5ldD4gd3JvdGU6Cgo+IExlIGRpbS4gMyBmw6l2ci4gMjAxOSDDoCAxMTowOCwg Qm9yaXMgQnJlemlsbG9uIDxiYnJlemlsbG9uQGtlcm5lbC5vcmc+IAo+IGEgw6ljcml0IDoKPiA+ IE9uIFN1biwgMDMgRmViIDIwMTkgMTA6NTY6NTMgLTAzMDAKPiA+IFBhdWwgQ2VyY3VlaWwgPHBh dWxAY3JhcG91aWxsb3UubmV0PiB3cm90ZToKPiA+ICAgCj4gPj4gIExlIGRpbS4gMyBmw6l2ci4g MjAxOSDDoCA0OjMxLCBCb3JpcyBCcmV6aWxsb24gCj4gPj4gPGJicmV6aWxsb25Aa2VybmVsLm9y Zz4KPiA+PiAgYSDDqWNyaXQgOiAgCj4gPj4gID4gT24gU2F0LCAgMiBGZWIgMjAxOSAyMDoxOToy MSAtMDMwMAo+ID4+ICA+IFBhdWwgQ2VyY3VlaWwgPHBhdWxAY3JhcG91aWxsb3UubmV0PiB3cm90 ZToKPiA+PiAgPiAgCj4gPj4gID4+ICBBZGQgc3VwcG9ydCBmb3IgcHJvYmluZyB0aGUgano0Nzgw LW5hbmQgZHJpdmVyIG9uIHRoZSBKWjQ3NDAgU29DCj4gPj4gID4+IGZyb20KPiA+PiAgPj4gIElu Z2VuaWMuCj4gPj4gID4+Cj4gPj4gID4+ICBTaWduZWQtb2ZmLWJ5OiBQYXVsIENlcmN1ZWlsIDxw YXVsQGNyYXBvdWlsbG91Lm5ldD4KPiA+PiAgPj4gIC0tLQo+ID4+ICA+Pgo+ID4+ICA+PiAgQ2hh bmdlczoKPiA+PiAgPj4KPiA+PiAgPj4gIHYyOiAtIEFkZCBzdXBwb3J0IGZvciB0aGUgSlo0NzQw IGFuZCBub3QgdGhlIEpaNDcyNUI6IHRoZXkgICAKPiA+PiBiZWhhdmUgIAo+ID4+ICA+PiB0aGUK PiA+PiAgPj4gICAgICAgIHNhbWUsIGFuZCBKWjQ3NDAgaXMgZnVsbHkgdXBzdHJlYW0gd2hpbGUg Slo0NzI1QiBpcyBub3QuICAgCj4gPj4gVGhlICAKPiA+PiAgPj4gICAgICAgIEpaNDcyNUIgZGV2 aWNldHJlZSB3aWxsIHRoZW4gc2ltcGx5IHVzZSB0aGUKPiA+PiAgPj4gImluZ2VuaWMsano0NzQw LW5hbmQiCj4gPj4gID4+ICAgICAgICBjb21wYXRpYmxlIHN0cmluZy4KPiA+PiAgPj4gICAgICAt IEZpeCB0aGUgbnVtYmVyIG9mIGJ5dGVzIGZvciB0aGUgRUNDIHdoZW4gdGhlIEVDQyBzdHJlbmd0 aCAgIAo+ID4+IGlzICAKPiA+PiAgPj4gNC4KPiA+PiAgPj4gICAgICAgIFRoaXMgaXMgbmVlZGVk IGZvciB0aGUgSlo0NzQwLCB3aGljaCB1c2VzIFJlZWQtU29sb21vbgo+ID4+ICA+PiBpbnN0ZWFk IG9mCj4gPj4gID4+ICAgICAgICBCQ0guCj4gPj4gID4+Cj4gPj4gID4+ICAgZHJpdmVycy9tdGQv bmFuZC9yYXcvaW5nZW5pYy9qejQ3ODBfbmFuZC5jIHwgNDgKPiA+PiAgPj4gKysrKysrKysrKysr KysrKystLS0tLSAgCj4gPj4gID4KPiA+PiAgPiBJZiB3ZSdyZSBnb2luZyB0byBtYWtlIHRoZSBk cml2ZXIgY29tcGF0aWJsZSB3aXRoIGp6NDc0MCBhbmQgICAKPiA+PiBqejQ3MjViICAKPiA+PiAg PiBtYXliZSB3ZSBzaG91bGQgcmVuYW1lIHRoZSBzb3VyY2UgZmlsZXMgano0N3h4X3tuYW5kLGJj aH0ue2MsaH0uICAKPiA+PiAKPiA+PiAgSSBkb24ndCBrbm93IGFib3V0IHRoYXQuIEFkZGluZyBz dXBwb3J0IGZvciBuZXcgaGFyZHdhcmUgaXNuJ3QgYSAKPiA+PiBnb29kCj4gPj4gIHJlYXNvbiB0 bwo+ID4+ICByZW5hbWUgdGhlIGRyaXZlciwgb3Igc28gSSd2ZSBiZWVuIHRvbGQgYXJvdW5kIGhl cmUsIGFzIHlvdSB0aGVuIAo+ID4+IG1ha2UKPiA+PiAgaXQgaGFyZGVyCj4gPj4gIHRvIHJldmll dyB0aGUgZ2l0IGhpc3Rvcnkgb2YgdGhlIGRyaXZlci4gIAo+ID4gCj4gPiBZb3UgYWxyZWFkeSBt b3ZlIGZpbGVzIHRvIGEgc3ViLWRpcmVjdG9yeSBzbyB0aGF0IGRvZXNuJ3QgbWFrZSBhIGh1Z2UK PiA+IGRpZmZlcmVuY2UsIGhpc3Rvcnkgd2lsbCBiZSBoYXJkIHRvIGZvbGxvdyBiZWNhdXNlIG9m IHRoaXMgbW92ZSAKPiA+IGFueXdheS4gIAo+IAo+IFllcywgYnV0IGlmIEkgbWVyZ2UgdGhlICpf YmNoLmMgZmlsZXMgdG9nZXRoZXIsIGFuZCBldmVudHVhbGx5IGRyb3AKPiBqejQ3NDAtbmFuZC5j LCBkb2VzIGl0IHN0aWxsIG1ha2Ugc2Vuc2UgdG8gbW92ZSB0byBhIHN1Yi1kaXJlY3Rvcnk/Cj4g CgpTdGlsbCBwcmVmZXIgdG8gbWFrZSB0aGluZ3MgZXhwbGljaXQgb3ZlciBwcmVzZXJ2aW5nIGZp bGUgbmFtZXMgdG8KbWFrZSBnaXQgbG9nIDxwYXRoPiBoaXN0b3J5IGxpbmVhci4gQW5kIGFueXdh eSwgaG93IGhhcmQgaXMgaXQgdG8gZmlndXJlCm91dCB0aGF0IHRoZSBsYXN0IGNvbW1pdCBpbiBn aXQgbG9nIGRyaXZlcnMvbXRkL25hbmQvcmF3Lzxkcml2ZXI+LmMgaXMKbW92aW5nIHRoZSBmaWxl ICh0aGVyZSBtaWdodCBldmVuIGJlIGFuIG9wdGlvbiBmb3IgdGhhdCk/CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1 c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtbXRkLwo=