From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=R/KS=QK=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,
	URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A7BA1C169C4
	for <netdev@archiver.kernel.org>; Sun,  3 Feb 2019 19:56:49 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 6F39A21773
	for <netdev@archiver.kernel.org>; Sun,  3 Feb 2019 19:56:49 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4lX07vln"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727321AbfBCT4r (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 3 Feb 2019 14:56:47 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:37385 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726637AbfBCT4r (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 3 Feb 2019 14:56:47 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=yLbephGMrQcOGLJW/DyEitt1lLJXFRYSlNNYduzH8dk=; b=4lX07vlnEB/IRCHia1Q/KbbAia
        P+uT8G5sWpFRQXvhd8T99DeZ824IV+rf+kcpaGSAlokw9vxw6WuTYYE+ABqA4yhHm3KOxZ5K+VYhB
        6LIv+A9ZVZDH1MxSMVI2sPD0JLYqgNjoBwsGVITBAmwVys4Yeyox3lGWOmU06+HHXvI0=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gqNsi-00086D-Lt; Sun, 03 Feb 2019 20:56:44 +0100
Date:   Sun, 3 Feb 2019 20:56:44 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/4 net-next] net: phy: aquantia: replace magic numbers
 with constants
Message-ID: <20190203195644.GG27045@lunn.ch>
References: <08812313-471b-79c2-f667-bace78acf0fe@gmail.com>
 <12255e2f-24ca-6e94-f7d0-25ba4dfa216f@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12255e2f-24ca-6e94-f7d0-25ba4dfa216f@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sun, Feb 03, 2019 at 08:35:54PM +0100, Heiner Kallweit wrote:
> Replace magic numbers with proper constants. The original patch is
> from Andrew, I extended / adjusted certain parts:
> - Use decimal bit numbers. The datasheet uses hex bit numbers 0 .. F.
> - Order defines from highest to lowest bit numbers
> - correct some typos
> - add constant MDIO_AN_TX_VEND_INT_MASK2_LINK
> - Remove few functional improvements from the patch, they will come as
>   a separate patch.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew