diff for duplicates of <20190204074820.GC2581@kadam> diff --git a/a/1.txt b/N1/1.txt index fdbc918..2205e17 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,7 +8,8 @@ On Sun, Feb 03, 2019 at 02:29:04PM +0300, Dan Carpenter wrote: > > unsigned int div = dt2811_clk_dividers[_div]; > > unsigned int mult = dt2811_clk_multipliers[_mult]; > > - unsigned long long divider = div * mult; -> > + unsigned long long divider > > + (unsigned long long)div * mult; +> > + unsigned long long divider = +> > + (unsigned long long)div * mult; > > The max "div" can be is 12. The max "mult" can be is 10,000,000. So > this is a false positive because there is no overflow. The code is not diff --git a/a/content_digest b/N1/content_digest index 50aac36..0df7676 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020190203112904.GA2563@kadam\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] staging: comedi: dt2811: fix integer overflow in multiply\0" - "Date\0Mon, 04 Feb 2019 07:48:20 +0000\0" + "Date\0Mon, 4 Feb 2019 10:48:20 +0300\0" "To\0Colin King <colin.king@canonical.com>\0" "Cc\0Ian Abbott <abbotti@mev.co.uk>" H Hartley Sweeten <hsweeten@visionengravers.com> @@ -22,7 +22,8 @@ "> > \t\t\tunsigned int div = dt2811_clk_dividers[_div];\n" "> > \t\t\tunsigned int mult = dt2811_clk_multipliers[_mult];\n" "> > -\t\t\tunsigned long long divider = div * mult;\n" - "> > +\t\t\tunsigned long long divider > > +\t\t\t\t(unsigned long long)div * mult;\n" + "> > +\t\t\tunsigned long long divider =\n" + "> > +\t\t\t\t(unsigned long long)div * mult;\n" "> \n" "> The max \"div\" can be is 12. The max \"mult\" can be is 10,000,000. So\n" "> this is a false positive because there is no overflow. The code is not\n" @@ -34,4 +35,4 @@ "regards,\n" dan carpenter -e4fa5197b66569bb8bc9c864d80f06146d4b7a342dd3e0d85e3786483b8d940a +cf46c33dc3190fd23b71cbb96d7a529898c5b7d96b45dd0453d3edc70f3b98c0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.