From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk, martin.petersen@oracle.com, ooo@electrozaur.com
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Benjamin Block <bblock@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] block: remove req->special
Date: Mon, 4 Feb 2019 09:01:36 +0100 [thread overview]
Message-ID: <20190204080136.GA5582@lst.de> (raw)
In-Reply-To: <20190201075557.9249-8-hch@lst.de>
FYI, this needs the following fold, as Bart added another reference
to ->special past the branch point for my tree:
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 4fbb8310e268..a1e43e77ceef 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1171,8 +1171,6 @@ static blk_status_t sd_setup_read_write_cmnd(struct scsi_cmnd *cmd)
if (ret != BLK_STS_OK)
return ret;
- WARN_ON_ONCE(cmd != rq->special);
-
if (!scsi_device_online(sdp) || sdp->changed) {
scmd_printk(KERN_ERR, cmd, "device offline or changed\n");
return BLK_STS_IOERR;
next prev parent reply other threads:[~2019-02-04 8:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 7:55 remove exofs, the T10 OSD code and block/scsi bidi support V4 Christoph Hellwig
2019-02-01 7:55 ` [PATCH 1/8] bsg: refactor bsg_ioctl Christoph Hellwig
2019-02-01 7:55 ` [PATCH 2/8] bsg-lib: handle bidi requests without block layer help Christoph Hellwig
2019-02-01 7:55 ` [PATCH 3/8] fs: remove exofs Christoph Hellwig
2019-02-01 7:55 ` [PATCH 4/8] scsi: remove the SCSI OSD library Christoph Hellwig
2019-02-01 7:55 ` [PATCH 5/8] scsi: remove bidirectional command support Christoph Hellwig
2019-02-01 7:55 ` [PATCH 6/8] scsi: stop setting up request->special Christoph Hellwig
2019-02-01 7:55 ` [PATCH 7/8] block: remove req->special Christoph Hellwig
2019-02-04 8:01 ` Christoph Hellwig [this message]
2019-02-01 7:55 ` [PATCH 8/8] block: remove bidi support Christoph Hellwig
2019-02-01 15:13 ` remove exofs, the T10 OSD code and block/scsi bidi support V4 Jens Axboe
2019-02-04 20:31 ` Boaz Harrosh
2019-02-05 17:16 ` Christoph Hellwig
2019-02-05 3:47 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2018-11-11 13:32 remove exofs, the T10 OSD code and block/scsi bidi support V3 Christoph Hellwig
2018-11-11 13:32 ` [PATCH 7/8] block: remove req->special Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204080136.GA5582@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bblock@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ooo@electrozaur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.