From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,2/6] usb:common Separated decoding functions from dwc3 driver. From: Greg Kroah-Hartman Message-Id: <20190204114502.GA28608@kroah.com> Date: Mon, 4 Feb 2019 12:45:02 +0100 To: Pawel Laszczak Cc: devicetree@vger.kernel.org, mark.rutland@arm.com, linux-usb@vger.kernel.org, hdegoede@redhat.com, heikki.krogerus@linux.intel.com, andy.shevchenko@gmail.com, robh+dt@kernel.org, rogerq@ti.com, linux-kernel@vger.kernel.org, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com, kurahul@cadence.com List-ID: T24gVGh1LCBKYW4gMzEsIDIwMTkgYXQgMTE6NTI6MjlBTSArMDAwMCwgUGF3ZWwgTGFzemN6YWsg d3JvdGU6Cj4gUGF0Y2ggbW92ZXMgc29tZSBkZWNvZGluZyBmdW5jdGlvbnMgZnJvbSBkcml2ZXIv dXNiL2R3YzMvZGVidWcuaCBkcml2ZXIKPiB0byBkcml2ZXIvdXNiL2NvbW1vbi9kZWJ1Zy5jIGZp bGUuIFRoZXNlIG1vdmVkIGZ1bmN0aW9ucyBpbmNsdWRlOgo+ICAgICBkd2MzX2RlY29kZV9nZXRf c3RhdHVzCj4gICAgIGR3YzNfZGVjb2RlX3NldF9jbGVhcl9mZWF0dXJlCj4gICAgIGR3YzNfZGVj b2RlX3NldF9hZGRyZXNzCj4gICAgIGR3YzNfZGVjb2RlX2dldF9zZXRfZGVzY3JpcHRvcgo+ICAg ICBkd2MzX2RlY29kZV9nZXRfY29uZmlndXJhdGlvbgo+ICAgICBkd2MzX2RlY29kZV9zZXRfY29u ZmlndXJhdGlvbgo+ICAgICBkd2MzX2RlY29kZV9nZXRfaW50Zgo+ICAgICBkd2MzX2RlY29kZV9z ZXRfaW50Zgo+ICAgICBkd2MzX2RlY29kZV9zeW5jaF9mcmFtZQo+ICAgICBkd2MzX2RlY29kZV9z ZXRfc2VsCj4gICAgIGR3YzNfZGVjb2RlX3NldF9pc29jaF9kZWxheQo+ICAgICBkd2MzX2RlY29k ZV9jdHJsCj4gCj4gVGhlc2UgZnVuY3Rpb25zIGFyZSB1c2VkIGFsc28gaW4gaW5yb2R1Y2VkIGNk bnMzIGRyaXZlci4KPiAKPiBBbGwgZnVuY3Rpb25zIHByZWZpeGVzIHdlcmUgY2hhbmdlZCBmcm9t IGR3YzMgdG8gdXNiLgoKSWNrLCB3aHk/Cgo+IEFsc28sIGZ1bmN0aW9uJ3MgcGFyYW1ldGVycyBo YXMgYmVlbiBleHRlbmRlZCBhY2NvcmRpbmcgdG8gdGhlIG5hbWUKPiBvZiBmaWVsZHMgaW4gc3Rh bmRhcmQgU0VUVVAgcGFja2V0Lgo+IEFkZGl0aW9uYWxseSwgcGF0Y2ggYWRkcyB1c2JfZGVjb2Rl X2N0cmwgZnVuY3Rpb24gdG8KPiBpbmNsdWRlL2xpbnV4L3VzYi9jaDkuaCBmaWxlLgoKV2h5IGNo OS5oPyAgSXQncyBub3Qgc29tZXRoaW5nIHRoYXQgaXMgc3BlY2lmaWVkIGluIHRoZSBzcGVjLCBp dCdzIGEKdXNiLXNwZWNpZmljIHRoaW5nIDopCgpBbHNvLCB0aGUgYXBpIGZvciB0aGF0IGZ1bmN0 aW9uIGlzIG5vdCBvay4gIElmIHlvdSBhcmUgZ29pbmcgdG8gbWFrZQp0aGlzIHNvbWV0aGluZyB0 aGF0IHRoZSB3aG9sZSBrZXJuZWwgY2FuIGNhbGwsIHlvdSBoYXZlIHRvIGZpeCBpdCB1cDoKCj4g Ky8qKgo+ICsgKiB1c2JfZGVjb2RlX2N0cmwgLSBSZXR1cm5zIGh1bWFuIHJlYWRhYmxlIHJlcHJl c2VudGF0aW9uIG9mIGNvbnRyb2wgcmVxdWVzdC4KPiArICogQHN0cjogYnVmZmVyIHRvIHJldHVy biBhIGh1bWFuLXJlYWRhYmxlIHJlcHJlc2VudGF0aW9uIG9mIGNvbnRyb2wgcmVxdWVzdC4KPiAr ICogICAgICAgVGhpcyBidWZmZXIgc2hvdWxkIGhhdmUgYWJvdXQgMjAwIGJ5dGVzLgoKImFib3V0 IDIwMCBieXRlcyIgaXMgbm90IHZlcnkgc3BlY2lmaWMuCgpQYXNzIGluIHRoZSBsZW5ndGggc28g d2Uga25vdyB3ZSBkb24ndCBvdmVyZmxvdyBpdC4KCj4gKyAqIEBiUmVxdWVzdFR5cGU6IG1hdGNo ZXMgdGhlIFVTQiBibVJlcXVlc3RUeXBlIGZpZWxkCj4gKyAqIEBiUmVxdWVzdDogbWF0Y2hlcyB0 aGUgVVNCIGJSZXF1ZXN0IGZpZWxkCj4gKyAqIEB3VmFsdWU6IG1hdGNoZXMgdGhlIFVTQiB3VmFs dWUgZmllbGQgKENQVSBieXRlIG9yZGVyKQo+ICsgKiBAd0luZGV4OiBtYXRjaGVzIHRoZSBVU0Ig d0luZGV4IGZpZWxkIChDUFUgYnl0ZSBvcmRlcikKPiArICogQHdMZW5ndGg6IG1hdGNoZXMgdGhl IFVTQiB3TGVuZ3RoIGZpZWxkIChDUFUgYnl0ZSBvcmRlcikKPiArICoKPiArICogRnVuY3Rpb24g cmV0dXJucyBkZWNvZGVkLCBmb3JtYXR0ZWQgYW5kIGh1bWFuLXJlYWRhYmxlIGRlc2NyaXB0aW9u IG9mCj4gKyAqIGNvbnRyb2wgcmVxdWVzdCBwYWNrZXQuCj4gKyAqCj4gKyAqIEltcG9ydGFudDog d1ZhbHVlLCB3SW5kZXgsIHdMZW5ndGggcGFyYW1ldGVycyBiZWZvcmUgaW52b2tpbmcgdGhpcyBm dW5jdGlvbgo+ICsgKiBzaG91bGQgYmUgcHJvY2Vzc2VkIGJ5IGxlMTZfdG9fY3B1IG1hY3JvLgo+ ICsgKi8KPiArY29uc3QgY2hhciAqdXNiX2RlY29kZV9jdHJsKGNoYXIgKnN0ciwgX191OCBiUmVx dWVzdFR5cGUsIF9fdTggYlJlcXVlc3QsCj4gKwkJCSAgICBfX3UxNiB3VmFsdWUsICBfX3UxNiB3 SW5kZXgsIF9fdTE2IHdMZW5ndGgpOwoKV2h5IGFyZSB5b3UgcmV0dXJuaW5nIGEgdmFsdWUsIGlz bid0IHRoZSBkYXRhIHN0b3JlZCBpbiBzdHI/ICBXaHkgbm90Cmp1c3QgcmV0dXJuIGFuIGludCBz YXlpbmcgaWYgdGhlIGNhbGwgc3VjY2VlZGVkIG9yIG5vdD8KCnRoYW5rcywKCmdyZWcgay1oCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver. Date: Mon, 4 Feb 2019 12:45:02 +0100 Message-ID: <20190204114502.GA28608@kroah.com> References: <1548935553-452-1-git-send-email-pawell@cadence.com> <1548935553-452-3-git-send-email-pawell@cadence.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1548935553-452-3-git-send-email-pawell@cadence.com> Sender: linux-kernel-owner@vger.kernel.org To: Pawel Laszczak Cc: devicetree@vger.kernel.org, mark.rutland@arm.com, linux-usb@vger.kernel.org, hdegoede@redhat.com, heikki.krogerus@linux.intel.com, andy.shevchenko@gmail.com, robh+dt@kernel.org, rogerq@ti.com, linux-kernel@vger.kernel.org, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com, kurahul@cadence.com List-Id: devicetree@vger.kernel.org On Thu, Jan 31, 2019 at 11:52:29AM +0000, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_address > dwc3_decode_get_set_descriptor > dwc3_decode_get_configuration > dwc3_decode_set_configuration > dwc3_decode_get_intf > dwc3_decode_set_intf > dwc3_decode_synch_frame > dwc3_decode_set_sel > dwc3_decode_set_isoch_delay > dwc3_decode_ctrl > > These functions are used also in inroduced cdns3 driver. > > All functions prefixes were changed from dwc3 to usb. Ick, why? > Also, function's parameters has been extended according to the name > of fields in standard SETUP packet. > Additionally, patch adds usb_decode_ctrl function to > include/linux/usb/ch9.h file. Why ch9.h? It's not something that is specified in the spec, it's a usb-specific thing :) Also, the api for that function is not ok. If you are going to make this something that the whole kernel can call, you have to fix it up: > +/** > + * usb_decode_ctrl - Returns human readable representation of control request. > + * @str: buffer to return a human-readable representation of control request. > + * This buffer should have about 200 bytes. "about 200 bytes" is not very specific. Pass in the length so we know we don't overflow it. > + * @bRequestType: matches the USB bmRequestType field > + * @bRequest: matches the USB bRequest field > + * @wValue: matches the USB wValue field (CPU byte order) > + * @wIndex: matches the USB wIndex field (CPU byte order) > + * @wLength: matches the USB wLength field (CPU byte order) > + * > + * Function returns decoded, formatted and human-readable description of > + * control request packet. > + * > + * Important: wValue, wIndex, wLength parameters before invoking this function > + * should be processed by le16_to_cpu macro. > + */ > +const char *usb_decode_ctrl(char *str, __u8 bRequestType, __u8 bRequest, > + __u16 wValue, __u16 wIndex, __u16 wLength); Why are you returning a value, isn't the data stored in str? Why not just return an int saying if the call succeeded or not? thanks, greg k-h