All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH 8/8] drm/amdgpu: drop the huge page flag
Date: Mon,  4 Feb 2019 13:42:56 +0100	[thread overview]
Message-ID: <20190204124256.1765-8-christian.koenig@amd.com> (raw)
In-Reply-To: <20190204124256.1765-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>

Not needed any more since we now free PDs/PTs on demand.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 14 +-------------
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h |  1 -
 2 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index a3dd2b397299..8f4fd8a7fb96 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1383,10 +1383,6 @@ static void amdgpu_vm_update_pde(struct amdgpu_pte_update_params *params,
 	uint64_t pde, pt, flags;
 	unsigned level;
 
-	/* Don't update huge pages here */
-	if (entry->huge)
-		return;
-
 	for (level = 0, pbo = bo->parent; pbo; ++level)
 		pbo = pbo->parent;
 
@@ -1649,13 +1645,6 @@ static int amdgpu_vm_update_ptes(struct amdgpu_pte_update_params *params,
 			continue;
 		}
 
-		/* If it isn't already handled it can't be a huge page */
-		if (cursor.entry->huge) {
-			/* Add the entry to the relocated list to update it. */
-			cursor.entry->huge = false;
-			amdgpu_vm_bo_relocated(&cursor.entry->base);
-		}
-
 		shift = amdgpu_vm_level_shift(adev, cursor.level);
 		parent_shift = amdgpu_vm_level_shift(adev, cursor.level - 1);
 		if (adev->asic_type < CHIP_VEGA10) {
@@ -1714,9 +1703,8 @@ static int amdgpu_vm_update_ptes(struct amdgpu_pte_update_params *params,
 		} while (frag_start < entry_end);
 
 		if (amdgpu_vm_pt_descendant(adev, &cursor)) {
-			/* Mark all child entries as huge */
+			/* Free all child entries */
 			while (cursor.pfn < frag_start) {
-				cursor.entry->huge = true;
 				amdgpu_vm_free_pts(adev, params->vm, &cursor);
 				amdgpu_vm_pt_next(adev, &cursor);
 			}
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
index 116605c038d2..3c6537ef659c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
@@ -140,7 +140,6 @@ struct amdgpu_vm_bo_base {
 
 struct amdgpu_vm_pt {
 	struct amdgpu_vm_bo_base	base;
-	bool				huge;
 
 	/* array of page tables, one for each directory entry */
 	struct amdgpu_vm_pt		*entries;
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-02-04 12:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 12:42 [PATCH 1/8] drm/amdgpu: fix waiting for BO moves with CPU based PD/PT updates Christian König
     [not found] ` <20190204124256.1765-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2019-02-04 12:42   ` [PATCH 2/8] drm/amdgpu: cleanup VM dw estimation a bit Christian König
     [not found]     ` <20190204124256.1765-2-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2019-02-04 20:20       ` Kuehling, Felix
2019-02-04 12:42   ` [PATCH 3/8] drm/amdgpu: clear PDs/PTs only after initializing them Christian König
2019-02-04 12:42   ` [PATCH 4/8] drm/amdgpu: rework shadow handling during PD clear Christian König
2019-02-04 12:42   ` [PATCH 5/8] drm/amdgpu: let amdgpu_vm_clear_bo figure out ats status Christian König
2019-02-04 12:42   ` [PATCH 6/8] drm/amdgpu: allocate VM PDs/PTs on demand Christian König
     [not found]     ` <20190204124256.1765-6-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2019-02-04 20:17       ` Kuehling, Felix
     [not found]         ` <d9b5d989-cf1f-03ec-70d4-0baa8dc451c5-5C7GfCeVMHo@public.gmane.org>
2019-02-05  0:33           ` Kuehling, Felix
     [not found]             ` <976d2bd1-34b9-405f-06a8-5dbc8c481699-5C7GfCeVMHo@public.gmane.org>
2019-02-05 11:40               ` Christian König
2019-02-05 11:37           ` Christian König
     [not found]             ` <d2b729fb-e2b0-1b46-3709-e50b4e2ec7c7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-02-05 15:20               ` Kuehling, Felix
     [not found]                 ` <DM5PR12MB1707CB26A54B5AF86FB1027C926E0-2J9CzHegvk9TCtO+SvGBKwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-02-05 15:39                   ` Christian König
     [not found]                     ` <2feffc18-277e-b3b9-8991-2afae9558bdf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-02-05 15:49                       ` Kuehling, Felix
     [not found]                         ` <DM5PR12MB1707DABD8376BC395C0558D4926E0-2J9CzHegvk9TCtO+SvGBKwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-02-05 16:00                           ` Koenig, Christian
     [not found]                             ` <7bf939a3-cfe6-9559-8479-4c69368d369a-5C7GfCeVMHo@public.gmane.org>
2019-02-05 23:51                               ` Kuehling, Felix
     [not found]                                 ` <1a54fcea-e90b-159d-23b8-239e0d66a45d-5C7GfCeVMHo@public.gmane.org>
2019-02-06  9:06                                   ` Koenig, Christian
     [not found]                                     ` <10356d12-8a73-cc2d-359c-7e10275c050e-5C7GfCeVMHo@public.gmane.org>
2019-02-07 19:50                                       ` Kuehling, Felix
2019-02-12 15:26       ` Kuehling, Felix
2019-02-04 12:42   ` [PATCH 7/8] drm/amdgpu: free " Christian König
2019-02-04 12:42   ` Christian König [this message]
2019-02-04 20:19   ` [PATCH 1/8] drm/amdgpu: fix waiting for BO moves with CPU based PD/PT updates Kuehling, Felix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204124256.1765-8-christian.koenig@amd.com \
    --to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.