From: Christoph Hellwig <hch@lst.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>, Zachary Hays <zhays@lexmark.com>,
Jens Axboe <axboe@kernel.dk>,
Adrian Hunter <adrian.hunter@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>
Subject: Re: [PATCH] mmc: block: handle complete_work on the system_highpri workqueue
Date: Mon, 4 Feb 2019 15:28:51 +0100 [thread overview]
Message-ID: <20190204142851.GA12581@lst.de> (raw)
In-Reply-To: <CAPDyKFoB+BV-ea4ctYixoJJvY=5f-NMm29iSTRTo5xbzKaPLgg@mail.gmail.com>
On Mon, Feb 04, 2019 at 01:30:37PM +0100, Ulf Hansson wrote:
> Although, I am not sure why having our own mmc workqueue, would fix
> this problem. Couldn't we hit the same kind of deadlock anyways you
> think?
Maybe I misunderstood the issue. I thought the problem was that
the one rescuer kblockd thread is executing some block submission
work item, which is blocking because it waits for something in
completion handling.
Now with another workqueue we have two rescuer threads, one that
exectures all completions, which shouldn't depend on items in
the submission queue, and another one executing the block layer
submission, which might or might not depend on something happening
to another request in the completion workqueue.
next prev parent reply other threads:[~2019-02-04 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1548965800-3080-1-git-send-email-zhays@lexmark.com>
2019-02-04 6:24 ` [PATCH] mmc: block: handle complete_work on the system_highpri workqueue Ulf Hansson
2019-02-04 8:02 ` Adrian Hunter
2019-02-04 14:30 ` Christoph Hellwig
2019-02-04 8:25 ` Christoph Hellwig
2019-02-04 12:30 ` Ulf Hansson
2019-02-04 14:28 ` Christoph Hellwig [this message]
2019-02-05 14:41 ` Zak Hays
2019-02-04 12:52 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204142851.GA12581@lst.de \
--to=hch@lst.de \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zhays@lexmark.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.