From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: dsahern@gmail.com, stephen@networkplumber.org,
netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH iproute2-next v3] devlink: add info subcommand
Date: Mon, 4 Feb 2019 15:49:48 +0100 [thread overview]
Message-ID: <20190204144948.GA2118@nanopsycho> (raw)
In-Reply-To: <20190204144343.5639-1-jakub.kicinski@netronome.com>
Mon, Feb 04, 2019 at 03:43:43PM CET, jakub.kicinski@netronome.com wrote:
>Add support for reading the device serial number, driver name
>and various versions. Example:
>
>$ devlink dev info pci/0000:82:00.0
>pci/0000:82:00.0:
> driver nfp
> serial_number 16240145
> versions:
> fixed:
> board.id AMDA0081-0001
> board.rev 15
> board.vendor SMA
> board.model hydrogen
> running:
> fw.bundle_id -
Wait, what are these "-" ?
That looks a bit scarry.
> fw.mgmt 010181.010181.0101d4
> fw.cpld 0x1030000
> fw.app abm-d372b6
> fw.undi 0.0.0
> fw.ncsi -
> chip.init AMDA-0081-0001 20160318164536
> stored:
> fw.bundle_id -
> fw.mgmt 010181.010181.0101d4
> fw.cpld 0xfeedbeef
> fw.app -
> fw.undi 0.0.0
> fw.ncsi -
> chip.init AMDA-0081-0001 20160318164536
>
>$ devlink -jp dev info pci/0000:82:00.0
>{
> "info": {
> "pci/0000:82:00.0": {
>
> "driver": "nfp",
> "serial_number": "16240145",
> "versions": {
> "fixed": {
> "board.id": "AMDA0081-0001",
> "board.rev": "15",
> "board.vendor": "SMA",
> "board.model": "hydrogen"
> },
> "running": {
> "fw.bundle_id": "-",
> "fw.mgmt": "010181.010181.0101d4",
> "fw.cpld": "0x1030000",
> "fw.app": "abm-d372b6",
> "fw.undi": "0.0.0",
> "fw.ncsi": "-",
> "chip.init": "AMDA-0081-0001 20160318164536"
> },
> "stored": {
> "fw.bundle_id": "-",
> "fw.mgmt": "010181.010181.0101d4",
> "fw.cpld": "0xfeedbeef",
> "fw.app": "-",
> "fw.undi": "0.0.0",
> "fw.ncsi": "-",
> "chip.init": "AMDA-0081-0001 20160318164536"
> }
> }
> }
> }
>}
>
>v3:
> - show up-to-date output in the commit message.
>v2 (Jiri):
> - remove filtering;
> - add example in the commit message.
>RFCv2:
> - make info subcommand of dev.
>
>Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
[...]
next prev parent reply other threads:[~2019-02-04 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 14:43 [PATCH iproute2-next v3] devlink: add info subcommand Jakub Kicinski
2019-02-04 14:49 ` Jiri Pirko [this message]
2019-02-04 15:13 ` Jakub Kicinski
2019-02-04 15:24 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204144948.GA2118@nanopsycho \
--to=jiri@resnulli.us \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.