From: Vivek Goyal <vgoyal@redhat.com>
To: fstests <fstests@vger.kernel.org>, linux-unionfs@vger.kernel.org
Cc: Amir Goldstein <amir73il@gmail.com>, Miklos Szeredi <miklos@szeredi.hu>
Subject: [PATCH] xfstest, overlayfs: Use falloc to make sure a meta copy file got copied up
Date: Mon, 4 Feb 2019 13:34:54 -0500 [thread overview]
Message-ID: <20190204183454.GA19549@redhat.com> (raw)
Overlayfs might copy up data of file on first write of file (and
not necessarily upon open of file). So call falloc file opened
with O_RDWR and after that data must have been copied up.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
tests/overlay/060 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: xfstests-dev/tests/overlay/060
===================================================================
--- xfstests-dev.orig/tests/overlay/060 2018-08-27 11:21:51.811847671 -0400
+++ xfstests-dev/tests/overlay/060 2019-02-04 11:28:09.023718690 -0500
@@ -170,7 +170,7 @@ test_common()
# Trigger data copy up and check absence of metacopy xattr.
mount_overlay $_lowerdir
- $XFS_IO_PROG -c "open -a $SCRATCH_MNT/$_target"
+ $XFS_IO_PROG -c "falloc 0 1" $SCRATCH_MNT/$_target >> $seqres.full
echo "check properties of data copied up file"
check_file_size_contents $SCRATCH_MNT/$_target $_size "$_data"
umount_overlay
next reply other threads:[~2019-02-04 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 18:34 Vivek Goyal [this message]
2019-02-04 20:04 ` [PATCH] xfstest, overlayfs: Use falloc to make sure a meta copy file got copied up Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204183454.GA19549@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.