From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ZPcH=QL=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD03C282C4
	for <netdev@archiver.kernel.org>; Mon,  4 Feb 2019 22:23:54 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id C14AC20823
	for <netdev@archiver.kernel.org>; Mon,  4 Feb 2019 22:23:53 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="LbB7DuYV"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727547AbfBDWXw (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 4 Feb 2019 17:23:52 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:38623 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727202AbfBDWXw (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 4 Feb 2019 17:23:52 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=xJO/9tx1jZ8CLUPGWPv98LsViRtoocEmpy6BwOJpajM=; b=LbB7DuYVoWNE0zNpBH9pyKi3G6
        YeminFkwaUoyEIXXPy6izOAPi+rwYDhRIlWO0z8fDVclg19eLw6ZNK6eCpslEqGgh2ybx6FyZS/UR
        0+wUKRFhcKavkbWSzsjDztsBIkT/3sS1vu4ej/iAvH07X7aF664ZaIymazyO20vMB2Eg=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gqmea-0001ZG-5s; Mon, 04 Feb 2019 23:23:48 +0100
Date:   Mon, 4 Feb 2019 23:23:48 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/3 net-next] net: phy: aquantia: improve setting speed
 and duplex in aqr_read_status
Message-ID: <20190204222348.GD3397@lunn.ch>
References: <8e41695d-a23e-adad-ae3d-66a46d1ab077@gmail.com>
 <d1f1160c-ebea-0e7b-4d73-a27ebbd5c199@gmail.com>
 <20190204212832.GB3397@lunn.ch>
 <d6ceeb7c-7502-7332-ce6e-b95b4d9b2be1@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d6ceeb7c-7502-7332-ce6e-b95b4d9b2be1@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> I'd like to use standard registers wherever possible. This patch is
> meant as a quick win to improve what we do already in aqr_read_status.
> Once we have a generic c45 read_status function we should switch to it.

Hi Heiner

I don't see much point in adding code which we know we are soon going
to replace. Just replace it.

> However I assume that information like interface mode we still have
> to read from vendor registers.

For the Aquantia PHY, yes. It appears the Marvell PHY does not have
any registers which indicate this, so it uses heuristics based on the
link speed.

    Andrew