From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/bochs: fix bochs_gem_prime_mmap Date: Tue, 5 Feb 2019 10:01:28 +0100 Message-ID: <20190205090128.GA3271@phenom.ffwll.local> References: <20190204183858.8976-1-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6129F6E66A for ; Tue, 5 Feb 2019 09:01:32 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id h15so2204871edb.4 for ; Tue, 05 Feb 2019 01:01:32 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190204183858.8976-1-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBGZWIgMDQsIDIwMTkgYXQgMDc6Mzg6NThQTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiB0dG1fZmJkZXZfbW1hcCgpIGp1c3QgZG9lc24ndCB3b3JrLiAgSXQgYXBwZWFycyB0 byB3b3JrIGZpbmUsIG1tYXAoKQo+IHJldHVybnMgc3VjY2VzcywgYnV0IGFueSBhdHRlbXB0IHRv IGFjdHVhbGx5IGFjY2VzcyB0aGUgbWFwcGluZyBjYXVzZXMgYQo+IFNJR0JVUy4KPiAKPiBXZSBj YW4ganVzdCB1c2UgZHJtX2dlbV9wcmltZV9tbWFwKCkgaW5zdGVhZC4gIEFsbW9zdC4gIFdlIGhh dmUgdG8gY29weQo+IG92ZXIgdGhlIHN0YXJ0IG9mZnNldCBmcm9tIHRoZSB0dG1fYnVmZmVyX29i amVjdCB2bV9ub2RlIHRvIHRoZQo+IGRybV9nZW1fb2JqZWN0IHZtX25vZGUgc28gdGhlIG9mZnNl dCBtYXRoIGluIGRybV9nZW1fcHJpbWVfbW1hcCgpIHdvcmtzCj4gY29ycmVjdGx5IGZvciB1cyBl dmVuIHRob3VnaCB3ZSB1c2UgdHRtIHRvIG1hbmFnZSBvdXIgb2JqZWN0cy4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KCldvdWxkIGJlIGtpbmRh IG5lYXQgaWYgd2UgY291bGQgdGVhY2ggdHRtIHRvIG5vdCBoYXZlIGl0J3Mgb3duIHZtYSBub2Rl Ci4uLgoKQW55d2F5LCBsZ3RtLgoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYm9jaHMvYm9jaHNfbW0u YyB8IDMgKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JvY2hzL2JvY2hzX21tLmMgYi9k cml2ZXJzL2dwdS9kcm0vYm9jaHMvYm9jaHNfbW0uYwo+IGluZGV4IDY0MWEzM2YxMzQuLjQ5NDYz MzQ4YTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JvY2hzL2JvY2hzX21tLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vYm9jaHMvYm9jaHNfbW0uYwo+IEBAIC00NDIsNSArNDQyLDYg QEAgaW50IGJvY2hzX2dlbV9wcmltZV9tbWFwKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqLAo+ ICB7Cj4gIAlzdHJ1Y3QgYm9jaHNfYm8gKmJvID0gZ2VtX3RvX2JvY2hzX2JvKG9iaik7Cj4gIAo+ IC0JcmV0dXJuIHR0bV9mYmRldl9tbWFwKHZtYSwgJmJvLT5ibyk7Cj4gKwliby0+Z2VtLnZtYV9u b2RlLnZtX25vZGUuc3RhcnQgPSBiby0+Ym8udm1hX25vZGUudm1fbm9kZS5zdGFydDsKPiArCXJl dHVybiBkcm1fZ2VtX3ByaW1lX21tYXAob2JqLCB2bWEpOwo+ICB9Cj4gLS0gCj4gMi45LjMKPiAK Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpo dHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C644DC282CB for ; Tue, 5 Feb 2019 09:01:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91AF22083B for ; Tue, 5 Feb 2019 09:01:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="kuRqOSgz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728460AbfBEJBd (ORCPT ); Tue, 5 Feb 2019 04:01:33 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:43421 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725898AbfBEJBc (ORCPT ); Tue, 5 Feb 2019 04:01:32 -0500 Received: by mail-ed1-f65.google.com with SMTP id f9so2165642eds.10 for ; Tue, 05 Feb 2019 01:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Zd9NiqnrVtmTS7TeFCzrg9TI+td3l5rl5pIJPtIgm+w=; b=kuRqOSgz0QABVeog67VJ+ENXk1MkXHlJj7+f908nb3re7WtgCqVJYjyGH+AtCiLnfW w03OB9q3Cnd9aKkuEm6TDE5SEYjwZp+HZlDgaslWnOTIN0duEZBtBDIw76JU5+ZAOj/b PWSxoqo8+jgYLleqLyGumCpqb+7Xv/LDU6DiU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=Zd9NiqnrVtmTS7TeFCzrg9TI+td3l5rl5pIJPtIgm+w=; b=ZBNDQeCsDsyB+OV6vS0r2cZHOTJxDR/pgw2AAVPw1AnqcacmXW4e2OPn9ZdMlGhnQi LxXC1o97W/Ywy3v46yeEm+YCteK0Na3Mz9YbiizJZxeSUSGtt4F0/Nt86SLiHO3lGjKw tV/6JdnMphxyabVI6E+3IIghPnIdnDsYsnQU9g6ycTf+8pYBlO6rA5Azwn3dR8a6Nnag IPtra7H0xHZx+76g2IqUPbnDrH1tc/j3f4o3LWBJk1btbr1TroRV1zYZFHSSnEajc7be 7uW3XrvcLmBCVbwXSu0p/q0nOBoO1VEUZ49DShR+cEcJNUdpi+4Sl7Uyk3s9U6GTsOr2 FQ+g== X-Gm-Message-State: AHQUAuaQ+v03HwEnAC81GmjZfissiJwozsZV6KEvvySObIFKlGfJOkoO 6uZinK6vy/ZJlNKvc6AAelH52w== X-Google-Smtp-Source: AHgI3IYQqqMo567bFZQ7+fCbqzPIL70wFACFS4gNBO73qzDrL4MzI8jGkDpYmhWJ1PsJI+k+QhnmiA== X-Received: by 2002:a17:906:66db:: with SMTP id k27mr2716348ejp.50.1549357291015; Tue, 05 Feb 2019 01:01:31 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id p36sm4856982edc.78.2019.02.05.01.01.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 01:01:30 -0800 (PST) Date: Tue, 5 Feb 2019 10:01:28 +0100 From: Daniel Vetter To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, David Airlie , Daniel Vetter , "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" , open list Subject: Re: [PATCH] drm/bochs: fix bochs_gem_prime_mmap Message-ID: <20190205090128.GA3271@phenom.ffwll.local> Mail-Followup-To: Gerd Hoffmann , dri-devel@lists.freedesktop.org, David Airlie , "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" , open list References: <20190204183858.8976-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204183858.8976-1-kraxel@redhat.com> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 04, 2019 at 07:38:58PM +0100, Gerd Hoffmann wrote: > ttm_fbdev_mmap() just doesn't work. It appears to work fine, mmap() > returns success, but any attempt to actually access the mapping causes a > SIGBUS. > > We can just use drm_gem_prime_mmap() instead. Almost. We have to copy > over the start offset from the ttm_buffer_object vm_node to the > drm_gem_object vm_node so the offset math in drm_gem_prime_mmap() works > correctly for us even though we use ttm to manage our objects. > > Signed-off-by: Gerd Hoffmann Would be kinda neat if we could teach ttm to not have it's own vma node ... Anyway, lgtm. Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/bochs/bochs_mm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c > index 641a33f134..49463348a0 100644 > --- a/drivers/gpu/drm/bochs/bochs_mm.c > +++ b/drivers/gpu/drm/bochs/bochs_mm.c > @@ -442,5 +442,6 @@ int bochs_gem_prime_mmap(struct drm_gem_object *obj, > { > struct bochs_bo *bo = gem_to_bochs_bo(obj); > > - return ttm_fbdev_mmap(vma, &bo->bo); > + bo->gem.vma_node.vm_node.start = bo->bo.vma_node.vm_node.start; > + return drm_gem_prime_mmap(obj, vma); > } > -- > 2.9.3 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch