From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Tue, 05 Feb 2019 13:08:18 +0000 Subject: Re: [PATCH 1/3] mtd: rawnand: meson: Fix a limit test in meson_nfc_select_chip() Message-Id: <20190205140818.2de31843@xps13> List-Id: References: <20190201082922.GC8459@kadam> In-Reply-To: <20190201082922.GC8459@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Dan Carpenter Cc: Boris Brezillon , Richard Weinberger , kernel-janitors@vger.kernel.org, Marek Vasut , Liang Yang , linux-mtd@lists.infradead.org, Kevin Hilman , linux-amlogic@lists.infradead.org, Brian Norris , David Woodhouse Hi Dan, Dan Carpenter wrote on Fri, 1 Feb 2019 11:29:22 +0300: > This test is off by one because the > should be >=3D and it's also testing > against the wrong limit. The MAX_CE_NUM is the maximum size that > meson_chip->sels[] is allowed to be but meson_chip->nsels is the actual > size. >=20 > Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND f= lash controller ") > Signed-off-by: Dan Carpenter > --- > drivers/mtd/nand/raw/meson_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/mes= on_nand.c > index e858d58d97b0..94c90be7e1e0 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -225,7 +225,7 @@ static void meson_nfc_select_chip(struct nand_chip *n= and, int chip) > struct meson_nfc *nfc =3D nand_get_controller_data(nand); > int ret, value; > =20 > - if (chip < 0 || WARN_ON_ONCE(chip > MAX_CE_NUM)) > + if (chip < 0 || WARN_ON_ONCE(chip >=3D meson_chip->nsels)) > return; > =20 > nfc->param.chip_select =3D meson_chip->sels[chip] ? NAND_CE1 : NAND_CE0; I am gonna fold this three patches if this is fine for you with the original patch adding the driver which is currently in my next branch. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34936C282CC for ; Tue, 5 Feb 2019 13:08:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9D5120844 for ; Tue, 5 Feb 2019 13:08:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oy8lipZU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9D5120844 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FILEKeVoVONaNHshxJyPXLhLjTNlH+VSwJycO8B5FA0=; b=oy8lipZUgAiZ9k oL8jeM6bzatCcRB8m9M694PWVenCCWoYTlliFhVE0aiCuoYK6UWrAfIXux8vAKWFDxspha6kPpWfJ di7iUPw/qIl4Jxy/Z2f+C1ijnoXSSkh9IiVxLRtpB4AahjCt9l6FgD8MrtFdQGKEkBadGRarwLwjp qEWJIx/Fp2iDMLV16LCJcZjGrIkoylWNnSzCyp3zaQrO4DAzYvJ24UalOOgEdoGaPGXog1iy7UsjG cfVHRCZxDD8iVqMqVagt2qYqI+IJNVi0GcPGnNmivQPg+5RHpWWuUAbWH2l4V5Gzb+6o5+b4i9U5D kStWPDPbIEl2TASLnIeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr0So-00077x-JK; Tue, 05 Feb 2019 13:08:34 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr0Sl-00077N-EL; Tue, 05 Feb 2019 13:08:33 +0000 X-Originating-IP: 90.88.22.177 Received: from xps13 (aaubervilliers-681-1-80-177.w90-88.abo.wanadoo.fr [90.88.22.177]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 5C8F360014; Tue, 5 Feb 2019 13:08:19 +0000 (UTC) Date: Tue, 5 Feb 2019 14:08:18 +0100 From: Miquel Raynal To: Dan Carpenter Subject: Re: [PATCH 1/3] mtd: rawnand: meson: Fix a limit test in meson_nfc_select_chip() Message-ID: <20190205140818.2de31843@xps13> In-Reply-To: <20190201082922.GC8459@kadam> References: <20190201082922.GC8459@kadam> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190205_050831_629335_02632488 X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , kernel-janitors@vger.kernel.org, Marek Vasut , Liang Yang , linux-mtd@lists.infradead.org, Kevin Hilman , linux-amlogic@lists.infradead.org, Brian Norris , David Woodhouse Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgRGFuLAoKRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPiB3cm90ZSBv biBGcmksIDEgRmViIDIwMTkKMTE6Mjk6MjIgKzAzMDA6Cgo+IFRoaXMgdGVzdCBpcyBvZmYgYnkg b25lIGJlY2F1c2UgdGhlID4gc2hvdWxkIGJlID49IGFuZCBpdCdzIGFsc28gdGVzdGluZwo+IGFn YWluc3QgdGhlIHdyb25nIGxpbWl0LiAgVGhlIE1BWF9DRV9OVU0gaXMgdGhlIG1heGltdW0gc2l6 ZSB0aGF0Cj4gbWVzb25fY2hpcC0+c2Vsc1tdIGlzIGFsbG93ZWQgdG8gYmUgYnV0IG1lc29uX2No aXAtPm5zZWxzIGlzIHRoZSBhY3R1YWwKPiBzaXplLgo+IAo+IEZpeGVzOiAyZDU3MGIzNGI0MWEg KCJtdGQ6IHJhd25hbmQ6IG1lc29uOiBhZGQgc3VwcG9ydCBmb3IgQW1sb2dpYyBOQU5EIGZsYXNo IGNvbnRyb2xsZXIgIikKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVu dGVyQG9yYWNsZS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu YyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyBiL2Ry aXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IGluZGV4IGU4NThkNThkOTdiMC4uOTRj OTBiZTdlMWUwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu Ywo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IEBAIC0yMjUsNyAr MjI1LDcgQEAgc3RhdGljIHZvaWQgbWVzb25fbmZjX3NlbGVjdF9jaGlwKHN0cnVjdCBuYW5kX2No aXAgKm5hbmQsIGludCBjaGlwKQo+ICAJc3RydWN0IG1lc29uX25mYyAqbmZjID0gbmFuZF9nZXRf Y29udHJvbGxlcl9kYXRhKG5hbmQpOwo+ICAJaW50IHJldCwgdmFsdWU7Cj4gIAo+IC0JaWYgKGNo aXAgPCAwIHx8IFdBUk5fT05fT05DRShjaGlwID4gTUFYX0NFX05VTSkpCj4gKwlpZiAoY2hpcCA8 IDAgfHwgV0FSTl9PTl9PTkNFKGNoaXAgPj0gbWVzb25fY2hpcC0+bnNlbHMpKQo+ICAJCXJldHVy bjsKPiAgCj4gIAluZmMtPnBhcmFtLmNoaXBfc2VsZWN0ID0gbWVzb25fY2hpcC0+c2Vsc1tjaGlw XSA/IE5BTkRfQ0UxIDogTkFORF9DRTA7CgpJIGFtIGdvbm5hIGZvbGQgdGhpcyB0aHJlZSBwYXRj aGVzIGlmIHRoaXMgaXMgZmluZSBmb3IgeW91IHdpdGggdGhlCm9yaWdpbmFsIHBhdGNoIGFkZGlu ZyB0aGUgZHJpdmVyIHdoaWNoIGlzIGN1cnJlbnRseSBpbiBteSBuZXh0IGJyYW5jaC4KCgpUaGFu a3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFtbG9naWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C688C282CB for ; Tue, 5 Feb 2019 13:08:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB9DB20844 for ; Tue, 5 Feb 2019 13:08:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HB6X0ycZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB9DB20844 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ftj5FRvQ4FTZG4v5RuI5Q8jFr2njyYWHYwxyyOAn3Xk=; b=HB6X0ycZLdSSfY iYt2mvDCjSP1cPCUBgUPDbEQNAaWSwHJvpwQY3CT7fMTOoSM4PcmmD5e4j+fjn490UBFtnLLTpoaW O9fWMelcsS2oJx9LYJrfIocuS1dImx0RLN194KxmH+GPZhGr8G3JEYIcWtg0oHou6W3n0tcqxss/k wMc3ldhtfmH3QE2c8pehxsv+bRdv7USInU73z+ii9SwPHsYEjGRGWKLhZ8uiEIwjWa+beKdbF6Gzq umqVhDlMSmnD/ZuOKY9XFHrObpI23kBH9K7aEa+UtAoKimxUdcZJNIaVAkPFWbULKAFb+38x0C9NF 9hROdQfRx/barn9xLwwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr0Sp-00078Q-GT; Tue, 05 Feb 2019 13:08:35 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr0Sl-00077N-EL; Tue, 05 Feb 2019 13:08:33 +0000 X-Originating-IP: 90.88.22.177 Received: from xps13 (aaubervilliers-681-1-80-177.w90-88.abo.wanadoo.fr [90.88.22.177]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 5C8F360014; Tue, 5 Feb 2019 13:08:19 +0000 (UTC) Date: Tue, 5 Feb 2019 14:08:18 +0100 From: Miquel Raynal To: Dan Carpenter Subject: Re: [PATCH 1/3] mtd: rawnand: meson: Fix a limit test in meson_nfc_select_chip() Message-ID: <20190205140818.2de31843@xps13> In-Reply-To: <20190201082922.GC8459@kadam> References: <20190201082922.GC8459@kadam> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190205_050831_629335_02632488 X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , kernel-janitors@vger.kernel.org, Marek Vasut , Liang Yang , linux-mtd@lists.infradead.org, Kevin Hilman , linux-amlogic@lists.infradead.org, Brian Norris , David Woodhouse Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgRGFuLAoKRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPiB3cm90ZSBv biBGcmksIDEgRmViIDIwMTkKMTE6Mjk6MjIgKzAzMDA6Cgo+IFRoaXMgdGVzdCBpcyBvZmYgYnkg b25lIGJlY2F1c2UgdGhlID4gc2hvdWxkIGJlID49IGFuZCBpdCdzIGFsc28gdGVzdGluZwo+IGFn YWluc3QgdGhlIHdyb25nIGxpbWl0LiAgVGhlIE1BWF9DRV9OVU0gaXMgdGhlIG1heGltdW0gc2l6 ZSB0aGF0Cj4gbWVzb25fY2hpcC0+c2Vsc1tdIGlzIGFsbG93ZWQgdG8gYmUgYnV0IG1lc29uX2No aXAtPm5zZWxzIGlzIHRoZSBhY3R1YWwKPiBzaXplLgo+IAo+IEZpeGVzOiAyZDU3MGIzNGI0MWEg KCJtdGQ6IHJhd25hbmQ6IG1lc29uOiBhZGQgc3VwcG9ydCBmb3IgQW1sb2dpYyBOQU5EIGZsYXNo IGNvbnRyb2xsZXIgIikKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVu dGVyQG9yYWNsZS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu YyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyBiL2Ry aXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IGluZGV4IGU4NThkNThkOTdiMC4uOTRj OTBiZTdlMWUwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu Ywo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IEBAIC0yMjUsNyAr MjI1LDcgQEAgc3RhdGljIHZvaWQgbWVzb25fbmZjX3NlbGVjdF9jaGlwKHN0cnVjdCBuYW5kX2No aXAgKm5hbmQsIGludCBjaGlwKQo+ICAJc3RydWN0IG1lc29uX25mYyAqbmZjID0gbmFuZF9nZXRf Y29udHJvbGxlcl9kYXRhKG5hbmQpOwo+ICAJaW50IHJldCwgdmFsdWU7Cj4gIAo+IC0JaWYgKGNo aXAgPCAwIHx8IFdBUk5fT05fT05DRShjaGlwID4gTUFYX0NFX05VTSkpCj4gKwlpZiAoY2hpcCA8 IDAgfHwgV0FSTl9PTl9PTkNFKGNoaXAgPj0gbWVzb25fY2hpcC0+bnNlbHMpKQo+ICAJCXJldHVy bjsKPiAgCj4gIAluZmMtPnBhcmFtLmNoaXBfc2VsZWN0ID0gbWVzb25fY2hpcC0+c2Vsc1tjaGlw XSA/IE5BTkRfQ0UxIDogTkFORF9DRTA7CgpJIGFtIGdvbm5hIGZvbGQgdGhpcyB0aHJlZSBwYXRj aGVzIGlmIHRoaXMgaXMgZmluZSBmb3IgeW91IHdpdGggdGhlCm9yaWdpbmFsIHBhdGNoIGFkZGlu ZyB0aGUgZHJpdmVyIHdoaWNoIGlzIGN1cnJlbnRseSBpbiBteSBuZXh0IGJyYW5jaC4KCgpUaGFu a3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg==